From: Iain Buclaw <ibuclaw@gdcproject.org>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/5] Updates d_language_defn to not use macro expansion
Date: Thu, 16 Jan 2014 17:03:00 -0000 [thread overview]
Message-ID: <CABOHX+cfsF-vm-1WkhQ-wmVqHvLbaQXfhbGuJAzPa2BeZOX7TQ@mail.gmail.com> (raw)
In-Reply-To: <87ha94ngh3.fsf@fleche.redhat.com>
On 16 January 2014 14:34, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Iain" == Iain Buclaw <ibuclaw@gdcproject.org> writes:
>
> Iain> Is there anything else needed to be done from me? Just asking as I
> Iain> noticed a change to the way that requires this patch to be updated.
>
> I wasn't keeping score, but if all the patches are approved, you can
> rebase (our git repository rejects merge commits on master), merge to
> master, and push. If a patch needs any changes during the rebase, you
> can use your judgment -- if it is just a trivial change, post the
> updated patch as an FYI; if it required some work, usually another round
> of review is needed.
>
It's just trivial, see the change you did to set_main_name (sorry in
advanced for long url link)
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blobdiff;f=gdb/symtab.c;h=a8073b8ef7e8027566949952b9115631e33a5f5f;hp=5e988c88efceebfbc90192151e57938884ce62ea;hb=9e6c82ad4f55d0ff125721b94fa2191f1cc1000a;hpb=6ef55de768d4ab9065bc92aa00d828212c4af4f0
Regards
Iain
next prev parent reply other threads:[~2014-01-16 17:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 13:07 Iain Buclaw
2014-01-09 18:15 ` Tom Tromey
2014-01-09 18:32 ` Iain Buclaw
2014-01-10 12:06 ` Iain Buclaw
2014-01-10 17:14 ` Tom Tromey
2014-01-16 10:59 ` Iain Buclaw
2014-01-16 14:34 ` Tom Tromey
2014-01-16 17:03 ` Iain Buclaw [this message]
2014-01-16 17:11 ` Tom Tromey
2014-01-18 18:21 ` Iain Buclaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABOHX+cfsF-vm-1WkhQ-wmVqHvLbaQXfhbGuJAzPa2BeZOX7TQ@mail.gmail.com \
--to=ibuclaw@gdcproject.org \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).