From: Iain Buclaw <ibuclaw@gdcproject.org>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/5] Updates d_language_defn to not use macro expansion
Date: Thu, 09 Jan 2014 18:32:00 -0000 [thread overview]
Message-ID: <CABOHX+eMZD3xky9axEq1dUTznO0QT5k-GK+-0GUE5W60CrCo4Q@mail.gmail.com> (raw)
In-Reply-To: <871u0h9g41.fsf@fleche.redhat.com>
On 9 January 2014 18:15, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Iain" == Iain Buclaw <ibuclaw@gdcproject.org> writes:
>
> Iain> D doesn't have macros, so it makes little sense to use macro_expansion_c.
> Iain> 2014-01-09 Iain Buclaw <ibuclaw@gdcproject.org>
>
> Iain> * d-lang.c (d_language_defn): Change macro_expansion_c to
> Iain> macro_expansion_no.
>
> Iain> @@ -259,8 +259,8 @@ static const struct language_defn d_language_defn =
> Iain> c_value_print, /* Print a top-level value. */
> Iain> default_read_var_value, /* la_read_var_value */
> Iain> NULL, /* Language specific skip_trampoline. */
> Iain> - "this",
> Iain> - basic_lookup_symbol_nonlocal,
> Iain> + "this", /* name_of_this */
> Iain> + basic_lookup_symbol_nonlocal,
> Iain> basic_lookup_transparent_type,
> Iain> d_demangle, /* Language specific symbol demangler. */
> Iain> NULL, /* Language specific
>
> Spurious change.
> This patch is ok with this removed.
>
It was a comment found in every other language file, it was useful
when I was studying how things were set-up. Can remove it.
next prev parent reply other threads:[~2014-01-09 18:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 13:07 Iain Buclaw
2014-01-09 18:15 ` Tom Tromey
2014-01-09 18:32 ` Iain Buclaw [this message]
2014-01-10 12:06 ` Iain Buclaw
2014-01-10 17:14 ` Tom Tromey
2014-01-16 10:59 ` Iain Buclaw
2014-01-16 14:34 ` Tom Tromey
2014-01-16 17:03 ` Iain Buclaw
2014-01-16 17:11 ` Tom Tromey
2014-01-18 18:21 ` Iain Buclaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABOHX+eMZD3xky9axEq1dUTznO0QT5k-GK+-0GUE5W60CrCo4Q@mail.gmail.com \
--to=ibuclaw@gdcproject.org \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).