From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x36.google.com (mail-oa1-x36.google.com [IPv6:2001:4860:4864:20::36]) by sourceware.org (Postfix) with ESMTPS id 0EAA2385828E for ; Thu, 2 Feb 2023 11:11:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0EAA2385828E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-163adf0cfc4so1963318fac.7 for ; Thu, 02 Feb 2023 03:11:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rMr2zm2JxhsOUD0vK8grbb3LocAoWd3Y/tHai0N/moM=; b=q2Zo0NG+DwWJ5WyNO0WXji3tRIX4y4RSG1llXmCgAw1zechtku8B+lhf+Ac7okQvxD R3T1ztXoI5SDCSkFmFl0NCTZkXm72lKKuzx4MFVBaN9ahnx3RYUvoJ9Dk24PrbumttHt M1P9mA4pAgTd+G1NaWuNkyPEs+pT3Or+igOPS/BgO9EcQG+5nlCKc+jLJ6FC75u7nAt4 sJCuwh/hfbLHR7+VuR8isESI4UmeoiIytOLDsmP1se+fJBcRiuID46rP1AqzbNfNUaXf kNCMAny2u1OnMczbX6FTzo0u/Dy72SbiFnWe1A4btQLS3/jqPcdIYEkgMYaw16DzNNu4 qbgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rMr2zm2JxhsOUD0vK8grbb3LocAoWd3Y/tHai0N/moM=; b=vJ9DjAm8Lg7VjyOjrcD/NFfswhOcVYCGNwsPy2qyXMDst7A/5qP91LIeasOBtYCCfU DDsOfqZY/Qerj6DjWQH2ByD6tkJ2PLYKdcx3eRcTHMvwNaOknk//w5bb6wLz7Pr/jYIi esF1XizpNBSgSEaMwRntCKK3T47+ssOch45n8uyPz8Z6xaJ6jwQ5nOp5UqzCnG4CFvRw 6WvXZMv75WXMW7FpO6cOz5mUZEof5YesxsMV5HW8DYzrjkS+e7y7rfnx0zrpEN791oH+ zsAuCVIzCOEpixFH72nIbsraa5D8sswwRtE3nNDhkFWCSLfpqrlOAvgqVI8y2riwD7Z3 mbcQ== X-Gm-Message-State: AO0yUKVM5W5Jl1TQYpg+etiiGjjjzan32OHBvY/gDqpd0HWrqYwCc0WU fKTghIKyXZf3zYn2SPnr5f6b8WtuZS1G/4N5vSnYm0JHbXM= X-Google-Smtp-Source: AK7set9HH3jC6dFSmy5iiQvynCryg47DX8Zq/SBmj/2+EtViJM6lGAeY5oZAeQ7JP0GbrYRQ1tSvyHPZcCsTcE7yZQc= X-Received: by 2002:a05:6870:3048:b0:15f:d0bb:fa63 with SMTP id u8-20020a056870304800b0015fd0bbfa63mr285369oau.3.1675336281183; Thu, 02 Feb 2023 03:11:21 -0800 (PST) MIME-Version: 1.0 References: <20230202092950.tpxei5w4meutjeiv@ubuntu.lan> In-Reply-To: <20230202092950.tpxei5w4meutjeiv@ubuntu.lan> From: strager Date: Thu, 2 Feb 2023 03:11:10 -0800 Message-ID: Subject: Re: [PATCH] gdb/tui: add 'set tui mouse-events off' to restore mouse selection To: Lancelot SIX Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Feb 2, 2023 at 1:33 AM Lancelot SIX wrote: > > Hi, > > Thanks for working on this! I think I got used to use the "shift" key > when I try to select, but soon might soon have "set tui mouse-events > off" in my rc file. I'm glad to hear my patch is useful to someone else! I didn't know about the shift trick until *after* I submitted this patch. = =F0=9F=98=B3 On Thu, Feb 2, 2023 at 1:33 AM Lancelot SIX wrote: > - In GDB codebase, we use tab for indentation[1]: > > Lines should be indented with a mix of tabs and spaces. 8 spaces > should be replaced with Tab. > > It looks like you patch uses spaces for indentation. That's probably an issue with my mail client. The email attachment patch file should have the proper tabs. On Thu, Feb 2, 2023 at 1:33 AM Lancelot SIX wrote: > -GDB prefers "nullptr" instead of "NULL". I copied NULL from some other code in gdb, but I can change it if needed.