From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) by sourceware.org (Postfix) with ESMTPS id 9ECE93858CDB for ; Thu, 13 Jul 2023 21:31:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9ECE93858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-il1-x12c.google.com with SMTP id e9e14a558f8ab-3476c902f2aso4890695ab.3 for ; Thu, 13 Jul 2023 14:31:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689283867; x=1691875867; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=TzwFLQuwacA/dEsUarAj52TDdDF8sA5/JuCcoNOGFqo=; b=VSWM1Hq9qj2HQkzj4TXmpmKIbLvRsLwR+sR//8k50FQ1xvIhYUtcDO6SYz6ur9p49q td7P934nRV1zWwZCU1gSo/WfweSK6ajt313/XPNof5ERoQez7WfPUGYld9uPxex5zSpb NhBkdyTPNFRSxT8CNv8nuVc8Z0JSi5NAd8GPbaWBY7hcHtzRO8xESlctHRgtJhkNJzhx uVFu/gePDFILJD3Amv1DaUxXaa+bVgFuYslfjf4CsGQe1YYHInf6L4Ei7J1uyJpxGZLw k9H09l97bLmmvNdCsILWMNMXMP+JZ+pZi90mi8jFgAn6XzM0wyDV2WDBi1OWKPsoLMJy /Xxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689283867; x=1691875867; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TzwFLQuwacA/dEsUarAj52TDdDF8sA5/JuCcoNOGFqo=; b=TTr7hGhOwS6lMILSsNMVTLErU9hbx1GDcRp3u1FC4pcA4/5RRs2d344PQI+XMsWEka kI8pPROcrS2vUZsdeFuIT5hDJF8FbHqXCwMW0mW3Hgf5/Wqklm5tyb5GeJ8PAsvBX47y vBw5MKKtnSWuMaC8CYNBKYilqO/eROPI9U33ibO44wyN4d8TAXmXVjYTMZ9c2bEovfTL 5NDkzIcnF8xuZmWEU3uFyc1Ldo9L/e1TnNTNBUokIS0SIcWiBNcnbBVEzFJVslrdSmN2 6lTlJIyEBhtdEvXop0hyU2+bLxUOPiAduWJneM75ezT/E7qc0YVOdtksxfi89lpMRJoG BmCQ== X-Gm-Message-State: ABy/qLYhXGX2wCZfB7TVedQUiff/ptOJoYo37rE85D7x9yzS4hmR/vLK 76T5aOaEFU7tK2hSkkLYCozQTotUT5c306bk7pU= X-Google-Smtp-Source: APBJJlFl8+jIJ1QcW+zQC5N7dpal5F1Fk9rTiSHjLCTFsUHPyIS6ht5q9zmR8GuglGWuCx+qVNk2af59MhhRxK1EtjY= X-Received: by 2002:a05:6e02:150:b0:345:e9a4:c6e5 with SMTP id j16-20020a056e02015000b00345e9a4c6e5mr2770228ilr.13.1689283866804; Thu, 13 Jul 2023 14:31:06 -0700 (PDT) MIME-Version: 1.0 References: <20230713102411.2279542-1-blarsen@redhat.com> <20230713102411.2279542-5-blarsen@redhat.com> <7774b382-a663-f593-ea99-c52a8495aead@redhat.com> In-Reply-To: <7774b382-a663-f593-ea99-c52a8495aead@redhat.com> From: Matt Rice Date: Thu, 13 Jul 2023 21:30:55 +0000 Message-ID: Subject: Re: [PATCH v4 4/4] gdb/doc: document '+' argument for 'list' command To: Keith Seitz Cc: Bruno Larsen , gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Jul 13, 2023 at 5:36=E2=80=AFPM Keith Seitz via Gdb-patches wrote: > > On 7/13/23 03:24, Bruno Larsen via Gdb-patches wrote: > > > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > > index 20c9b24400d..cd86da50f46 100644 > > --- a/gdb/doc/gdb.texinfo > > +++ b/gdb/doc/gdb.texinfo > > @@ -9148,6 +9148,9 @@ Stack}), this prints lines centered around that l= ine. If no > > @code{list} command has been used and no solitary line was printed, > > it prints the lines around the function @code{main}. > > > > +@item list + > > +Same as using with no arguments. > > + > > @item list - > > Print lines just before the lines last printed. > > > > Grepping gdb.texinfo for "list +" definitely has a result: > > $ grep 'list +' gdb.texinfo > @item list + > list +[NSText initialize] > > This is from the same "Printing Source Line" section of the Manual > that your patch touches. This is the blurb which gives a "complete > description of the possible arguments for list". I guess it is worth noting that this usage of 'list +[NSText initialize]', is completely different than the first match '@item list +' Keith refers to, it comes from the objective-c section and in that case the '+' signifies that the initialize method is a class method. That one comes from the section "Method Names in Commands", an awkward bit of ambiguity. But it took me a bit to figure out what you were actually referring to, not seeing the NSText match in that section. > What your patch does is actually add "list +" to the "most commonly used" > blurb at the top of the section. > > I'm not sure I really find that compelling, given that it is essentially > synonymous with just repeating/hitting enter, documented just above it. > To be clear, I am not entirely against it. I'll leave it to the documenta= tion > experts. > > [And I see we have a near mid-air collision with an Approved-by. So ignor= e me!] > > Keith >