From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by sourceware.org (Postfix) with ESMTPS id E8F6E385023F for ; Sat, 4 Jun 2022 17:27:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E8F6E385023F Received: by mail-wr1-x430.google.com with SMTP id d14so5255022wra.10 for ; Sat, 04 Jun 2022 10:27:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pCe4mIdB749jvcvbBiYjzvEHGLJo1Y6LmYpOrl/QdRY=; b=Dh/RZtK2fzSZvGVsIFSdZ7o9EmPwW+rvaeQGqMJRRbTBek8DiU/tjga6J+uDcysuSi 1dMbt1wkwn4sXdw2XroHbsSI8GWfvKk6JALA2xm9M633jvm0LMTTxGGsfJoUouQsXSYV /HgLPvyeEFsp5N4xw4FmDwVq+aO7MSoRPFkBlg4f0aOScj78MNHuFqX9tL5dUAy++Dw1 OIvFPuPwaxKKl+Q97JUSb8lJkCnUlbQeIvP5wu93XFySE2cJ7NMqRRBNBoAiAtr1cqN9 Z+Hek5s0bYiv9sLsE+D7JlOhAahYhbNOdDiFFrnphyMAzlCL+9iBlq6qJAJryCHE5hiz MLUw== X-Gm-Message-State: AOAM533MnxuishGrLDPqzfk5v9x+rnbZiMkoOY6KezYm0DXjIQjtaRql t7i94EHeEWa7JtAnFe0a7Yv6sDmA2fwNcqI3k/Y= X-Google-Smtp-Source: ABdhPJzWFOwmeQQRXkeEqFBbs/xWagcVGnxKRl+3vOe0Gg0pWyxCFqQGbXJTHryBr2rA8dCtG2kzCyjPy3ZknI3wezU= X-Received: by 2002:adf:8bc2:0:b0:20e:7a89:277 with SMTP id w2-20020adf8bc2000000b0020e7a890277mr13390726wra.58.1654363668405; Sat, 04 Jun 2022 10:27:48 -0700 (PDT) MIME-Version: 1.0 References: <20220417155311.3487509-1-philippe.waroquiers@skynet.be> <874988bef430ed6e239e74a4a94eb2ad13175f4a.camel@skynet.be> <1001e780cc1d9f7a85923d6707bf17f063b8da90.camel@skynet.be> <24da89de-d36f-53c7-fe69-a8c7a1c38caf@redhat.com> <83o7z9aqvm.fsf@gnu.org> In-Reply-To: <83o7z9aqvm.fsf@gnu.org> From: Matt Rice Date: Sat, 4 Jun 2022 17:27:37 +0000 Message-ID: Subject: Re: [RFA] Show locno for 'multi location' breakpoint hit msg+conv var $bkptno $locno. To: Eli Zaretskii Cc: Keith Seitz , "gdb-patches@sourceware.org" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Jun 2022 17:27:51 -0000 On Sat, Jun 4, 2022 at 6:23 AM Eli Zaretskii via Gdb-patches wrote: > > > Date: Fri, 3 Jun 2022 13:40:00 -0700 > > From: Keith Seitz via Gdb-patches > > > > I looked up the history of this patch a bit to understand the motivation > > for querying co-workers... I see Eli commented in the original April > > discussion: > > > > > I'm not sure everyone will want to see the likes of > > > > > > Thread 1 "foobar" hit breakpoint 10.42, some_func () at ... > > > > > > But that's MO; I'd be interested in opinions of others. > > > > Well, I'm not a global maintainer, but I'll chime in with my opinion, > > if everyone will permit me. [Ha! You're already reading it!] > > > > I don't think it is a big deal to see ".42" in the output. Far more > > irritating is not knowing exactly which of the many locations it hit. > > I've always felt this was akin to ambiguous output by GDB. "You hit > > breakpoint X." Oh, wait, that's one of fifty different real breakpoints. > > We show the source line where the breakpoint breaks right after this, > so at least some of the ambiguity is resolved by that. My thoughts are that whether or not source line resolving ambiguity printing the breakpoint locno may be useful for instance, `disable 10.42` to disable that location, you wouldn't have to do info break and look through the what or address column of `info b`.