From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id 73E1D3858C41 for ; Thu, 18 May 2023 20:34:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 73E1D3858C41 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1ae4c5e1388so25539895ad.1 for ; Thu, 18 May 2023 13:34:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684442072; x=1687034072; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ytu7f8T0OzL5KuZxfNePapIVapedcMLFKjndYrc6Ra0=; b=DGJ7UkyCLIREk3noe/+Y1X3Fx2ybIoYgzpCKXr6F8sZOjQIZ3oceJao8wfwyuGPKAV pCBll30cv8fuSbjgZ1Zisv1b/r7CvlntMz9buXOG4ZY+kZP7ojwaLKN75k2k7z1cp4r4 l8bNIUhE3beKJOqZRJjw9yQeNe0xMNPPkXYGWabelej6O6pfjsNLKowZNdvOGY6iptce GqtU9IE4swc6npYFqoNS0zWcxUZnn6clUyYSrdmV8HIkNKzvoJTpAmPGnvYvZE03LGOJ 42XBDxNFwXw+SkIFJ8gDZD7k8rE2VBRjK243Yih+pZqCmUyf30PGHH/h8IPdwCb8sj9v A59w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684442072; x=1687034072; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ytu7f8T0OzL5KuZxfNePapIVapedcMLFKjndYrc6Ra0=; b=DaSfUITUj+nDUq6pJVnBdk1+UxFb/VMIWDZtx5L8UtNY7zz2xLs1RD2Qb8q4ydOouV 2FxdzKgNsB6wLWvtHi7LdqLScdQltSqGHvjtCplypZK7kxpmOW1Kx7kq+pYXCzqo93VA /8Aop5IWkS+i+2d7i4YzT/nTZ5HDgypAj9ItLdcXvJdH6IJ85Zb0jxgXZnVT4eLWXDA8 /2IFB6bgJoV+o3ddi23WZNK/NXjK/hzP1qHlqx/ewwA4KA7HFsgh4AyR7J2lYpTPapku UGgWi5HHx2t1PkLAgJJ6uwJQKHAKpKs0iNIpdOo0ZzPKqMCeGajXVh2fqxIZ9ztaitnA JrlQ== X-Gm-Message-State: AC+VfDzaIclNnairNPZ7R9aWN/gw1lyUzqn30WX3FcEk+x/pcg12DdEI mCqE6uWpEAZSy1yJG8BKfwZs7lFS+fLNvVeLzKw= X-Google-Smtp-Source: ACHHUZ5A9I8bnI1KhiH/8fahLGP0oZUT0ueMwhmpfVxD6Qd17sBMmp5IKYaJX6G5JfKMhforXlINZj2Q5ECmwEBxod8= X-Received: by 2002:a17:903:2584:b0:1ab:d6f:51b0 with SMTP id jb4-20020a170903258400b001ab0d6f51b0mr322204plb.18.1684442072513; Thu, 18 May 2023 13:34:32 -0700 (PDT) MIME-Version: 1.0 References: <20230404-dap-loaded-sources-v1-0-75c796bd644b@adacore.com> <20230404-dap-loaded-sources-v1-8-75c796bd644b@adacore.com> <83bkk3tqh3.fsf@gnu.org> <87h6s9zfnt.fsf@tromey.com> <83a5y1v6d1.fsf@gnu.org> <87a5y1z99o.fsf@tromey.com> In-Reply-To: <87a5y1z99o.fsf@tromey.com> From: Matt Rice Date: Thu, 18 May 2023 20:34:21 +0000 Message-ID: Subject: Re: [PATCH 8/9] Implement gdb.execute_mi To: Tom Tromey Cc: Eli Zaretskii , gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, May 18, 2023 at 8:15=E2=80=AFPM Tom Tromey via Gdb-patches wrote: > > >> In MI, the leading '-' is not really part of the command name. It see= ms > >> to be some kind of syntactic marker, though I have no idea why, as the= re > >> aren't any other possible such markers as far as I can tell. > > Eli> I'm not going to object, but frankly, it sounds strange. Our > Eli> documentation of MI commands includes the leading dash with each > Eli> command, so for the reader the dash is part of the command. > > Alright. I made this change in v2. I don't have much preference either way, but it brought to mind that there are issues with kwargs, with dict keys containing hyphens. If this were a problem though, it would also apply to other hyphenated command names, like 'break-insert' regardless of the initial hyphen. I suppose that people trying to map mi commands to kwargs would perhaps just have to mangle mi commands...