Re: [PATCH v2] gdb/Python: Added ThreadExitedEvent

[Simon Farre <simon.farre.cx@gmail.com>]

I was unaware of the LWP not being cross-platform, perhaps this field
should be removed then?
Or is there some relevant/similar info on other platforms that can be
returned here (and by that
logic, also change the attribute to a name that logically could explain the
attribute in a cross-platform
manner?)

On Fri, Apr 15, 2022 at 9:46 PM Eli Zaretskii <eliz@gnu.org> wrote:

> > Date: Tue, 12 Apr 2022 11:03:15 +0200
> > From: Simon Farre via Gdb-patches <gdb-patches@sourceware.org>
> >
> > diff --git a/gdb/NEWS b/gdb/NEWS
> > index 760cb2b7abc..985121d5818 100644
> > --- a/gdb/NEWS
> > +++ b/gdb/NEWS
> > @@ -38,6 +38,9 @@ maintenance info line-table
> >       This is the same format that GDB uses when printing address,
> symbol,
> >       and offset information from the disassembler.
> >
> > +  ** gdb.ThreadExitedEvent added. Emits LWP ID, TID and GLOBAL NUM of
> the
> > +     exiting thread.
> > +
> >  *** Changes in GDB 12
>
> This part is OK.
>
> > diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi
> > index 7c414b01d70..9a410dc18f8 100644
> > --- a/gdb/doc/python.texi
> > +++ b/gdb/doc/python.texi
> > @@ -3568,6 +3568,22 @@ This has a single attribute:
> >  The new thread.
> >  @end defvar
> >
> > +@item events.thread_exited
> > +This is emitted when @value{GDBN} notices a thread has exited.  The
> event
> > +is of type @code{gdb.ThreadExitedEvent}.  This has three attributes:
> > +
> > +@defvar ThreadExitedEvent.num
> > +Global thread number.
> > +@end defvar
> > +
> > +@defvar ThreadExitedEvent.lwp
> > +The light weight process ID.
> > +@end defvar
> > +
> > +@defvar ThreadExitedEvent.tid
> > +The thread's thread id
> > +@end defvar
>
> This is also OK, but I wonder whether we should say something about
> the lwp part that it isn't available on all platforms?
>