From: Doug Evans <dje@google.com>
To: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH][PR 18438] PyExc_MemoryError != gdbpy_gdb_memory_error
Date: Tue, 26 May 2015 23:16:00 -0000 [thread overview]
Message-ID: <CADPb22Q+HQMU4tvWME=Qo7rd98mw5mf=wehYH3KJ6wdfU-GapA@mail.gmail.com> (raw)
In-Reply-To: <e89a8ffbacdfb7112205169d623e@google.com>
On Thu, May 21, 2015 at 1:28 PM, Doug Evans <dje@google.com> wrote:
> Hi.
>
> This patch fixes pr 18438.
> The problem here is that the wrong exception is being thrown
> causing python backtraces to be printed when they shouldn't be.
>
> There's still an issue of whether the error text should change.
> The user may not know what a lazy string is (and shouldn't have to,
> s/he may be using some random pretty-printer).
> Left for a separate patch, pr 18445.
>
> Regression tested on amd64-linux.
>
> 2015-05-21 Doug Evans <dje@google.com>
>
> PR python/18438
> * python/py-lazy-string.c (stpy_convert_to_value): Use
> gdbpy_gdb_memory_error not PyExc_MemoryError.
> (gdbpy_create_lazy_string_object): Ditto.
>
> testsuite/
> * gdb.python/py-lazy-string.c: New file.
> * gdb.python/py-lazy-string.exp: New file.
> * gdb.python/py-prettyprint.c (lazystring) <len>: New member.
> (main): Update. Add estring3, estring4.
> * gdb.python/py-prettyprint.exp: Add tests for strings at address 0.
> * gdb.python/py-prettyprint.py (pp_ls): Handle length.
Committed.
prev parent reply other threads:[~2015-05-26 23:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 20:28 Doug Evans
2015-05-26 23:16 ` Doug Evans [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADPb22Q+HQMU4tvWME=Qo7rd98mw5mf=wehYH3KJ6wdfU-GapA@mail.gmail.com' \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).