From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30096 invoked by alias); 5 Dec 2013 18:14:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30080 invoked by uid 89); 5 Dec 2013 18:14:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ve0-f181.google.com Received: from Unknown (HELO mail-ve0-f181.google.com) (209.85.128.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 05 Dec 2013 18:14:10 +0000 Received: by mail-ve0-f181.google.com with SMTP id oy12so13991269veb.40 for ; Thu, 05 Dec 2013 10:14:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=oEBaAlmRMU3YUMv3ZzafhLsKjBvfVtEW0Z7a0xSy2aU=; b=K88Vvm7u77uPyLaoFw/7Dxa4INRq9+mTHAeJ3kpSTWuZHBRn/kGo5Hif+O6h3BQ82R aANH9Kh/k2Fz0bNczWAm+zqglACTulgDY6YQLR5fBBGYYIQCVZxh9TDd43xa3eh7ieyn FcYGM80RBj61JxTJJ6MGhYg+DLpUoUxKGbERB3th4nKXwk2goIYoq6t53AbYi7IMeCKP ypzOyHA4HBsnBOZgATrU1WegMfQNibg4p3lyivQw/LmWUL+s2QdlfcHH3lGbPzpf/IvV PTZ89ucYoIfB1GGAY3hC4z5LmJqKdvxa+5VdUNu1GjYLVeq54CbA3Qn6jdwxJjqFFYfC b86g== X-Gm-Message-State: ALoCoQk0xlKEk8jSzsGJdAyNRwXbm3C+PafzKX8PvGvvx23a2aAiLDwD1xklKpUbIHRjbyzAutsWtyr5uCSa5Nvhu6/GePAz8rTfYPL0bk4LaQERZW6M1BGV2rytVj0dC4hbKHMsf5JaFB9AGBfRDaLthK6FNnGDuK4efrt1kfZ/Uoxsr0+Rl31jD200VNrSqe7G1+ENhufR51pOFHZva9c0VRIjJBr87w== MIME-Version: 1.0 X-Received: by 10.58.216.74 with SMTP id oo10mr65458435vec.0.1386267242442; Thu, 05 Dec 2013 10:14:02 -0800 (PST) Received: by 10.52.163.52 with HTTP; Thu, 5 Dec 2013 10:14:02 -0800 (PST) In-Reply-To: <52A0A733.3050001@redhat.com> References: <529F489F.7070805@broadcom.com> <52A0A733.3050001@redhat.com> Date: Thu, 05 Dec 2013 18:14:00 -0000 Message-ID: Subject: Re: PATCH [0/2] Convert unavailable vector to be bit, not byte, based. From: Doug Evans To: Pedro Alves Cc: Andrew Burgess , "gdb-patches@sourceware.org" Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00205.txt.bz2 On Thu, Dec 5, 2013 at 8:17 AM, Pedro Alves wrote: > On 12/04/2013 03:22 PM, Andrew Burgess wrote: >> This patch set is inspired by two previous patches I've posted: >> >> https://sourceware.org/ml/gdb-patches/2013-08/msg00305.html >> https://sourceware.org/ml/gdb-patches/2013-08/msg00309.html >> >> but I think can exist as a separate piece of work. > > Excellent! The new test is quite nice work. > >> The vector of unavailable parts of a value is currently byte based. >> Given that we can model a value down to the bit level, we can >> potentially loose information with the current implementation. After >> the patch we model the unavailable information in bits. > > It'd be good if this paragraph ended up in the commit log of patch 2. I'd prefer a comment in the code too fwiw. [and then if one still wants to add a comment to the commit log, go for it] A simple one-liner explaining why things are the way they are would be sufficient.