From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-116233-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 16230 invoked by alias); 29 Sep 2014 08:08:27 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 16218 invoked by uid 89); 29 Sep 2014 08:08:27 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-vc0-f170.google.com
Received: from mail-vc0-f170.google.com (HELO mail-vc0-f170.google.com) (209.85.220.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 29 Sep 2014 08:08:25 +0000
Received: by mail-vc0-f170.google.com with SMTP id hy10so830732vcb.29        for <gdb-patches@sourceware.org>; Mon, 29 Sep 2014 01:08:23 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20130820;        h=x-gm-message-state:mime-version:in-reply-to:references:date         :message-id:subject:from:to:cc:content-type;        bh=DanE8I/gatU2wXYXruXK93iwUy4f9DfA6TcTr/wcAyA=;        b=KfJooBnP5qIXu7sTC+U7v8yYvNAIwF4sSYQ3PlNqlFnMy0yEyVYNVoLWhnJ5d8NBSl         z6jy0j4V8C3uHhLSTeil6xUXhEaOdKKM+fuhM9tBq5sjaLmr/BSJay1IQCVyRul5qiKI         Jav95Otj9SF/YO5vpBdz7T24KOUROvamakUbuba8l7c2cCpNDogzrLGbpgLhGEknaZUp         lJyr6NkokwCPJRbQjx5msRlImozcAE/D5rXxrPdxIntJoMJt51GzWhcKPlHKYryiIDrT         AaUFJsQYmviU/IZzuE9XufwISQvrc9MFcPe3RueX9Tc0tteJAhp0AAP4Ej61WUKmIJPt         vRXQ==
X-Gm-Message-State: ALoCoQk5QQkFIw+HMXae2VvBggT0KW5yDdanzoOxcusCfv99ylETrEgHbsBL9Ka0VhgIGddfSVOv
MIME-Version: 1.0
X-Received: by 10.221.41.198 with SMTP id tv6mr29482605vcb.4.1411978103771; Mon, 29 Sep 2014 01:08:23 -0700 (PDT)
Received: by 10.52.181.65 with HTTP; Mon, 29 Sep 2014 01:08:23 -0700 (PDT)
In-Reply-To: <CAGyQ6gwUDdJh+oUxJxhgSXfY90cp2hkh-+mN0wEcJp90naBXog@mail.gmail.com>
References: <CAGyQ6gwUDdJh+oUxJxhgSXfY90cp2hkh-+mN0wEcJp90naBXog@mail.gmail.com>
Date: Mon, 29 Sep 2014 08:08:00 -0000
Message-ID: <CADPb22Q6KH+i=Jwho3B2a-DACjYFrgFby0uG0LEnfOi3d=9HZg@mail.gmail.com>
Subject: Re: [PATCH 4/4] PR c++/13403 and PR c++/15154: Fix gnuv3_pass_by_reference to treat dynamic classes as non-trivial
From: Doug Evans <dje@google.com>
To: Siva Chandra <sivachandra@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2014-09/txt/msg00824.txt.bz2

On Thu, Sep 11, 2014 at 11:38 AM, Siva Chandra <sivachandra@google.com> wrote:
> gdb/ChangeLog:
>
> 2014-09-11  Siva Chandra Reddy  <sivachandra@google.com>
>
>         * gnu-v3-abi.c (gnuv3_pass_by_reference): Treat dynamic classes
>         as non-trivial.

This looks ok to me.
I couldn't find anything in the ABI to guide me (could certainly have
missed it), though it seems reasonable and it does fix the testcase.