From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-119330-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 5858 invoked by alias); 24 Jan 2015 01:46:54 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 5793 invoked by uid 89); 24 Jan 2015 01:46:50 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: mail-ob0-f175.google.com
Received: from mail-ob0-f175.google.com (HELO mail-ob0-f175.google.com) (209.85.214.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 24 Jan 2015 01:46:47 +0000
Received: by mail-ob0-f175.google.com with SMTP id wp4so565456obc.6        for <gdb-patches@sourceware.org>; Fri, 23 Jan 2015 17:46:46 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20130820;        h=x-gm-message-state:mime-version:in-reply-to:references:date         :message-id:subject:from:to:cc:content-type;        bh=W+sIq/S/cLTOXOhqbd0ljLV69e9hWrm57I1A9J0fxOc=;        b=RJNdSuhT8lWl37tZbF7tdK3YoIA08woPFsAGvu85zZV4Si1nW9D6mzvHao/0ovIC4g         mM4k3e4FzKLzqt8DvnxD9E6CC6kktfPGWjsEKD9xpgMrwDTCAtzXFACafaPbBChKfn2h         DBYwOUyl3/fFK4qh7ScEH0FAA786//T5Gq7kJRfC8cZ3/pY0SRE3bntaKPudR2nfQhcX         W0uD7ftsWZrg/p/cyyhGugPWiqmyqH4KpgaB0A+9OlF4jMLPTJQILehTPb7XldO7q/pt         GE7KwtkvOqvnjwumbY7DQRMb4LymuStsT3O9GCNekTxmN6NMyCRlUDTXc2jNFE/qGB7D         OV5A==
X-Gm-Message-State: ALoCoQlrde7vRHxR7TaIckr0VYplp5ONczTHskOzXI7thb10busZFtLLRd8SOu5yTjZzYSjJ7kHT
MIME-Version: 1.0
X-Received: by 10.202.185.198 with SMTP id j189mr6088546oif.72.1422064006063; Fri, 23 Jan 2015 17:46:46 -0800 (PST)
Received: by 10.182.222.98 with HTTP; Fri, 23 Jan 2015 17:46:45 -0800 (PST)
In-Reply-To: <20150122185509.GA16253@host2.jankratochvil.net>
References: <CADPb22Q2r9Vnne5rDapAy=AuD2AKBU01TRANw3djo5Xk1icvNw@mail.gmail.com>	<21548.37770.274873.760290@ruffy2.mtv.corp.google.com>	<20141002155653.GA9001@host2.jankratochvil.net>	<20141231192335.GA8188@host2.jankratochvil.net>	<21677.57646.178793.836948@ruffy2.mtv.corp.google.com>	<20150114202618.GA21056@host2.jankratochvil.net>	<21697.17716.292890.813248@ruffy2.mtv.corp.google.com>	<20150122185509.GA16253@host2.jankratochvil.net>
Date: Sat, 24 Jan 2015 12:32:00 -0000
Message-ID: <CADPb22Q7jL456mQQ6JVEa6C-Ajv1OPjo=oWZ8-juHCjrkaF1eA@mail.gmail.com>
Subject: Re: [patchv3] Fix 100x slowdown regression on DWZ files
From: Doug Evans <dje@google.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2015-01/txt/msg00664.txt.bz2

On Thu, Jan 22, 2015 at 10:55 AM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> On Thu, 22 Jan 2015 19:45:08 +0100, Doug Evans wrote:
>> In my mind it's easier to just treat a non-NULL value for line_header_hash
>> as the flag to decide whether we're using the hash (instead of
>> seen_partial_unit).
>
> Yes, sure I agree.  I just haven't realized this simplificaton while coding it.
>
>
>> Sound ok?
>
> Yes, I am fine with your change; so I expect you can check it in when you ask
> this way.

Can you check it in?  Thanks.