From: Doug Evans <dje@google.com>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [patch] Fix for PR gdb/9538 (loading of separate debuginfo and symlinks).
Date: Thu, 12 Jan 2012 23:25:00 -0000 [thread overview]
Message-ID: <CADPb22Q9qi3TsYw3ZFkAyuO6a0VEJ_wtM_4pe_tXzDW5myi29Q@mail.gmail.com> (raw)
In-Reply-To: <CALoOobOBfT4n5zXp-=4qyS_7+c0hkhWwxop9B=5aAHuti+bAWg@mail.gmail.com>
On Thu, Jan 12, 2012 at 2:26 PM, Paul Pluzhnikov <ppluzhnikov@google.com> wrote:
>>> +
>>> + debugfile = find_separate_debug_file (dir1, canon_dir, debuglink,
>>> + crc32, objfile);
>>> + xfree (canon_dir);
>>> +
>>> + if (debugfile != NULL)
>>> + goto cleanup1;
>>> +
>>> + /* For PR gdb/9538, try again with realpath (if different from the
>>> + original). */
>>> + dir2 = lrealpath (objfile->name);
>>
>> Maybe some optimization would be helpful. realpath is expensive and the
>> directory path is already canonicalized. Something like lstat (objfile->name)
>> and do this step only if it is a symlink.
>
> Wouldn't lstat need a configury #ifdef to make it build?
[for reference sake, one patch in my basenames-may-differ series (not
submitted) had a use for lstat.
IWBN to have lstat in gdb so we could (appropriately of course) use it.
OOC, Jan, what discussion led rise to having braces here:
+ if (strcmp (dir1, dir2) == 0)
+ {
+ /* Same directory, no point retrying. */
+ goto cleanup;
+ }
and does that reasoning apply here:
+ if (debuglink == NULL)
+ /* There's no separate debug info, hence there's no way we could
+ load it => no warning. */
+ return NULL;
next prev parent reply other threads:[~2012-01-12 23:18 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 3:12 Paul Pluzhnikov
2012-01-12 17:28 ` Doug Evans
2012-01-12 20:59 ` Paul Pluzhnikov
2012-01-12 21:31 ` Jan Kratochvil
2012-01-12 22:20 ` Paul Pluzhnikov
2012-01-12 22:27 ` Jan Kratochvil
2012-01-12 22:31 ` Paul Pluzhnikov
2012-01-12 22:29 ` Paul Pluzhnikov
2012-01-12 22:50 ` Jan Kratochvil
2012-01-12 23:12 ` Paul Pluzhnikov
2012-01-12 23:18 ` Jan Kratochvil
2012-01-12 23:25 ` Doug Evans [this message]
2012-01-12 23:27 ` Jan Kratochvil
2012-01-12 23:40 ` Doug Evans
2012-01-13 0:21 ` [doc patch] gdbint: braces for two lines in code [Re: [patch] Fix for PR gdb/9538 (loading of separate debuginfo and symlinks).] Jan Kratochvil
2012-01-13 0:27 ` Doug Evans
2012-01-13 4:02 ` Joel Brobecker
2012-01-13 11:09 ` Jan Kratochvil
2012-01-13 11:23 ` Pedro Alves
2012-01-13 11:55 ` Eli Zaretskii
2012-01-13 12:15 ` Joel Brobecker
2012-01-13 12:40 ` Eli Zaretskii
2012-01-13 14:37 ` [commit] " Jan Kratochvil
2012-01-13 9:05 ` Eli Zaretskii
2012-01-12 23:28 ` [patch] Fix for PR gdb/9538 (loading of separate debuginfo and symlinks) Paul Pluzhnikov
2012-01-12 23:55 ` Jan Kratochvil
2012-01-13 0:21 ` Paul Pluzhnikov
2012-01-13 0:48 ` Jan Kratochvil
2012-01-13 3:39 ` Paul Pluzhnikov
2012-01-18 19:15 ` Paul Pluzhnikov
2012-01-12 22:26 ` Doug Evans
2012-01-12 22:40 ` Paul Pluzhnikov
2012-01-12 22:52 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADPb22Q9qi3TsYw3ZFkAyuO6a0VEJ_wtM_4pe_tXzDW5myi29Q@mail.gmail.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=ppluzhnikov@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).