[PATCH] Build dw2-abs-hi-pc with nodebug

[PATCH] Build dw2-abs-hi-pc with nodebug

[Doug Evans]

Hi.

I was seeing this fail on fission, and traced it to the test
being compiled with debug info in addition to debug info coming
from the .S files.

[The failure is that when compiled with fission the breakpoint was set
on line 25 whereas the test is expecting 24.  I suspect the .S file
is wrong, but it's not egregiously so, so I've that alone.]

2014-03-06  Doug Evans  <dje@google.com>

	* gdb.dwarf2/dw2-abs-hi-pc.exp: Build tests with "nodebug".

diff --git a/gdb/testsuite/gdb.dwarf2/dw2-abs-hi-pc.exp b/gdb/testsuite/gdb.dwarf2/dw2-abs-hi-pc.exp
index 3353fda..4ca16cf 100644
--- a/gdb/testsuite/gdb.dwarf2/dw2-abs-hi-pc.exp
+++ b/gdb/testsuite/gdb.dwarf2/dw2-abs-hi-pc.exp
@@ -22,7 +22,7 @@ if {![dwarf2_support]} {
 standard_testfile
 set executable ${testfile}
 
-if {[build_executable ${testfile}.exp ${executable} "${testfile}.c ${testfile}-hello-dbg.S ${testfile}-hello.c ${testfile}-world-dbg.S ${testfile}-world.c"] == -1} {
+if {[build_executable ${testfile}.exp ${executable} "${testfile}.c ${testfile}-hello-dbg.S ${testfile}-hello.c ${testfile}-world-dbg.S ${testfile}-world.c" "nodebug"] == -1} {
     return -1
 }
 

Re: [PATCH] Build dw2-abs-hi-pc with nodebug

[Joel Brobecker]

> I was seeing this fail on fission, and traced it to the test
> being compiled with debug info in addition to debug info coming
> from the .S files.
> 
> [The failure is that when compiled with fission the breakpoint was set
> on line 25 whereas the test is expecting 24.  I suspect the .S file
> is wrong, but it's not egregiously so, so I've that alone.]
> 
> 2014-03-06  Doug Evans  <dje@google.com>
> 
> 	* gdb.dwarf2/dw2-abs-hi-pc.exp: Build tests with "nodebug".

Yes, I got tricked by the fact that we (nearly?) always add the "debug"
option when building, so I had no second thought when I removed it.
As explained to Doug on IRC, the point of the .S file is to be the
source of the debugging info for the correspoing .c file, so we must
compile the .c files without -g. Strange that it worked before at all...

Thanks for the fix, Doug!

> diff --git a/gdb/testsuite/gdb.dwarf2/dw2-abs-hi-pc.exp b/gdb/testsuite/gdb.dwarf2/dw2-abs-hi-pc.exp
> index 3353fda..4ca16cf 100644
> --- a/gdb/testsuite/gdb.dwarf2/dw2-abs-hi-pc.exp
> +++ b/gdb/testsuite/gdb.dwarf2/dw2-abs-hi-pc.exp
> @@ -22,7 +22,7 @@ if {![dwarf2_support]} {
>  standard_testfile
>  set executable ${testfile}
>  
> -if {[build_executable ${testfile}.exp ${executable} "${testfile}.c ${testfile}-hello-dbg.S ${testfile}-hello.c ${testfile}-world-dbg.S ${testfile}-world.c"] == -1} {
> +if {[build_executable ${testfile}.exp ${executable} "${testfile}.c ${testfile}-hello-dbg.S ${testfile}-hello.c ${testfile}-world-dbg.S ${testfile}-world.c" "nodebug"] == -1} {
>      return -1
>  }
>  

-- 
Joel

Re: [PATCH] Build dw2-abs-hi-pc with nodebug

[Doug Evans]

On Fri, Mar 7, 2014 at 5:09 AM, Joel Brobecker <brobecker@adacore.com> wrote:
>> I was seeing this fail on fission, and traced it to the test
>> being compiled with debug info in addition to debug info coming
>> from the .S files.
>>
>> [The failure is that when compiled with fission the breakpoint was set
>> on line 25 whereas the test is expecting 24.  I suspect the .S file
>> is wrong, but it's not egregiously so, so I've that alone.]
>>
>> 2014-03-06  Doug Evans  <dje@google.com>
>>
>>       * gdb.dwarf2/dw2-abs-hi-pc.exp: Build tests with "nodebug".
>
> Yes, I got tricked by the fact that we (nearly?) always add the "debug"
> option when building, so I had no second thought when I removed it.
> As explained to Doug on IRC, the point of the .S file is to be the
> source of the debugging info for the correspoing .c file, so we must
> compile the .c files without -g. Strange that it worked before at all...

Committed.