From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21562 invoked by alias); 21 Oct 2013 16:47:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21552 invoked by uid 89); 21 Oct 2013 16:47:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ve0-f172.google.com Received: from mail-ve0-f172.google.com (HELO mail-ve0-f172.google.com) (209.85.128.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 21 Oct 2013 16:47:04 +0000 Received: by mail-ve0-f172.google.com with SMTP id cz12so3672478veb.17 for ; Mon, 21 Oct 2013 09:47:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=SjHItKJsrbrS4Gyj78Sy6Q6W1eK1g9emDFjeRpLnth4=; b=U/HJNq9K+zSOUWByA5tahUL4gdkga2WSIEVDrQ+DBQ+ixr3/hGqUaiPJ2QNHgwy9rU MPVTlMYAc6aoZxyPPGSiuTwP43AlldnfdtiNvUMxRXqDNBZDhlVJt6crBAw0iELYMVqZ RGnG04kCaLfqi2btWGPSTB8Qvb55jRuaAzIRqxdz7xfRZhNHbLi2xsKw+F1cr48NmtQ+ /bOc4RXW0+Ykazq6bmtjyHjLYdHl/w562DPanrle6JFDg099H2M36REJdab+1zQYgDQY mmYdcmSsdqZXRVHBu2M7ehdwnpMnajgUr6RIArtbXDpO86Pe2/FMoY5YPM3Q0STBiCHd IYVA== X-Gm-Message-State: ALoCoQnukkNxpGyg+k1FmAQt463Ek+8+C4b4bZIWBmvJYFhFK1Aqi1RSxrUCBaSff+zP4UQZi+wpzhDS3oRBF377hShcjNFuUMdckQKZJJV1N3H81d8e5tK2AW2IAOHDFTtZGSkRZ/1JNwyTb5LT9dk4fj/tePlkj3VZnmE7adnNeVRyo2L3LeKVEoACBdLp5bKu8toWs+UVOB5/Ig10RO7EfAL6HnBgwA== MIME-Version: 1.0 X-Received: by 10.52.120.78 with SMTP id la14mr10219623vdb.9.1382374022208; Mon, 21 Oct 2013 09:47:02 -0700 (PDT) Received: by 10.52.37.138 with HTTP; Mon, 21 Oct 2013 09:47:02 -0700 (PDT) In-Reply-To: <8738nulhjf.fsf@fleche.redhat.com> References: <1382032193-9115-1-git-send-email-tromey@redhat.com> <1382032193-9115-2-git-send-email-tromey@redhat.com> <8738nulhjf.fsf@fleche.redhat.com> Date: Mon, 21 Oct 2013 16:47:00 -0000 Message-ID: Subject: Re: [PATCH v2 1/9] introduce minimal_symbol_upper_bound From: Doug Evans To: Tom Tromey Cc: gdb-patches Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00663.txt.bz2 On Mon, Oct 21, 2013 at 9:23 AM, Tom Tromey wrote: >>>>>> "Doug" == Doug Evans writes: > > Doug> When I read the comment "Try ..." I'm left with asking "What if the > Doug> attempt fails?". > Doug> Maybe remove the words "Try to" and be clearer about what the result > Doug> is if a heuristic is needed? > > I changed it to read: > > /* Compute the upper bound of MINSYM. The upper bound is the last > address thought to be part of the symbol. If the symbol has a > size, it is used. Otherwise use the lesser of the next minimal > symbol in the same section, or the end of the section, as the end > of the function. */ > > Let me know what you think. LGTM