* Source files are deleted in in-tree build/test
@ 2014-09-17 11:33 Yao Qi
2014-09-29 4:06 ` Doug Evans
2014-09-29 14:01 ` [PATCH 1/2] Don't remove files copied to host Yao Qi
0 siblings, 2 replies; 5+ messages in thread
From: Yao Qi @ 2014-09-17 11:33 UTC (permalink / raw)
To: gdb-patches
Hi,
If we do in-tree build and run tests sequentially,
$ make check RUNTESTFLAGS='--directory=gdb.dwarf'
$ make check RUNTESTFLAGS='--directory=gdb.python'
we can see some source files are deleted after tests,
# deleted: gdb.dwarf2/file1.txt
# deleted: gdb.python/py-frame-args.py
# deleted: gdb.python/py-framefilter.py
# deleted: gdb.python/py-pp-integral.py
# deleted: gdb.python/py-pp-re-notag.py
# deleted: gdb.python/py-prettyprint.py
# deleted: gdb.python/py-section-script.py
# deleted: gdb.python/py-typeprint.py
# deleted: gdb.python/py-xmethods.py
These tests have this the pattern like this:
set remote_python_file [gdb_remote_download host \
${srcdir}/${subdir}/${testfile}.py]
remote_file host delete ${remote_python_file}
In the in-tree build/test, remote_python_file is the source, so the
"remote_file host delete ${remote_python_file}" will delete the source
file, and cause the some fails in the tests after that.
Matt Rice fixed the problem in py-objfile-script.exp
<https://sourceware.org/ml/gdb-patches/2011-07/msg00225.html> by
renaming .py to .py.in and copy .py.in file to .py on running test.
However, it is not friendly to remote host testing w.r.t copying files
to remote host. Alternatively, we don't have to remote these files
copied to host. We discussed this there
<https://sourceware.org/ml/gdb-patches/2014-08/msg00269.html> without
any conclusions. Now, I am inclined to not removing files on host, as
justified by this problem. What do you think?
--
Yao (齐尧)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Source files are deleted in in-tree build/test
2014-09-17 11:33 Source files are deleted in in-tree build/test Yao Qi
@ 2014-09-29 4:06 ` Doug Evans
2014-09-29 14:01 ` [PATCH 1/2] Don't remove files copied to host Yao Qi
1 sibling, 0 replies; 5+ messages in thread
From: Doug Evans @ 2014-09-29 4:06 UTC (permalink / raw)
To: Yao Qi; +Cc: gdb-patches
On Wed, Sep 17, 2014 at 4:29 AM, Yao Qi <yao@codesourcery.com> wrote:
>
> Hi,
> If we do in-tree build and run tests sequentially,
>
> $ make check RUNTESTFLAGS='--directory=gdb.dwarf'
> $ make check RUNTESTFLAGS='--directory=gdb.python'
>
> we can see some source files are deleted after tests,
> [...]
> Alternatively, we don't have to remote these files
> copied to host. We discussed this there
> <https://sourceware.org/ml/gdb-patches/2014-08/msg00269.html> without
> any conclusions. Now, I am inclined to not removing files on host, as
> justified by this problem. What do you think?
Fine by me.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2/2] Rename py-objfile-script-gdb.py.in to py-objfile-script-gdb.py
2014-09-29 14:01 ` [PATCH 1/2] Don't remove files copied to host Yao Qi
@ 2014-09-29 14:01 ` Yao Qi
2014-10-20 5:45 ` [PATCH 1/2] Don't remove files copied to host Yao Qi
1 sibling, 0 replies; 5+ messages in thread
From: Yao Qi @ 2014-09-29 14:01 UTC (permalink / raw)
To: gdb-patches
Patch <https://sourceware.org/ml/gdb-patches/2011-07/msg00225.html> was
to fix the problem that py-objfile-script-gdb.py is removed after an
in-tree build and test. As a result of the previous patch (we don't
remove files copied to host any more), this patch is no longer needed.
This patch is to revert it logically.
gdb/testsuite:
2014-09-29 Yao Qi <yao@codesourcery.com>
* gdb.python/py-objfile-script-gdb.py.in: Rename it to ...
* gdb.python/py-objfile-script-gdb.py: New file.
* gdb.python/py-objfile-script.exp: Update reference to
py-objfile-script-gdb.py.in. Use gdb_remote_donwload instead
of remote_download. Remove the dest file.
---
gdb/testsuite/gdb.python/py-objfile-script-gdb.py | 63 ++++++++++++++++++++++
.../gdb.python/py-objfile-script-gdb.py.in | 63 ----------------------
gdb/testsuite/gdb.python/py-objfile-script.exp | 5 +-
3 files changed, 65 insertions(+), 66 deletions(-)
create mode 100644 gdb/testsuite/gdb.python/py-objfile-script-gdb.py
delete mode 100644 gdb/testsuite/gdb.python/py-objfile-script-gdb.py.in
diff --git a/gdb/testsuite/gdb.python/py-objfile-script-gdb.py b/gdb/testsuite/gdb.python/py-objfile-script-gdb.py
new file mode 100644
index 0000000..5910bdb
--- /dev/null
+++ b/gdb/testsuite/gdb.python/py-objfile-script-gdb.py
@@ -0,0 +1,63 @@
+# Copyright (C) 2011-2014 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+# This file is part of the GDB testsuite.
+
+import re
+
+class pp_ss:
+ def __init__(self, val):
+ self.val = val
+
+ def to_string(self):
+ return "a=<" + str(self.val["a"]) + "> b=<" + str(self.val["b"]) + ">"
+
+def lookup_function (val):
+ "Look-up and return a pretty-printer that can print val."
+
+ # Get the type.
+ type = val.type
+
+ # If it points to a reference, get the reference.
+ if type.code == gdb.TYPE_CODE_REF:
+ type = type.target ()
+
+ # Get the unqualified type, stripped of typedefs.
+ type = type.unqualified ().strip_typedefs ()
+
+ # Get the type name.
+ typename = type.tag
+
+ if typename == None:
+ return None
+
+ # Iterate over local dictionary of types to determine
+ # if a printer is registered for that type. Return an
+ # instantiation of the printer if found.
+ for function in pretty_printers_dict:
+ if function.match (typename):
+ return pretty_printers_dict[function] (val)
+
+ # Cannot find a pretty printer. Return None.
+
+ return None
+
+def register_pretty_printers ():
+ pretty_printers_dict[re.compile ('^ss$')] = pp_ss
+
+pretty_printers_dict = {}
+
+register_pretty_printers ()
+gdb.current_progspace().pretty_printers.append (lookup_function)
diff --git a/gdb/testsuite/gdb.python/py-objfile-script-gdb.py.in b/gdb/testsuite/gdb.python/py-objfile-script-gdb.py.in
deleted file mode 100644
index 5910bdb..0000000
--- a/gdb/testsuite/gdb.python/py-objfile-script-gdb.py.in
+++ /dev/null
@@ -1,63 +0,0 @@
-# Copyright (C) 2011-2014 Free Software Foundation, Inc.
-
-# This program is free software; you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation; either version 3 of the License, or
-# (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program. If not, see <http://www.gnu.org/licenses/>.
-
-# This file is part of the GDB testsuite.
-
-import re
-
-class pp_ss:
- def __init__(self, val):
- self.val = val
-
- def to_string(self):
- return "a=<" + str(self.val["a"]) + "> b=<" + str(self.val["b"]) + ">"
-
-def lookup_function (val):
- "Look-up and return a pretty-printer that can print val."
-
- # Get the type.
- type = val.type
-
- # If it points to a reference, get the reference.
- if type.code == gdb.TYPE_CODE_REF:
- type = type.target ()
-
- # Get the unqualified type, stripped of typedefs.
- type = type.unqualified ().strip_typedefs ()
-
- # Get the type name.
- typename = type.tag
-
- if typename == None:
- return None
-
- # Iterate over local dictionary of types to determine
- # if a printer is registered for that type. Return an
- # instantiation of the printer if found.
- for function in pretty_printers_dict:
- if function.match (typename):
- return pretty_printers_dict[function] (val)
-
- # Cannot find a pretty printer. Return None.
-
- return None
-
-def register_pretty_printers ():
- pretty_printers_dict[re.compile ('^ss$')] = pp_ss
-
-pretty_printers_dict = {}
-
-register_pretty_printers ()
-gdb.current_progspace().pretty_printers.append (lookup_function)
diff --git a/gdb/testsuite/gdb.python/py-objfile-script.exp b/gdb/testsuite/gdb.python/py-objfile-script.exp
index 298bc3e..a844163 100644
--- a/gdb/testsuite/gdb.python/py-objfile-script.exp
+++ b/gdb/testsuite/gdb.python/py-objfile-script.exp
@@ -32,9 +32,8 @@ if { [skip_python_tests] } { continue }
# Make the -gdb.py script available to gdb, it is automagically loaded by gdb.
# Care is taken to put it in the same directory as the binary so that
# gdb will find it.
-set remote_python_file [remote_download host \
- ${srcdir}/${subdir}/${testfile}-gdb.py.in \
- [standard_output_file ${testfile}-gdb.py]]
+set remote_python_file [gdb_remote_download host \
+ ${srcdir}/${subdir}/${testfile}-gdb.py]
gdb_reinitialize_dir $srcdir/$subdir
gdb_test_no_output "set auto-load safe-path ${remote_python_file}" "set auto-load safe-path"
--
1.9.3
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] Don't remove files copied to host
2014-09-17 11:33 Source files are deleted in in-tree build/test Yao Qi
2014-09-29 4:06 ` Doug Evans
@ 2014-09-29 14:01 ` Yao Qi
2014-09-29 14:01 ` [PATCH 2/2] Rename py-objfile-script-gdb.py.in to py-objfile-script-gdb.py Yao Qi
2014-10-20 5:45 ` [PATCH 1/2] Don't remove files copied to host Yao Qi
1 sibling, 2 replies; 5+ messages in thread
From: Yao Qi @ 2014-09-29 14:01 UTC (permalink / raw)
To: gdb-patches
Nowadays, if we do in-tree build and run tests sequentially, some source
files are removed, due to the following pattern:
set pi_txt [gdb_remote_download host ${srcdir}/${subdir}/pi.txt]
remote_exec host "rm -f $pi_txt"
If testing is run sequentially, file ${srcdir}/${subdir}/pi.txt is
copied to ${objdir}/${subdir}/pi.txt. However, ${objdir} is ${srcdir}
in the in-tree build/test, so the file is coped to itself, as a nop.
As a result, the file in source is removed at the end of test.
This patch fixes this problem by not removing files copied to host in
each test. This patch also addresses the question we've had that why
don't we keep files copied to host because they are needed to reproduce
certain fails.
gdb/testsuite:
2014-09-29 Yao Qi <yao@codesourcery.com>
* gdb.base/checkpoint.exp: Don't remove file copied on host.
* gdb.base/step-line.exp: Likewise.
* gdb.dwarf2/dw2-anonymous-func.exp: Likewise.
* gdb.dwarf2/dw2-basic.exp: Likewise.
* gdb.dwarf2/dw2-compressed.exp: Likewise.
* gdb.dwarf2/dw2-filename.exp: Likewise.
* gdb.dwarf2/dw2-intercu.exp: Likewise.
* gdb.dwarf2/dw2-intermix.exp: Likewise.
* gdb.dwarf2/dw2-producer.exp: Likewise.
* gdb.dwarf2/mac-fileno.exp: Likewise.
* gdb.python/py-frame-args.exp: Likewise.
* gdb.python/py-framefilter.exp: Likewise.
* gdb.python/py-mi.exp: Likewise.
* gdb.python/py-objfile-script.exp: Likewise
* gdb.python/py-pp-integral.exp: Likewise.
* gdb.python/py-pp-re-notag.exp: Likewise.
* gdb.python/py-prettyprint.exp: Likewise.
* gdb.python/py-section-script.exp: Likewise.
* gdb.python/py-typeprint.exp: Likewise.
* gdb.python/py-xmethods.exp: Likewise.
* gdb.stabs/weird.exp: Likewise.
* gdb.xml/tdesc-regs.exp: Likewise.
---
gdb/testsuite/gdb.base/checkpoint.exp | 2 --
gdb/testsuite/gdb.base/step-line.exp | 2 --
gdb/testsuite/gdb.dwarf2/dw2-anonymous-func.exp | 5 +----
gdb/testsuite/gdb.dwarf2/dw2-basic.exp | 5 +----
gdb/testsuite/gdb.dwarf2/dw2-compressed.exp | 5 +----
gdb/testsuite/gdb.dwarf2/dw2-filename.exp | 5 +----
gdb/testsuite/gdb.dwarf2/dw2-intercu.exp | 2 --
gdb/testsuite/gdb.dwarf2/dw2-intermix.exp | 6 ++----
gdb/testsuite/gdb.dwarf2/dw2-producer.exp | 5 +----
gdb/testsuite/gdb.dwarf2/mac-fileno.exp | 5 +----
gdb/testsuite/gdb.python/py-frame-args.exp | 2 --
gdb/testsuite/gdb.python/py-framefilter.exp | 2 --
gdb/testsuite/gdb.python/py-mi.exp | 2 --
gdb/testsuite/gdb.python/py-objfile-script.exp | 2 --
gdb/testsuite/gdb.python/py-pp-integral.exp | 2 --
gdb/testsuite/gdb.python/py-pp-re-notag.exp | 2 --
gdb/testsuite/gdb.python/py-prettyprint.exp | 4 ----
gdb/testsuite/gdb.python/py-section-script.exp | 2 --
gdb/testsuite/gdb.python/py-typeprint.exp | 2 --
gdb/testsuite/gdb.python/py-xmethods.exp | 2 --
gdb/testsuite/gdb.stabs/weird.exp | 2 --
gdb/testsuite/gdb.xml/tdesc-regs.exp | 4 ----
22 files changed, 8 insertions(+), 62 deletions(-)
diff --git a/gdb/testsuite/gdb.base/checkpoint.exp b/gdb/testsuite/gdb.base/checkpoint.exp
index b5ed1d3..2de2439 100644
--- a/gdb/testsuite/gdb.base/checkpoint.exp
+++ b/gdb/testsuite/gdb.base/checkpoint.exp
@@ -371,5 +371,3 @@ verbose "Timeout now $timeout sec."
#
# Finished: cleanup
#
-
-remote_exec host "rm -f $pi_txt"
diff --git a/gdb/testsuite/gdb.base/step-line.exp b/gdb/testsuite/gdb.base/step-line.exp
index 94799f8..7f51565 100644
--- a/gdb/testsuite/gdb.base/step-line.exp
+++ b/gdb/testsuite/gdb.base/step-line.exp
@@ -82,6 +82,4 @@ gdb_test "next" \
".*RETURN \\(j\\);.*" \
"next over dummy 10"
-remote_file host delete ${remote_linefile}
-
return 0
diff --git a/gdb/testsuite/gdb.dwarf2/dw2-anonymous-func.exp b/gdb/testsuite/gdb.dwarf2/dw2-anonymous-func.exp
index 029104b..817c988 100644
--- a/gdb/testsuite/gdb.dwarf2/dw2-anonymous-func.exp
+++ b/gdb/testsuite/gdb.dwarf2/dw2-anonymous-func.exp
@@ -29,11 +29,8 @@ if {[prepare_for_testing_full $testfile.exp \
return -1
}
-set remote_dwarf_srcfile [gdb_remote_download host \
- ${srcdir}/${subdir}/${dwarf_srcfile}]
+gdb_remote_download host ${srcdir}/${subdir}/${dwarf_srcfile}
# Force the debugger to create the file1.txt symtab, to make sure that
# the debugger does not crash doing so.
gdb_test "list file1.txt:1" "File 1 Line 1.*File 1 Line 8" "list file1.txt"
-
-remote_file host delete ${remote_dwarf_srcfile}
diff --git a/gdb/testsuite/gdb.dwarf2/dw2-basic.exp b/gdb/testsuite/gdb.dwarf2/dw2-basic.exp
index 7823eaa..c5d5b0a 100644
--- a/gdb/testsuite/gdb.dwarf2/dw2-basic.exp
+++ b/gdb/testsuite/gdb.dwarf2/dw2-basic.exp
@@ -29,11 +29,8 @@ if {[prepare_for_testing_full $testfile.exp \
return -1
}
-set remote_dwarf_srcfile [gdb_remote_download host \
- ${srcdir}/${subdir}/${dwarf_srcfile}]
+gdb_remote_download host ${srcdir}/${subdir}/${dwarf_srcfile}
gdb_test_no_output "set listsize 1"
gdb_test "list func_cu1" "4\[ \t\]+File 1 Line 4"
gdb_test "ptype func_cu1" "type = int \\(\\)"
-
-remote_file host delete ${remote_dwarf_srcfile}
diff --git a/gdb/testsuite/gdb.dwarf2/dw2-compressed.exp b/gdb/testsuite/gdb.dwarf2/dw2-compressed.exp
index 76009d2..7a783b7 100644
--- a/gdb/testsuite/gdb.dwarf2/dw2-compressed.exp
+++ b/gdb/testsuite/gdb.dwarf2/dw2-compressed.exp
@@ -31,11 +31,8 @@ if {[prepare_for_testing_full $testfile.exp \
return -1
}
-set remote_dwarf_srcfile [gdb_remote_download host \
- ${srcdir}/${subdir}/${dwarf_srcfile}]
+gdb_remote_download host ${srcdir}/${subdir}/${dwarf_srcfile}
gdb_test_no_output "set listsize 1"
gdb_test "list func_cu1" "4\[ \t\]+File 1 Line 4"
gdb_test "ptype func_cu1" "type = int \\(\\)"
-
-remote_file host delete ${remote_dwarf_srcfile}
diff --git a/gdb/testsuite/gdb.dwarf2/dw2-filename.exp b/gdb/testsuite/gdb.dwarf2/dw2-filename.exp
index c9ead979..95b4aeb 100644
--- a/gdb/testsuite/gdb.dwarf2/dw2-filename.exp
+++ b/gdb/testsuite/gdb.dwarf2/dw2-filename.exp
@@ -28,8 +28,7 @@ if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" object {nodebug
return -1
}
-set remote_dwarf_srcfile [gdb_remote_download host \
- ${srcdir}/${subdir}/${dwarf_srcfile}]
+gdb_remote_download host ${srcdir}/${subdir}/${dwarf_srcfile}
clean_restart ${testfile}
@@ -42,5 +41,3 @@ gdb_test "interpreter-exec mi -file-list-exec-source-files" \
# And `info sources' should return the fullname incl. the directories.
gdb_test "info sources" {[/\\]file1\.txt}
-
-remote_file host delete ${remote_dwarf_srcfile}
diff --git a/gdb/testsuite/gdb.dwarf2/dw2-intercu.exp b/gdb/testsuite/gdb.dwarf2/dw2-intercu.exp
index 4a23c96..ce1c15f 100644
--- a/gdb/testsuite/gdb.dwarf2/dw2-intercu.exp
+++ b/gdb/testsuite/gdb.dwarf2/dw2-intercu.exp
@@ -42,5 +42,3 @@ gdb_test_no_output "set listsize 1"
gdb_test "list func_cu1" "4\[ \t\]+File 1 Line 4"
gdb_test "ptype func_cu1" "type = int2 \\(\\)"
-
-remote_file host delete ${remote_dwarf_srcfile}
diff --git a/gdb/testsuite/gdb.dwarf2/dw2-intermix.exp b/gdb/testsuite/gdb.dwarf2/dw2-intermix.exp
index 2f95572..1d5d237 100644
--- a/gdb/testsuite/gdb.dwarf2/dw2-intermix.exp
+++ b/gdb/testsuite/gdb.dwarf2/dw2-intermix.exp
@@ -29,11 +29,9 @@ if {[prepare_for_testing_full $testfile.exp \
return -1
}
-set remote_dwarf_srcfile [gdb_remote_download host \
- ${srcdir}/${subdir}/${dwarf_srcfile}]
+gdb_remote_download host \
+ ${srcdir}/${subdir}/${dwarf_srcfile}
gdb_test_no_output "set listsize 1"
gdb_test "list func_cu1" "4\[ \t\]+File 1 Line 4"
gdb_test "ptype func_cu1" "type = int \\(\\)"
-
-remote_file host delete ${remote_dwarf_srcfile}
diff --git a/gdb/testsuite/gdb.dwarf2/dw2-producer.exp b/gdb/testsuite/gdb.dwarf2/dw2-producer.exp
index 6846b17..6d786fe 100644
--- a/gdb/testsuite/gdb.dwarf2/dw2-producer.exp
+++ b/gdb/testsuite/gdb.dwarf2/dw2-producer.exp
@@ -27,11 +27,8 @@ if {[prepare_for_testing_full $testfile.exp \
return -1
}
-set remote_dwarf_srcfile [gdb_remote_download host \
- ${srcdir}/${subdir}/${dwarf_srcfile}]
+gdb_remote_download host ${srcdir}/${subdir}/${dwarf_srcfile}
gdb_test_no_output "set listsize 1"
gdb_test "list func_cu1" "4\[ \t\]+File 1 Line 4"
gdb_test "ptype func_cu1" "type = int \\(\\)"
-
-remote_file host delete ${remote_dwarf_srcfile}
diff --git a/gdb/testsuite/gdb.dwarf2/mac-fileno.exp b/gdb/testsuite/gdb.dwarf2/mac-fileno.exp
index e736211..7711cb3 100644
--- a/gdb/testsuite/gdb.dwarf2/mac-fileno.exp
+++ b/gdb/testsuite/gdb.dwarf2/mac-fileno.exp
@@ -30,11 +30,8 @@ if {[prepare_for_testing_full $testfile.exp \
return -1
}
-set remote_dwarf_srcfile [gdb_remote_download host \
- ${srcdir}/${subdir}/${dwarf_srcfile}]
+gdb_remote_download host ${srcdir}/${subdir}/${dwarf_srcfile}
gdb_test_no_output "set listsize 1"
gdb_test "list func_cu1" "4\[ \t\]+File 1 Line 4"
gdb_test "ptype func_cu1" "type = int \\(\\)"
-
-remote_file host delete ${remote_dwarf_srcfile}
diff --git a/gdb/testsuite/gdb.python/py-frame-args.exp b/gdb/testsuite/gdb.python/py-frame-args.exp
index 4c50be8..de4d159 100644
--- a/gdb/testsuite/gdb.python/py-frame-args.exp
+++ b/gdb/testsuite/gdb.python/py-frame-args.exp
@@ -68,5 +68,3 @@ gdb_test_no_output "set print frame-arguments all"
gdb_test "frame" \
".*foo \\(x=42, ss={a = {m = 1}, b = {m = 2}}\\).*" \
"frame raw,all"
-
-remote_file host delete ${remote_python_file}
diff --git a/gdb/testsuite/gdb.python/py-framefilter.exp b/gdb/testsuite/gdb.python/py-framefilter.exp
index 948ae94..5d14115 100644
--- a/gdb/testsuite/gdb.python/py-framefilter.exp
+++ b/gdb/testsuite/gdb.python/py-framefilter.exp
@@ -188,8 +188,6 @@ gdb_test_multiple "bt 1" $test {
}
}
-remote_file host delete ${remote_python_file}
-
# Test with no debuginfo
# We cannot use prepare_for_testing as we have to set the safe-patch
diff --git a/gdb/testsuite/gdb.python/py-mi.exp b/gdb/testsuite/gdb.python/py-mi.exp
index 5959175..ca02bf7 100644
--- a/gdb/testsuite/gdb.python/py-mi.exp
+++ b/gdb/testsuite/gdb.python/py-mi.exp
@@ -356,5 +356,3 @@ mi_list_varobj_children fake.private {
mi_gdb_test "-var-set-visualizer fake.private gdb.default_visualizer" \
"\\^done" "Install visualizer on a cplus_fake_child"
-
-remote_file host delete ${remote_python_file}
diff --git a/gdb/testsuite/gdb.python/py-objfile-script.exp b/gdb/testsuite/gdb.python/py-objfile-script.exp
index 55f505f..298bc3e 100644
--- a/gdb/testsuite/gdb.python/py-objfile-script.exp
+++ b/gdb/testsuite/gdb.python/py-objfile-script.exp
@@ -53,5 +53,3 @@ gdb_test "b [gdb_get_line_number {break to inspect} ${testfile}.c ]" \
gdb_test "continue" ".*Breakpoint.*"
gdb_test "print ss" " = a=<1> b=<2>"
-
-remote_file host delete ${remote_python_file}
diff --git a/gdb/testsuite/gdb.python/py-pp-integral.exp b/gdb/testsuite/gdb.python/py-pp-integral.exp
index 8149bde..ac4403d 100644
--- a/gdb/testsuite/gdb.python/py-pp-integral.exp
+++ b/gdb/testsuite/gdb.python/py-pp-integral.exp
@@ -35,5 +35,3 @@ gdb_test_no_output "source ${remote_python_file}" \
gdb_test "print *t" " = Thu Nov 14 02:22:23 2013 \\(1384395743\\)"
gdb_test "print /r *t" "= 1384395743"
-
-remote_file host delete ${remote_python_file}
diff --git a/gdb/testsuite/gdb.python/py-pp-re-notag.exp b/gdb/testsuite/gdb.python/py-pp-re-notag.exp
index 8149bde..ac4403d 100644
--- a/gdb/testsuite/gdb.python/py-pp-re-notag.exp
+++ b/gdb/testsuite/gdb.python/py-pp-re-notag.exp
@@ -35,5 +35,3 @@ gdb_test_no_output "source ${remote_python_file}" \
gdb_test "print *t" " = Thu Nov 14 02:22:23 2013 \\(1384395743\\)"
gdb_test "print /r *t" "= 1384395743"
-
-remote_file host delete ${remote_python_file}
diff --git a/gdb/testsuite/gdb.python/py-prettyprint.exp b/gdb/testsuite/gdb.python/py-prettyprint.exp
index 1096389..ae866f0 100644
--- a/gdb/testsuite/gdb.python/py-prettyprint.exp
+++ b/gdb/testsuite/gdb.python/py-prettyprint.exp
@@ -108,8 +108,6 @@ proc run_lang_tests {exefile lang} {
"print nstype on one line"
gdb_continue_to_end
-
- remote_file host delete ${remote_python_file}
}
run_lang_tests "${binfile}" "c"
@@ -155,5 +153,3 @@ gdb_test_no_output "python enable_lookup_function ()"
gdb_test "print ss" " = a=< a=<1> b=<$hex>> b=< a=<2> b=<$hex>>" \
"print ss enabled #2"
-
-remote_file host delete ${remote_python_file}
diff --git a/gdb/testsuite/gdb.python/py-section-script.exp b/gdb/testsuite/gdb.python/py-section-script.exp
index 4f465cc..5c868d7 100644
--- a/gdb/testsuite/gdb.python/py-section-script.exp
+++ b/gdb/testsuite/gdb.python/py-section-script.exp
@@ -72,5 +72,3 @@ gdb_test "b [gdb_get_line_number {break to inspect} ${testfile}.c ]" \
gdb_test "continue" ".*Breakpoint.*"
gdb_test "print ss" " = a=<1> b=<2>"
-
-remote_file host delete ${remote_python_file}
diff --git a/gdb/testsuite/gdb.python/py-typeprint.exp b/gdb/testsuite/gdb.python/py-typeprint.exp
index 1de80bd..ee02091 100644
--- a/gdb/testsuite/gdb.python/py-typeprint.exp
+++ b/gdb/testsuite/gdb.python/py-typeprint.exp
@@ -51,5 +51,3 @@ gdb_test_no_output "enable type-printer string"
gdb_test "whatis bs" "string" "whatis with enabled printer"
gdb_test "whatis s" "templ<string>"
-
-remote_file host delete ${remote_python_file}
diff --git a/gdb/testsuite/gdb.python/py-xmethods.exp b/gdb/testsuite/gdb.python/py-xmethods.exp
index 8824127..093b4bc 100644
--- a/gdb/testsuite/gdb.python/py-xmethods.exp
+++ b/gdb/testsuite/gdb.python/py-xmethods.exp
@@ -149,5 +149,3 @@ gdb_test_no_output "disable xmethod progspace E_methods;method_int" \
"disable xmethod progspace E_methods;method_int"
gdb_test "info xmethod progspace E_methods;method_int" ".* \\\[disabled\\\]" \
"info xmethod xmethods E_methods;method_int"
-
-remote_file host delete ${xmethods_script}
diff --git a/gdb/testsuite/gdb.stabs/weird.exp b/gdb/testsuite/gdb.stabs/weird.exp
index 5746770..b5efc68 100644
--- a/gdb/testsuite/gdb.stabs/weird.exp
+++ b/gdb/testsuite/gdb.stabs/weird.exp
@@ -325,6 +325,4 @@ gdb_expect 60 {
do_tests
-remote_file host delete ${binfile}
-
return 0
diff --git a/gdb/testsuite/gdb.xml/tdesc-regs.exp b/gdb/testsuite/gdb.xml/tdesc-regs.exp
index 0e4547c..b0b5c7d 100644
--- a/gdb/testsuite/gdb.xml/tdesc-regs.exp
+++ b/gdb/testsuite/gdb.xml/tdesc-regs.exp
@@ -167,7 +167,3 @@ gdb_test "ptype \$bitfields" \
load_description "core-only.xml" ""
# The extra register from the previous description should be gone.
gdb_test "ptype \$extrareg" "type = void"
-
-foreach src ${core-regs} {
- remote_file host delete $remote_filename($src)
-}
--
1.9.3
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] Don't remove files copied to host
2014-09-29 14:01 ` [PATCH 1/2] Don't remove files copied to host Yao Qi
2014-09-29 14:01 ` [PATCH 2/2] Rename py-objfile-script-gdb.py.in to py-objfile-script-gdb.py Yao Qi
@ 2014-10-20 5:45 ` Yao Qi
1 sibling, 0 replies; 5+ messages in thread
From: Yao Qi @ 2014-10-20 5:45 UTC (permalink / raw)
To: gdb-patches
Yao Qi <yao@codesourcery.com> writes:
> gdb/testsuite:
>
> 2014-09-29 Yao Qi <yao@codesourcery.com>
>
> * gdb.base/checkpoint.exp: Don't remove file copied on host.
> * gdb.base/step-line.exp: Likewise.
> * gdb.dwarf2/dw2-anonymous-func.exp: Likewise.
> * gdb.dwarf2/dw2-basic.exp: Likewise.
> * gdb.dwarf2/dw2-compressed.exp: Likewise.
> * gdb.dwarf2/dw2-filename.exp: Likewise.
> * gdb.dwarf2/dw2-intercu.exp: Likewise.
> * gdb.dwarf2/dw2-intermix.exp: Likewise.
> * gdb.dwarf2/dw2-producer.exp: Likewise.
> * gdb.dwarf2/mac-fileno.exp: Likewise.
> * gdb.python/py-frame-args.exp: Likewise.
> * gdb.python/py-framefilter.exp: Likewise.
> * gdb.python/py-mi.exp: Likewise.
> * gdb.python/py-objfile-script.exp: Likewise
> * gdb.python/py-pp-integral.exp: Likewise.
> * gdb.python/py-pp-re-notag.exp: Likewise.
> * gdb.python/py-prettyprint.exp: Likewise.
> * gdb.python/py-section-script.exp: Likewise.
> * gdb.python/py-typeprint.exp: Likewise.
> * gdb.python/py-xmethods.exp: Likewise.
> * gdb.stabs/weird.exp: Likewise.
> * gdb.xml/tdesc-regs.exp: Likewise.
These two patches are pushed in.
--
Yao (齐尧)
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-10-20 5:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-17 11:33 Source files are deleted in in-tree build/test Yao Qi
2014-09-29 4:06 ` Doug Evans
2014-09-29 14:01 ` [PATCH 1/2] Don't remove files copied to host Yao Qi
2014-09-29 14:01 ` [PATCH 2/2] Rename py-objfile-script-gdb.py.in to py-objfile-script-gdb.py Yao Qi
2014-10-20 5:45 ` [PATCH 1/2] Don't remove files copied to host Yao Qi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).