public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* Source files are deleted in in-tree build/test
@ 2014-09-17 11:33 Yao Qi
  2014-09-29  4:06 ` Doug Evans
  2014-09-29 14:01 ` [PATCH 1/2] Don't remove files copied to host Yao Qi
  0 siblings, 2 replies; 5+ messages in thread
From: Yao Qi @ 2014-09-17 11:33 UTC (permalink / raw)
  To: gdb-patches


Hi,
If we do in-tree build and run tests sequentially,

$ make check RUNTESTFLAGS='--directory=gdb.dwarf'
$ make check RUNTESTFLAGS='--directory=gdb.python'

we can see some source files are deleted after tests,

#       deleted:    gdb.dwarf2/file1.txt
#       deleted:    gdb.python/py-frame-args.py
#       deleted:    gdb.python/py-framefilter.py
#       deleted:    gdb.python/py-pp-integral.py
#       deleted:    gdb.python/py-pp-re-notag.py
#       deleted:    gdb.python/py-prettyprint.py
#       deleted:    gdb.python/py-section-script.py
#       deleted:    gdb.python/py-typeprint.py
#       deleted:    gdb.python/py-xmethods.py

These tests have this the pattern like this:

set remote_python_file [gdb_remote_download host \
			    ${srcdir}/${subdir}/${testfile}.py]

remote_file host delete ${remote_python_file}

In the in-tree build/test, remote_python_file is the source, so the
"remote_file host delete ${remote_python_file}" will delete the source
file, and cause the some fails in the tests after that.

Matt Rice fixed the problem in py-objfile-script.exp
<https://sourceware.org/ml/gdb-patches/2011-07/msg00225.html> by
renaming .py to .py.in and copy .py.in file to .py on running test.
However, it is not friendly to remote host testing w.r.t copying files
to remote host.  Alternatively, we don't have to remote these files
copied to host.  We discussed this there
<https://sourceware.org/ml/gdb-patches/2014-08/msg00269.html> without
any conclusions.  Now, I am inclined to not removing files on host, as
justified by this problem.  What do you think?

-- 
Yao (齐尧)

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-10-20  5:45 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-17 11:33 Source files are deleted in in-tree build/test Yao Qi
2014-09-29  4:06 ` Doug Evans
2014-09-29 14:01 ` [PATCH 1/2] Don't remove files copied to host Yao Qi
2014-09-29 14:01   ` [PATCH 2/2] Rename py-objfile-script-gdb.py.in to py-objfile-script-gdb.py Yao Qi
2014-10-20  5:45   ` [PATCH 1/2] Don't remove files copied to host Yao Qi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).