From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25727 invoked by alias); 8 Jan 2015 23:19:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25709 invoked by uid 89); 8 Jan 2015 23:19:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mail-oi0-f41.google.com Received: from mail-oi0-f41.google.com (HELO mail-oi0-f41.google.com) (209.85.218.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 08 Jan 2015 23:19:00 +0000 Received: by mail-oi0-f41.google.com with SMTP id i138so9706464oig.0 for ; Thu, 08 Jan 2015 15:18:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=13QbPcirZyinnRF3MHygewxGlq4UlI9MlpayEXXVP4A=; b=WZ8G6xqYlQpFL48ptxLm9/qWsmixsPvzSS98KFMuX/MNHOwz7bN7/YH4aU2+wXf1br rOrUHoSHnD3I+8WDheLwjgS574379s5fGbXf7cI+UaScB52r/jPa0U1NPSTdLMpjlizI Gursby2W/9HKMK0wHezNTBWtFnKMM4wqHsgcs+ZBiekfHnp2qoUzwMTCUnJwdivOrgS3 /SQH5Mkmf1JqMVPKjz54tqiAzQEVjIB30sMLk7quVcaMeWfT9m6xUYRqBBTwYO9uso5F 9Gb0dS0nUD5jeRWbrJJNYSXYy7TWugTJmXJfh/rpNPg74RTU4NbQB4SdBmrrpeCKKQCm T6mQ== X-Gm-Message-State: ALoCoQltXjXxmdX3eKiHBcVwDE1HQk7uPrn1bxvW40Nbi/ASSJXchDGJ4y+yvE6Px0OWk50OVpfR MIME-Version: 1.0 X-Received: by 10.202.59.136 with SMTP id i130mr6880505oia.114.1420759138076; Thu, 08 Jan 2015 15:18:58 -0800 (PST) Received: by 10.182.222.98 with HTTP; Thu, 8 Jan 2015 15:18:57 -0800 (PST) In-Reply-To: <54ae3a34.43a0420a.2c3b.fffffc79SMTPIN_ADDED_BROKEN@mx.google.com> References: <54adbf52.69ce440a.7015.fffff8dcSMTPIN_ADDED_BROKEN@mx.google.com> <54ae3a34.43a0420a.2c3b.fffffc79SMTPIN_ADDED_BROKEN@mx.google.com> Date: Thu, 08 Jan 2015 23:19:00 -0000 Message-ID: Subject: Re: [RFA] Fix for PR 17811 From: Doug Evans To: Pierre Muller Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg00203.txt.bz2 On Thu, Jan 8, 2015 at 12:04 AM, Pierre Muller wrote: > Hi Doug, > >> -----Message d'origine----- >> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches- >> owner@sourceware.org] De la part de Doug Evans >> Envoy=C3=A9 : jeudi 8 janvier 2015 01:46 >> =C3=80 : Pierre Muller >> Cc : gdb-patches >> Objet : Re: [RFA] Fix for PR 17811 >> >> On Wed, Jan 7, 2015 at 3:20 PM, Pierre Muller >> wrote: >> > The special handling of C++ special symbol >> > generates symbols that have no language. >> > Those symbols cannot be displayed correctly in the backtrace stack. >> > >> > See >> > https://sourceware.org/bugzilla/show_bug.cgi?id=3D17811 >> > for details and examples in C++ and pascal language. >> > >> > The patch below fixes this issue, by >> > setting language of new symbol before >> > special handling of special C++ symbols. >> > >> > >> > Pierre Muller >> > >> > >> > 2015-01-07 Pierre Muller >> > >> > Fix for PR 17811. >> > * stabsread.c (define_symbol): Set language for C++ special >> symbols. >> >> Hi. >> LGTM with two nits: >> >> 1) A blank line after the SYMBOL_SET_LANGUAGE call would >> block the code better to this reader. >> 2) I believe convention is to remove the "Fix for" in the changelog >> entry. > > Thanks, > for the record, below is what I committed. > I hope it takes your nits correctly into account. Yep, thanks!