From: Doug Evans <dje@google.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches <gdb-patches@sourceware.org>,
Cary Coutant <ccoutant@google.com>
Subject: Re: [PATCH] [PR symtab/17890] punt if dwarf line header version > 4
Date: Thu, 29 Jan 2015 19:29:00 -0000 [thread overview]
Message-ID: <CADPb22R2c8Dst+YsAbzKotHoJSuEo3Onr2qt_3SpSP6jmvGkcQ@mail.gmail.com> (raw)
In-Reply-To: <20150129044312.GA5193@adacore.com>
On Wed, Jan 28, 2015 at 8:43 PM, Joel Brobecker <brobecker@adacore.com> wrote:
>> I opted to be conservative and not break something if a user
>> just happened to be using a broken toolchain that emits
>> version 0 or 1 but is still usable by gdb.
>> I'm more than happy to be more strict though!
>
> FWIW, I think it's a valid concern. We can always revisit later
> if we happen to see something that requires us to be stricter.
>
>> 2015-01-28 Doug Evans <dje@google.com>
>>
>> PR symtab/17890
>> * dwarf2read.c (dwarf_decode_line_header): Punt if version > 4.
>
> LGTM.
Thanks, committed to trunk and gdb-7.9-branch.
prev parent reply other threads:[~2015-01-29 18:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 4:49 Doug Evans
2015-01-29 6:15 ` Joel Brobecker
2015-01-29 19:29 ` Doug Evans [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADPb22R2c8Dst+YsAbzKotHoJSuEo3Onr2qt_3SpSP6jmvGkcQ@mail.gmail.com \
--to=dje@google.com \
--cc=brobecker@adacore.com \
--cc=ccoutant@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).