From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17919 invoked by alias); 29 Jan 2015 18:35:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17866 invoked by uid 89); 29 Jan 2015 18:35:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-oi0-f44.google.com Received: from mail-oi0-f44.google.com (HELO mail-oi0-f44.google.com) (209.85.218.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 29 Jan 2015 18:35:32 +0000 Received: by mail-oi0-f44.google.com with SMTP id a3so29597805oib.3 for ; Thu, 29 Jan 2015 10:35:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=lW3/GieKnhlCovANn3MF/1DtFwpCupko5dOnFU0WTe8=; b=Azbs0lBeAvv/b1v5bQCbGVGdtWkApLJEZ3HeAH3gTErqwuHFJZgEecN3H6mQ9+a4W8 dWi5del/HvlQyz3fE4Y4R0TuqxZPZjCFUPCW1F6ZtlIAAyZZv8QeV7J2NE2A+FVwrz/E 0QXvBNp+D/uWNfL4eV5qmY6Bc1+7W+ar1LHFbD3k9Z0Cgbp23L7c+p7MTaf+Fj3/QIbw yXFXCaLuJQYtafAYhYP5opeGDRkiW9wJdhBr8YXB/ga9TgULdfBrKJm535UOeNpU3hvu dVShMdxeFKUTuz7B1P2wibOloYgtnItlr3NYjrlws96+1Q9CeHVChJV7Kvr/s0yTx46L FQRw== X-Gm-Message-State: ALoCoQnVg8Ymns7LV8yz9oJUV+SHmJIsvReo7SbjF5HVn8B3UouAt+l/StxfAxKyeZOKAvhCpSd+ MIME-Version: 1.0 X-Received: by 10.182.214.1 with SMTP id nw1mr1305652obc.21.1422556530430; Thu, 29 Jan 2015 10:35:30 -0800 (PST) Received: by 10.182.222.98 with HTTP; Thu, 29 Jan 2015 10:35:30 -0800 (PST) In-Reply-To: <20150129044312.GA5193@adacore.com> References: <20150129044312.GA5193@adacore.com> Date: Thu, 29 Jan 2015 19:29:00 -0000 Message-ID: Subject: Re: [PATCH] [PR symtab/17890] punt if dwarf line header version > 4 From: Doug Evans To: Joel Brobecker Cc: gdb-patches , Cary Coutant Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg00782.txt.bz2 On Wed, Jan 28, 2015 at 8:43 PM, Joel Brobecker wrote: >> I opted to be conservative and not break something if a user >> just happened to be using a broken toolchain that emits >> version 0 or 1 but is still usable by gdb. >> I'm more than happy to be more strict though! > > FWIW, I think it's a valid concern. We can always revisit later > if we happen to see something that requires us to be stricter. > >> 2015-01-28 Doug Evans >> >> PR symtab/17890 >> * dwarf2read.c (dwarf_decode_line_header): Punt if version > 4. > > LGTM. Thanks, committed to trunk and gdb-7.9-branch.