Re: [PATCH, docs RFA] Delete all use_stub support: gdb_step_for_stub, and calls to set_debug_traps etc. throughout (was: Re: [commit] add some comments to testsuite/lib/gdb.exp)

[Doug Evans <dje@google.com>]

On Sun, Dec 4, 2011 at 5:15 AM, Pedro Alves <pedro@codesourcery.com> wrote:
> On Saturday 03 December 2011 18:55:06, Doug Evans wrote:
>> On Sat, Dec 3, 2011 at 10:39 AM, Pedro Alves <pedro@codesourcery.com> wrote:
>> > But I do wonder whether there is still anyone making use of this.
>> > Can't we just zap all of the #ifdef usestubs bits?
>>
>> I'll leave that to someone else.
>
> Like below.
>
> Tested on x86_64-linux, native and local gdbserver.
>
>> > There are zillions of tests that don't make have usestubs support
>> > in their main.  It must be pretty broken?
>>
>> Like I said, a bit of bitrot ...
>> [The usestubs way was inherently non-scalable and the bitrot will
>> always be inevitable.]
>>
>> > All the stubs I've seen thus far that needed to do something magical,
>> > did it transparently, before main is reached, e.g., with extra startup
>> > glue, and board file magic, which IMO is the Right Way.
>>
>> I think you'd be hard pressed to find someone who thought otherwise
>> these days ... no?
>
> gdb/doc/
> 2011-12-04  Pedro Alves  <pedro@codesourcery.com>
>
>        * gdb.texinfo (Implementing a Remote Stub): Explain that you
>        should transfer control to the stub in the startup code instead of
>        in main.  Mention the need to get past the initial breakpoint.
>
> gdb/testsuite/
> 2011-12-04  Pedro Alves  <pedro@codesourcery.com>
>
>        * lib/gdb.exp (gdb_run_cmd, runto_main, gdb_compile)
>        (clean_restart): Remove references to the gdb_stub target board
>        variable.
>        (gdb_step_for_stub): Delete.
>
>        * gdb.base/annota1.exp: Remove all references to [target_info
>        exists gdb_stub], gdb_step_for_stub and usestubs.
>        * gdb.base/annota3.exp: Ditto.
>        * gdb.base/async.exp: Ditto.
>        * gdb.base/break.exp: Ditto.
>        * gdb.base/code-expr.exp: Ditto.
>        * gdb.base/commands.exp: Ditto.
>        * gdb.base/completion.exp: Ditto.
>        * gdb.base/condbreak.exp: Ditto.
>        * gdb.base/consecutive.exp: Ditto.
>        * gdb.base/cvexpr.exp: Ditto.
>        * gdb.base/define.exp: Ditto.
>        * gdb.base/display.exp: Ditto.
>        * gdb.base/ena-dis-br.exp: Ditto.
>        * gdb.base/environ.exp: Ditto.
>        * gdb.base/gnu-ifunc.exp: Ditto.
>        * gdb.base/maint.exp: Ditto.
>        * gdb.base/pending.exp: Ditto.
>        * gdb.base/sect-cmd.exp: Ditto.
>        * gdb.base/sepdebug.exp: Ditto.
>        * gdb.base/unload.exp: Ditto.
>        * gdb.base/watchpoint-solib.exp: Ditto.
>        * gdb.cp/annota2.exp: Ditto.
>        * gdb.cp/annota3.exp: Ditto.
>        * gdb.dwarf2/dw2-inline-param.exp: Ditto.
>        * gdb.hp/gdb.compat/xdb1.exp: Ditto.
>        * gdb.mi/mi-pending.exp: Ditto.
>        * gdb.trace/circ.exp: Ditto.
>        * gdb.cp/ovldbreak.exp: Ditto.  Adjust expected line numbers.
>        * gdb.base/list.exp: Ditto.
>
>        * gdb.base/all-types.c: Remove all calls to set_debug_traps and
>        breakpoint function and all references to the usestubs macro.
>        * gdb.base/exprs.c: Ditto.
>        * gdb.base/freebpcmd.c: Ditto.
>        * gdb.base/bitfields.c: Ditto.
>        * gdb.base/bitfields2.c: Ditto.
>        * gdb.base/break.c: Ditto.
>        * gdb.base/call-sc.c: Ditto.
>        * gdb.base/call-signals.c: Ditto.
>        * gdb.base/callfuncs.c: Ditto.
>        * gdb.base/charset.c: Ditto.
>        * gdb.base/consecutive.c: Ditto.
>        * gdb.base/constvars.c: Ditto.
>        * gdb.base/funcargs.c: Ditto.
>        * gdb.base/int-type.c: Ditto.
>        * gdb.base/interrupt.c: Ditto.
>        * gdb.base/langs0.c: Ditto.
>        * gdb.base/list0.c: Ditto.
>        * gdb.base/mips_pro.c: Ditto.
>        * gdb.base/miscexprs.c: Ditto.
>        * gdb.base/nodebug.c: Ditto.
>        * gdb.base/opaque0.c: Ditto.
>        * gdb.base/pointers.c: Ditto.
>        * gdb.base/printcmds.c: Ditto.
>        * gdb.base/ptype.c: Ditto.
>        * gdb.base/recurse.c: Ditto.
>        * gdb.base/reread1.c: Ditto.
>        * gdb.base/reread2.c: Ditto.
>        * gdb.base/restore.c: Ditto.
>        * gdb.base/return.c: Ditto.
>        * gdb.base/run.c: Ditto.
>        * gdb.base/scope0.c: Ditto.
>        * gdb.base/sepdebug.c: Ditto.
>        * gdb.base/setshow.c: Ditto.
>        * gdb.base/setvar.c: Ditto.
>        * gdb.base/sigall.c: Ditto.
>        * gdb.base/signals.c: Ditto.
>        * gdb.base/structs.c: Ditto.
>        * gdb.base/structs2.c: Ditto.
>        * gdb.base/testenv.c: Ditto.
>        * gdb.base/twice.c: Ditto.
>        * gdb.base/unwindonsignal.c: Ditto.
>        * gdb.base/watchpoint.c: Ditto.
>        * gdb.base/watchpoints.c: Ditto.
>        * gdb.base/whatis.c: Ditto.
>        * gdb.cp/classes.cc: Ditto.
>        * gdb.cp/cplusfuncs.cc: Ditto.
>        * gdb.cp/derivation.cc: Ditto.
>        * gdb.cp/formatted-ref.cc: Ditto.
>        * gdb.cp/misc.cc: Ditto.
>        * gdb.cp/overload.cc: Ditto.
>        * gdb.cp/ovldbreak.cc: Ditto.
>        * gdb.cp/ref-params.cc: Ditto.
>        * gdb.cp/ref-types.cc: Ditto.
>        * gdb.cp/templates.cc: Ditto.
>        * gdb.cp/virtfunc.cc: Ditto.
>        * gdb.hp/gdb.aCC/run.c: Ditto.
>        * gdb.hp/gdb.base-hp/callfwmall.c: Ditto.
>        * gdb.hp/gdb.compat/xdb0.c: Ditto.
>        * gdb.reverse/consecutive-reverse.c: Ditto.
>        * gdb.reverse/sigall-reverse.c: Ditto.
>        * gdb.reverse/until-reverse.c: Ditto.
>        * gdb.reverse/watch-reverse.c: Ditto.
>        * gdb.trace/actions.c: Ditto.
>        * gdb.trace/circ.c: Ditto.
>        * gdb.trace/collection.c: Ditto.

Right on cue. :-)

I think the right thing to do is include my name in the ChangeLog entry.
ref: http://sourceware.org/ml/gdb-patches/2011-12/msg00090.html

Thanks.