From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59808 invoked by alias); 18 May 2016 16:10:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 59792 invoked by uid 89); 18 May 2016 16:10:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=U*gabriel, gabrielkrismanbe, gabriel@krisman.be, sk:gabriel X-HELO: mail-vk0-f54.google.com Received: from mail-vk0-f54.google.com (HELO mail-vk0-f54.google.com) (209.85.213.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 18 May 2016 16:10:26 +0000 Received: by mail-vk0-f54.google.com with SMTP id s184so67459360vkb.3 for ; Wed, 18 May 2016 09:10:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=iUuCQRMqQ5NvDiT8gC28/jecSidwm0EevtO5FytLgHY=; b=hJ/GkrQqwqln9HTLXUF9USD40x53dSArl8yOnRfcOWpdjvfoAnpsVVLlXdqy2ORWxE 952b0sjwRHhfhcRiQP/V91wGQcEDSxJsNVNKVyHIn+b3d831uU5B/z9RWxERsNZEPzcM YAhgQGeWi6sL70XuM6M43BAD3kfIjvC0KEVkFUmmDC6tk4mG5zaDoej+xUeo19s2W3M7 X9rQu0F0GEsQ9piF1m7/Dxf6XHNbIftVw30S3+nmlXPsjEDDsKwzgaUA0hYlhXCAUkDM ParecSkZkXm+kOMcdpR57x+uBFwBIyEa5gNaRRKANDzf4/sGAyW0JHB0Z+mGH+5wF1FT zLbQ== X-Gm-Message-State: AOPr4FXeUQJ7WfnDNmVl1pyMpajzLs3PKVK80pws5LqBeqjFhNMeIKM+3KO8b3vEFUhk2WCfmgMR+QjnoD7kggHq X-Received: by 10.31.61.134 with SMTP id k128mr4455812vka.89.1463587824011; Wed, 18 May 2016 09:10:24 -0700 (PDT) MIME-Version: 1.0 Received: by 10.31.92.200 with HTTP; Wed, 18 May 2016 09:09:44 -0700 (PDT) In-Reply-To: <87lh38qel4.fsf@oberon.home> References: <94eb2c124024cac63305330c515e@google.com> <87lh38qel4.fsf@oberon.home> From: Doug Evans Date: Wed, 18 May 2016 16:10:00 -0000 Message-ID: Subject: Re: [PATCH v5 1/5] Implemement support for groups of syscalls in the xml-syscall interface. To: Gabriel Krisman Bertazi Cc: gdb-patches , Pedro Alves , Sergio Durigan Junior Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2016-05/txt/msg00306.txt.bz2 On Tue, May 17, 2016 at 7:34 PM, Gabriel Krisman Bertazi wrote: > Doug Evans writes: > > Hi Doug, thanks for your review. I'm fixing the things you pointed out > and should submit a new version tomorrow. > >> > diff --git a/gdb/syscalls/gdb-syscalls.dtd >> b/gdb/syscalls/gdb-syscalls.dtd >> > index 3deda12..de47d4d 100644 >> > --- a/gdb/syscalls/gdb-syscalls.dtd >> > +++ b/gdb/syscalls/gdb-syscalls.dtd >> > @@ -11,4 +11,5 @@ >> > >> > > > name CDATA #REQUIRED >> > - number CDATA #REQUIRED> >> > + number CDATA #REQUIRED >> > + groups CDATA #IMPLIED> >> >> I'm assuming "IMPLIED" is ok here, I don't actually know. > > According to the xml spec, there are two possible 'ID Attribute Default' > values for an element: #REQUIRED and #IMPLIED. The spec says: > > "In an attribute declaration, #REQUIRED means that the attribute MUST > always be provided, #IMPLIED that no default value is provided." > > Which makes me think that #IMPLIED is the correct value for this field. Fine by me. Thanks.