public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches <gdb-patches@sourceware.org>,
	Joel Brobecker <brobecker@adacore.com>
Subject: Re: [RFC] symbol lookup cache
Date: Thu, 04 Dec 2014 19:24:00 -0000	[thread overview]
Message-ID: <CADPb22R=t1AOhb2+YmFfsH2hVphAVHifV1b7kD-jZZD4J_ARHA@mail.gmail.com> (raw)
In-Reply-To: <20141204191559.GA10848@host2.jankratochvil.net>

On Thu, Dec 4, 2014 at 11:15 AM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> On Mon, 01 Dec 2014 09:23:49 +0100, Doug Evans wrote:
>> ..gdb_index helps speed things up for one objfile,
>> but when there are 100s (or 1000s) of shared
>> libraries, symbol lookup can still take awhile,
>> even with .gdb_index.
>> [I'm setting aside a planned change to basic
>> symbol lookup to use the index better.
>> We'll still, I think, want a cache even
>> with that change.]
>
> While I have no numbers personally I do not think GDB would still need a cache
> after that change.
>
> "Accelerate lookup_symbol_aux_objfile 85x" is so fast in a fraction of second
> because it traverses 146426 symtabs.  So 146426 is OK but 1979341 was not (it
> was in some way more than 1979341 before you refactored symtabs).

Just to make sure I understand correctly, the 85x is dwz-specific, right?

  reply	other threads:[~2014-12-04 19:24 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-01  8:23 Doug Evans
2014-12-03  0:50 ` Doug Evans
2014-12-20  7:57   ` [PATCH] " Doug Evans
2014-12-20  8:29     ` Doug Evans
2014-12-20 10:43     ` Eli Zaretskii
2014-12-20 19:14       ` Doug Evans
2014-12-20 19:55         ` Eli Zaretskii
2014-12-20 21:04           ` Doug Evans
2014-12-21  3:34             ` Eli Zaretskii
2014-12-21 18:51               ` Doug Evans
2014-12-21 21:01                 ` Joel Brobecker
2014-12-22  2:04                   ` Doug Evans
2014-12-22 12:48                     ` Joel Brobecker
2015-01-11 19:11                       ` Doug Evans
2014-12-03  2:46 ` [RFC] " Joel Brobecker
2014-12-04 16:38 ` Pedro Alves
2014-12-04 19:17   ` Doug Evans
2014-12-04 19:16 ` Jan Kratochvil
2014-12-04 19:24   ` Doug Evans [this message]
2014-12-04 19:28     ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADPb22R=t1AOhb2+YmFfsH2hVphAVHifV1b7kD-jZZD4J_ARHA@mail.gmail.com' \
    --to=dje@google.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).