From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2493 invoked by alias); 6 Jan 2014 18:14:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2482 invoked by uid 89); 6 Jan 2014 18:14:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vb0-f44.google.com Received: from mail-vb0-f44.google.com (HELO mail-vb0-f44.google.com) (209.85.212.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 06 Jan 2014 18:14:19 +0000 Received: by mail-vb0-f44.google.com with SMTP id x8so9148486vbf.17 for ; Mon, 06 Jan 2014 10:14:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=YRa9z5Uq7Q98i3+6kDVs/F+ZjNX8DyS25xCXujM5dv4=; b=ZgORlwZcPtVPLS7zKdDsuzuPa7XKRJcCflfq08sujy/y0u3gtjFQnvWK2yzqwmviMD iu2bhAF26C27CGen0xgpkw8qxFnFdb6/m2JNIFEdYQl7+Oke0Q2tMbZvCGFzt10/oq8I RaIPXMMY3H5EC9nKoEXyrREzJFfPq9JW31SicCm6N6v9p4qjXOMSFwtXhmnm3HYSBZ8S i1JcUaPnAXBBmuNjSVPKdkmdaEP5+umL6kcZDRE0/mjKyxXPXjR/s3IxHq1ksE1hs1/3 4f1oQmMzhB26+Gb2Q3OH1icSu05nz+CDrGEitM+4l5ckI/1Qh8+zq85063Ubyp9ksk3Q umdg== X-Gm-Message-State: ALoCoQmkXNr+DRdnzSKvFRwB9kQytA654GrCOtCV93JMA/VFxIyOfGHwnvBupoyzUMyyWGm9yyu8zt7L7XxxeI8L2Z6jgsjOkNgNckCVTSjTcbjLQY4WYx7VJgk0fBncZG1CmfwO8JbusDXYgLWUJl6l5vPCT3L91nsLi8xDGL9QPgh/a98KdqAJrhChIaVq7bPGc5w2knCdKetyOSa+gWwKzHBuRLwFog== MIME-Version: 1.0 X-Received: by 10.58.57.166 with SMTP id j6mr3378168veq.67.1389032057308; Mon, 06 Jan 2014 10:14:17 -0800 (PST) Received: by 10.52.248.65 with HTTP; Mon, 6 Jan 2014 10:14:17 -0800 (PST) In-Reply-To: <1389029524-19907-1-git-send-email-tromey@redhat.com> References: <1389029524-19907-1-git-send-email-tromey@redhat.com> Date: Mon, 06 Jan 2014 18:14:00 -0000 Message-ID: Subject: Re: [PATCH 0/3] remove overlapping allocation macros From: Doug Evans To: Tom Tromey Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00078.txt.bz2 On Mon, Jan 6, 2014 at 9:32 AM, Tom Tromey wrote: > Right now, gdb defines some allocation macros in defs.h, specifically > XZALLOC, XMALLOC, and XCALLOC. libiberty also defines similar > allocation macros, and gdb uses both variants. > > I think it's somewhat nicer if gdb uses just a single set of wrapper > macros, and so this patch series replaces all the uses of the gdb > macros with the corresponding macros from libiberty. > > Let me know what you think. > > Tested by rebuilding on x86-64 Fedora 18 and doing a cross build to > mingw. It's possible therefore that there are some buglets remaining. I'm all for the increased simplicity. I just wish libiberty's macro naming didn't suck so badly. [Not necessarily a fault at the time, but it sucks now. :-)] E.g., after this series, "vec" use to have a more specific connotation, (I could at least ignore libiberty's choice), and I hate it when terms with good specific connotations get polluted. There's a material downgrade in the readability of the code when that happens. Fortunately, I guess this will only be a temporary material downgrade, since vec -> stl::vector soon.