From: Doug Evans <dje@google.com>
To: "Abid, Hafiz" <Hafiz_Abid@mentor.com>
Cc: "Pedro Alves <palves@redhat.com> (palves@redhat.com)"
<palves@redhat.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"Mirza, Taimoor" <Taimoor_Mirza@mentor.com>
Subject: Re: [patch] Disassembly improvements
Date: Fri, 11 Oct 2013 21:34:00 -0000 [thread overview]
Message-ID: <CADPb22RShPCFWpZhgfv6-ZDtSA=6PK+qwVaetth4tKM1LJLnjA@mail.gmail.com> (raw)
In-Reply-To: <EB3B29AD43CA924DA27099BC85192376E0705106@EU-MBX-03.mgc.mentorg.com>
On Thu, Oct 10, 2013 at 6:14 AM, Abid, Hafiz <Hafiz_Abid@mentor.com> wrote:
> Hi Pedro,
> I am attaching the patch that was mentioned in the following thread. I resurrected it from our internal repo, did a bit of manual testing and run the regression suite without any problem. It basically reads memory from the target in a buffer in gdb_disassembly and tries to use this buffer in dis_asm_read_memory instead of reading from the target. This saves us on repeated memory read calls. The problem was noted when eclipse was trying to fill its disassembly view.
> https://sourceware.org/ml/gdb-patches/2013-10/msg00221.html
>
> Regards,
> Abid
>
> 2013-10-10 Taimoor Mirza <taimoor_mirza@mentor.com>
>
> * disasm.c (DIS_BUF_SIZE): New define.
> (dis_asm_read_memory): Read from the disassembly buffer instead
> of target memory directly.
> (gdb_disassembly): Fill the disassembly buffer with a chunk of
> the memory to disassemble.
This is a specific fix to a general problem.
Question: How much more of the general problem can we fix without
having a fix baked into the disassembler?
next prev parent reply other threads:[~2013-10-11 21:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-10 13:14 Abid, Hafiz
2013-10-10 13:34 ` Pedro Alves
2013-10-10 13:57 ` Abid, Hafiz
2013-10-10 14:52 ` Pedro Alves
2013-10-10 15:13 ` Pedro Alves
2013-10-11 16:45 ` Abid, Hafiz
2013-10-11 21:12 ` Pedro Alves
2013-10-11 21:34 ` Doug Evans [this message]
2013-10-14 9:37 ` Abid, Hafiz
2013-10-14 14:42 ` Pedro Alves
2013-10-16 1:16 ` Doug Evans
2013-10-16 7:53 ` Yao Qi
2013-10-16 12:08 ` Pedro Alves
2013-10-16 13:23 ` Yao Qi
2013-10-18 10:24 ` Yao Qi
2013-10-18 18:25 ` Pedro Alves
2013-10-19 1:55 ` Yao Qi
2013-10-25 7:56 ` Doug Evans
2013-10-16 12:02 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADPb22RShPCFWpZhgfv6-ZDtSA=6PK+qwVaetth4tKM1LJLnjA@mail.gmail.com' \
--to=dje@google.com \
--cc=Hafiz_Abid@mentor.com \
--cc=Taimoor_Mirza@mentor.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).