From: Doug Evans <dje@google.com>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [RFA] Fix for PR 17811
Date: Thu, 08 Jan 2015 00:45:00 -0000 [thread overview]
Message-ID: <CADPb22RV5eDztkkuMc-x2-JLCGXXRtbVCeeqmQj8WJsTCH_3Xw@mail.gmail.com> (raw)
In-Reply-To: <54adbf52.69ce440a.7015.fffff8dcSMTPIN_ADDED_BROKEN@mx.google.com>
On Wed, Jan 7, 2015 at 3:20 PM, Pierre Muller
<pierre.muller@ics-cnrs.unistra.fr> wrote:
> The special handling of C++ special symbol
> generates symbols that have no language.
> Those symbols cannot be displayed correctly in the backtrace stack.
>
> See
> https://sourceware.org/bugzilla/show_bug.cgi?id=17811
> for details and examples in C++ and pascal language.
>
> The patch below fixes this issue, by
> setting language of new symbol before
> special handling of special C++ symbols.
>
>
> Pierre Muller
>
>
> 2015-01-07 Pierre Muller <muller@sourceware.org>
>
> Fix for PR 17811.
> * stabsread.c (define_symbol): Set language for C++ special symbols.
Hi.
LGTM with two nits:
1) A blank line after the SYMBOL_SET_LANGUAGE call would
block the code better to this reader.
2) I believe convention is to remove the "Fix for" in the changelog entry.
next parent reply other threads:[~2015-01-08 0:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <54adbf52.69ce440a.7015.fffff8dcSMTPIN_ADDED_BROKEN@mx.google.com>
2015-01-08 0:45 ` Doug Evans [this message]
2015-01-08 8:05 ` Pierre Muller
[not found] ` <54ae3a34.43a0420a.2c3b.fffffc79SMTPIN_ADDED_BROKEN@mx.google.com>
2015-01-08 23:19 ` Doug Evans
2015-01-07 23:20 Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADPb22RV5eDztkkuMc-x2-JLCGXXRtbVCeeqmQj8WJsTCH_3Xw@mail.gmail.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).