From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-118817-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 13598 invoked by alias); 8 Jan 2015 00:45:58 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 13581 invoked by uid 89); 8 Jan 2015 00:45:57 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2
X-HELO: mail-oi0-f47.google.com
Received: from mail-oi0-f47.google.com (HELO mail-oi0-f47.google.com) (209.85.218.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 08 Jan 2015 00:45:56 +0000
Received: by mail-oi0-f47.google.com with SMTP id v63so5384547oia.6        for <gdb-patches@sourceware.org>; Wed, 07 Jan 2015 16:45:55 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20130820;        h=x-gm-message-state:mime-version:in-reply-to:references:date         :message-id:subject:from:to:cc:content-type;        bh=BrUAMXreDRdxuu+3p5xFZ2tIYm6GiL0vW79qtmC1awg=;        b=XkdU+yjPc+bKQxVLWiu/6zl3MNjl+FVGIk9gQEF+bhhxj+46K9dA0w5KVYQB3+wTrV         CPleZT32z+n6D6T1HYpC2Wb4qCNNQ1IS0KgMoM+TftvBi5l7MGggS4IUKI5JJOU9dUTJ         bG+9CrCPdySU9o4PJXgCTbUMcLzVNCpJfJUJ7JXh8hjVHJ6VGbTFHgDhgmuI3hhE3jNT         MzqsL1ZzWd7kdJxN4Ey4V4+5CE+ssErfYZ5NXfbK/33+kKmRDE6aLDaTJ0+A+FtUObW0         Ybj+7XW0XDmVOq3vStSE+QRz+9A0b6GHps2wrXYtE5pp9I45lVUqPrtMf8Pe0DNILBsF         3sUg==
X-Gm-Message-State: ALoCoQnEU/I+uLf2WhHpVxbZYsPfYLcZDxIsGXnbCFT2mzLBB6A1t77ClXQ5TJPStdPViUNywci0
MIME-Version: 1.0
X-Received: by 10.60.63.109 with SMTP id f13mr3972300oes.27.1420677955021; Wed, 07 Jan 2015 16:45:55 -0800 (PST)
Received: by 10.182.222.98 with HTTP; Wed, 7 Jan 2015 16:45:54 -0800 (PST)
In-Reply-To: <54adbf52.69ce440a.7015.fffff8dcSMTPIN_ADDED_BROKEN@mx.google.com>
References: <54adbf52.69ce440a.7015.fffff8dcSMTPIN_ADDED_BROKEN@mx.google.com>
Date: Thu, 08 Jan 2015 00:45:00 -0000
Message-ID: <CADPb22RV5eDztkkuMc-x2-JLCGXXRtbVCeeqmQj8WJsTCH_3Xw@mail.gmail.com>
Subject: Re: [RFA] Fix for PR 17811
From: Doug Evans <dje@google.com>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: gdb-patches <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2015-01/txt/msg00151.txt.bz2

On Wed, Jan 7, 2015 at 3:20 PM, Pierre Muller
<pierre.muller@ics-cnrs.unistra.fr> wrote:
> The special handling of C++ special symbol
> generates symbols that have no language.
> Those symbols cannot be displayed correctly in the backtrace stack.
>
> See
> https://sourceware.org/bugzilla/show_bug.cgi?id=17811
> for details and examples in C++ and pascal language.
>
> The patch below fixes this issue, by
> setting language of new symbol before
> special handling of special C++ symbols.
>
>
> Pierre Muller
>
>
> 2015-01-07  Pierre Muller  <muller@sourceware.org>
>
>         Fix for PR 17811.
>         * stabsread.c (define_symbol): Set language for C++ special symbols.

Hi.
LGTM with two nits:

1) A blank line after the SYMBOL_SET_LANGUAGE call would
block the code better to this reader.
2) I believe convention is to remove the "Fix for" in the changelog entry.