From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20438 invoked by alias); 11 Jul 2014 21:33:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20360 invoked by uid 89); 11 Jul 2014 21:33:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f174.google.com Received: from mail-vc0-f174.google.com (HELO mail-vc0-f174.google.com) (209.85.220.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 11 Jul 2014 21:33:45 +0000 Received: by mail-vc0-f174.google.com with SMTP id hy4so3242814vcb.33 for ; Fri, 11 Jul 2014 14:33:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=plv3Lc2RGbtZekAobaHR5n34J3vuvdqOwKFplzWWbpA=; b=QkOAE5FuRa5HLWewfxEQ/TZJnJJg/lltK9koFYbJ6g47ZH6ZvAs5pU6Xe6tQXk5jkB 1KfuRkgpK/mqlx7snJVyWj+gNlZGzr+6T6Y1VN7Y65N8dDGDxlI5ZvpuJiyN7MkcQPyb 3CbyGrLUwUlv5rSGpT/+gY+Vl2senorQGITakaaJMkguq/b1jdPpF/UATSiqu60FBCuY E5QWi9pMfS3hSS+/B/iw7V8EAUwRqgSy/OlffdIuKNzTwr27xLo5gPbRJ+HgPp7FnEe2 aeNKzigG3TOs494ceY5hKUV4vSOe7lmIkcLIMIdIePgkBBFCsayk1gVwgciE6OsmgXbm X5+Q== X-Gm-Message-State: ALoCoQkAzqObB9J8O6PrD545WwEgOKCn0ipKR0nP/ecWQjdW6AVGkwnSSyw/KrhW3LTYSCdOCSGB MIME-Version: 1.0 X-Received: by 10.52.157.41 with SMTP id wj9mr1376595vdb.1.1405114423610; Fri, 11 Jul 2014 14:33:43 -0700 (PDT) Received: by 10.52.28.233 with HTTP; Fri, 11 Jul 2014 14:33:43 -0700 (PDT) In-Reply-To: <20140711212537.GA19551@host2.jankratochvil.net> References: <20140630171333.GA2225@host2.jankratochvil.net> <21437.45024.997531.453750@ruffy.mtv.corp.google.com> <20140711212537.GA19551@host2.jankratochvil.net> Date: Fri, 11 Jul 2014 22:05:00 -0000 Message-ID: Subject: Re: [PATCH] Re: Regression for GDB global --statistics From: Doug Evans To: Jan Kratochvil Cc: Eli Zaretskii , gdb-patches Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00297.txt.bz2 On Fri, Jul 11, 2014 at 2:25 PM, Jan Kratochvil wrote: > On Wed, 09 Jul 2014 23:10:56 +0200, Doug Evans wrote: >> --- a/gdb/testsuite/gdb.base/maint.exp >> +++ b/gdb/testsuite/gdb.base/maint.exp >> @@ -130,10 +130,11 @@ gdb_expect { >> # tests here!! >> gdb_test_no_output "maint check-symtabs" >> >> +# Test per-command stats. >> gdb_test_no_output "maint set per-command on" >> - >> -gdb_test "maint set per-command off" \ >> +gdb_test "pwd" \ >> "Command execution time: \[0-9.\]+ \\(cpu\\), \[0-9.\]+ \\(wall\\)\= [\r\n\]+Space used: $decimal \\(\\+$decimal for this command\\)\[\r\n\]+#sy= mtabs: $decimal \\(\\+$decimal\\), #primary symtabs: $decimal \\(\\+$decima= l\\), #blocks: $decimal \\(\\+$decimal\\)" >> +gdb_test_no_output "maint set per-command off" > > Is it needed to change this behavior? It may break some user scripts wor= king > fine with previous GDB stable releases. Change in behaviour of something related to a maintenance command? Or were you referring to something else? One problem I wish to avoid is not doing anything expensive unnecessarily. And here that translates to not computing the values of statistics from before a command executes (so that one can then print the delta after it completes) if said statistics will not be printed. That then translates to any turning on of a statistics-reporting command (mt set per-command foo) will not take effect until the next command. How will that be a problem? > Besides that the startup statistics regression is not tested here but I c= an > post then a testcase for it. As you wish. Thanks.