From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8023 invoked by alias); 12 Feb 2014 07:50:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8006 invoked by uid 89); 12 Feb 2014 07:50:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vb0-f50.google.com Received: from mail-vb0-f50.google.com (HELO mail-vb0-f50.google.com) (209.85.212.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 12 Feb 2014 07:50:27 +0000 Received: by mail-vb0-f50.google.com with SMTP id w8so6644089vbj.23 for ; Tue, 11 Feb 2014 23:50:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=eANR+trmTx5J3UnfVFVnujdUz57aaw6hOi/BrU9LgxM=; b=UIIBRkGtOKqFDNXqWHTKGBcCwj3nz+suU8guQ/xCirfaCJsj63yxvqA19B1tJjle60 AqJE2bjgY2NUzejKp8OQ7rcB68pQWIog85nVlUVv0unIQFJr0WfBqVqYLIiUxn4Yi97M ACfmqOJoH3PWeUBDbbhQeE+DX1HAPAZC+3dnj2MFO93VvY4tse5osuCeZc2NWRBHbdyq RxJPo3ZB6hKyomaoXfKMWj+kB1aJuqaNUx6E0BJLqMF23J7qkvP65ueigGrfj7RCBolo iFayeOKWesWBU+uBhaRHvWYX2ModhFiVEFmxOmrRp9ryhneqxyJ4hIF62CFcb8AI6cOT /PaQ== X-Gm-Message-State: ALoCoQnM3T5BX+0eBloNdJ6cNVSJ2qJU3kgI6rbbjogTdE7dqr1VEC/eOeHpU4pTNFffF5J9vjyAr7omgjkRsxH+KlqANBQ2mu+tNy+ZCC0yQaIdfv1lYlxcQM6AIQAMEA7xHinHGWgcf11AKHj+khl1QffM5h+pfYG4qHAu07gkeJUZ6okAfOjzUFvxXQJgYecWNoyk8J5Bvc26XPRPW6t5vcFOORmnbA== MIME-Version: 1.0 X-Received: by 10.58.181.230 with SMTP id dz6mr23079vec.35.1392191424554; Tue, 11 Feb 2014 23:50:24 -0800 (PST) Received: by 10.52.51.234 with HTTP; Tue, 11 Feb 2014 23:50:24 -0800 (PST) In-Reply-To: References: <20131226183618.D264CA18A0@sasha2.mtv.corp.google.com> <21204.13416.607204.485255@ruffy.mtv.corp.google.com> Date: Wed, 12 Feb 2014 07:50:00 -0000 Message-ID: Subject: Re: [RFC][PATCH] Allow JIT unwinder provide symbol information From: Doug Evans To: Alexander Smundak Cc: gdb-patches , Pedro Alves Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-02/txt/msg00392.txt.bz2 On Tue, Feb 11, 2014 at 2:25 PM, Doug Evans wrote: > On Tue, Jan 14, 2014 at 4:39 PM, Alexander Smundak wrote: >> I fixed the patch based on your comments, except for the one >> about using LWP for thread identification. >> Waiting for the opinions about the approach used in this RFC patch. >> >>> > +/* Returns LWP ID of the current thread or 0. */ >>> > + >>> > +typedef long (gdb_get_lwp) (void); Another issue that occurs to me is what if the loaded jit shared library on some platform (not necessarily linux) wants to use ptid.tid, even if both ptid.lwp and ptid.tid are available? Does it make sense to provide routines that access each? Pedro, the issue is what handle on a thread to export to the jit-reader-load shared library. Java for linux wants the lwp, and currently the patch will return ptid.tid instead of ptid.lwp if lwp == 0 to shield the shared lib from gdb vs gdbserver thread ptid usage differences, on the assumption that if lwp == 0 then tid is actually lwp. On a separate note, IIRC we still have to decide how to handle version 1 jit-reader-load shared libs.