From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-109633-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 22582 invoked by alias); 22 Jan 2014 04:44:43 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 22573 invoked by uid 89); 22 Jan 2014 04:44:42 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-ie0-f172.google.com
Received: from mail-ie0-f172.google.com (HELO mail-ie0-f172.google.com) (209.85.223.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 22 Jan 2014 04:44:42 +0000
Received: by mail-ie0-f172.google.com with SMTP id e14so11094750iej.3        for <gdb-patches@sourceware.org>; Tue, 21 Jan 2014 20:44:40 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20130820;        h=x-gm-message-state:mime-version:in-reply-to:references:date         :message-id:subject:from:to:cc:content-type;        bh=y3PmQWArGKkaRQ7pdUL4cCDjAyQJkflhxTLhqLjO/08=;        b=QASS21cX0nDxR6TopPcY/xtMBuM8d7nExrRN56BOoB9QybbiEBXy8cwJA9hV8i6NWD         6BHw8To/VaBXqt0NatttuOjJkjQqPcQl6+1oKOF2c/xXNshCFOt8q54t56PNvK8VIolJ         c/iYpwnCAjk5UJxxbMbZgaRLd/Q5IwY7AJL8TPYZwSCZUsTIlYhKT84keAseTh4jSbvj         kiVmgykofHtuk7y0Qmxsu50bmbkiCJyS3Sm4TZU8zwFEAomc1kIv9Hk57T1/K7yKafsB         a4DfqLTDDqNBLfbUrWqTwz5ak1JGOEKqwjS1r83jLw9TA/jQZbgO9UcBU+rwfHyQ3G/x         t3uQ==
X-Gm-Message-State: ALoCoQmFhW2R6geliluBc09RdiquSkBNbWf6XPsYC++0u1KMh1YMPbtGh7VFMTPSyKdZGMLUv1SdZ3jbJ2oNc2U50vwoxUMHth8WJInaehr8cgukjd+n7UN+BAq1T/1akZhid5AhSd8LeiEVtYp/VWdCX5WhAJoNSow3CA442xlzC8tYQ2KmVPB16V7DStZSmJdeQ8gOO0G72GNjlgUb4nRm8O66sZmnig==
MIME-Version: 1.0
X-Received: by 10.42.97.193 with SMTP id p1mr21769957icn.32.1390365880337; Tue, 21 Jan 2014 20:44:40 -0800 (PST)
Received: by 10.64.58.77 with HTTP; Tue, 21 Jan 2014 20:44:40 -0800 (PST)
In-Reply-To: <1390300575-6998-2-git-send-email-brobecker@adacore.com>
References: <20140118015244.GA22787@sourceware.org>	<1390300575-6998-1-git-send-email-brobecker@adacore.com>	<1390300575-6998-2-git-send-email-brobecker@adacore.com>
Date: Wed, 22 Jan 2014 04:44:00 -0000
Message-ID: <CADPb22RhU_a8tRxjo2B-=UfbVEABghuFKC5G09RxBM4sCYXSGQ@mail.gmail.com>
Subject: Re: [PATCH 2/2] Add ARI (ok) marker for __func__ reference in common-utils.h
From: Doug Evans <dje@google.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2014-01/txt/msg00835.txt.bz2

On Tue, Jan 21, 2014 at 2:36 AM, Joel Brobecker <brobecker@adacore.com> wrote:
> Hello,
>
> The ARI script flagged the use of the __func__ variable, which
> is normally not allowed (not defined in C90). However, this particular
> use is OK, as the reference is only made when __STDC_VERSION__ >=
> 199901L.  So, add an "ARI:" comment to explicitly OK this use.
>
> gdb/ChangeLog:
>
>         * common/common-utils.h: Add "ARI:" comment besides __func__
>         reference.
>
> OK to commit?

Fine by me.

English nit:  "... comment beside __func__ reference".

I wonder though how ARI handled gdb_assert.h (where FUNCTION_NAME
originates from).