From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-116229-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27513 invoked by alias); 29 Sep 2014 06:01:36 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 27493 invoked by uid 89); 29 Sep 2014 06:01:34 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-vc0-f175.google.com
Received: from mail-vc0-f175.google.com (HELO mail-vc0-f175.google.com) (209.85.220.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 29 Sep 2014 06:01:33 +0000
Received: by mail-vc0-f175.google.com with SMTP id hy4so3951406vcb.6        for <gdb-patches@sourceware.org>; Sun, 28 Sep 2014 23:01:30 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20130820;        h=x-gm-message-state:mime-version:in-reply-to:references:date         :message-id:subject:from:to:cc:content-type;        bh=pihgFj3L7Hgnpx0eHe5WFYJyYW61Daib+MBcv3PBzQU=;        b=fNSJ3U2UeMfDskHhmCONBODdxZfeclmoIEOmVu+Op/9JkXqMvGcXmNmeV2XdO9EIO4         2yNO99Inz9DVOK6Z5PBF6ttL0NRwyGbJcTRh+e9SveQ7L35QTk3oEGxTU2ysslxAnxqs         NeAIj7tv3dhTwjnQ3UgOq1RjU6Z5BLqZHfCkrwqkEaIzkjEOA4pinRBDNL54qmOqbhBN         RNfAfk6q7D4Uwj7W04Qd7f178+giD7o2mc78Q74ay5Q9Cgy6ylsvBmpGvNZa/kmTHxIq         +rlb++/rDOiHEc323V1dglCNtNwKscCsnytsA+2MK5pq95E+WNtuUi68j54+RRwXgpTe         ZMLA==
X-Gm-Message-State: ALoCoQm3LExJIZFhpqEepiBfeYzlYFb8AZP/ZGLCi3Wq+4K3cgwcjo7BtNGPiNM7p1cxj8pjWnbi
MIME-Version: 1.0
X-Received: by 10.220.100.10 with SMTP id w10mr29238058vcn.2.1411970490783; Sun, 28 Sep 2014 23:01:30 -0700 (PDT)
Received: by 10.52.181.65 with HTTP; Sun, 28 Sep 2014 23:01:30 -0700 (PDT)
In-Reply-To: <CAGyQ6gzqbyL-ushbTo9u0iccvmhJnekwa8EDxdL3xCJMkGcEYQ@mail.gmail.com>
References: <CAGyQ6gzqbyL-ushbTo9u0iccvmhJnekwa8EDxdL3xCJMkGcEYQ@mail.gmail.com>
Date: Mon, 29 Sep 2014 06:01:00 -0000
Message-ID: <CADPb22RoEi+AKN+==ZcK-K8MR80gvVje7iaHT7ThMQJ9ibmKWA@mail.gmail.com>
Subject: Re: [PATCH 2/4] PR c++/13403 and PR c++/15154: Fix gnuv3_pass_by_reference to lookup copy c-tors with qualified args
From: Doug Evans <dje@google.com>
To: Siva Chandra <sivachandra@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2014-09/txt/msg00820.txt.bz2

On Thu, Sep 11, 2014 at 11:37 AM, Siva Chandra <sivachandra@google.com> wrote:
> Before this, a copy constructor declared as in the following snippet was
> not being treated as a copy constructor.
>
> class A
> {
> public:
>   A (A &); // OK.
>   A (const A &); // Not being treated as a copy constructor because of the
>                  // 'const' qualifier.
> };
>
> gdb/ChangeLog:
>
> 2014-09-11  Siva Chandra Reddy  <sivachandra@google.com>
>
>         PR c++/13403
>         PR c++/15154
>         * gdbtypes.c (make_qualified_type): Make non-static.
>         * gdbtypes.h (make_qualified_type): Declare.
>         * gnu-v3-abi.c (gnuv3_pass_by_reference): Lookup copy
>         constructors with qualified args

Can you use class_types_same_p here (instead of comparing with the
result of make_qualified_type) ?