From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108439 invoked by alias); 12 May 2015 20:39:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 108424 invoked by uid 89); 12 May 2015 20:39:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-ob0-f179.google.com Received: from mail-ob0-f179.google.com (HELO mail-ob0-f179.google.com) (209.85.214.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 12 May 2015 20:39:29 +0000 Received: by obfe9 with SMTP id e9so14905240obf.1 for ; Tue, 12 May 2015 13:39:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=xFSqCQmTFu30LKfia8OAnN9jj/H1FqoNJTaPeySAp7c=; b=BYNP5k7j1VPFDRfzHeRSi7tKrnQbqkYIHEUMt1GbM+SHBL4H3Q8YakWywEDs5qnQHO MdqfcpXZXGNjXOoLjB+3PcH06lN8/5eFuRxsz5EmWyGoSkoNWxdZE4q9i5HMjUCLPrwH oCH886T7tUzIkcDBc4En+we4JCv5iXNS6MwZWs/j+F01xi4nje5eLIbp/nRPFWUiUuZt XkEOZA0hZjJlGoTfeGCedAMuEMirQgWJqks+0KcgSk4DPb5li1+Hteuu2Ob+ORmL2Sjm /AqOlArJCxovH0jrUm3mdS8xu4FwqJRS5tUyL3gBC5Qgmmx0ZTK0g6pxMi5fOxhnBYEf NE+A== X-Gm-Message-State: ALoCoQlVk4HloenWNkYQTkRtKna7tLbfP7AeyzFaRg7ZTfbpB4tdD1jkYnf9nUtKi2tWFV1sKtBt MIME-Version: 1.0 X-Received: by 10.182.70.100 with SMTP id l4mr13280387obu.77.1431463167810; Tue, 12 May 2015 13:39:27 -0700 (PDT) Received: by 10.182.89.99 with HTTP; Tue, 12 May 2015 13:39:27 -0700 (PDT) In-Reply-To: <83a8zi3qar.fsf@gnu.org> References: <83a8zi3qar.fsf@gnu.org> Date: Tue, 12 May 2015 20:39:00 -0000 Message-ID: Subject: Re: [PATCH 2/6] DWARF Two Level Line Tables: dwarf2_line_debug From: Doug Evans To: Eli Zaretskii Cc: gdb-patches , Cary Coutant Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00286.txt.bz2 On Thu, Mar 12, 2015 at 1:37 PM, Eli Zaretskii wrote: >> From: Doug Evans >> cc: ccoutant@google.com >> Date: Thu, 12 Mar 2015 13:01:49 -0700 >> >> --- a/gdb/NEWS >> +++ b/gdb/NEWS >> @@ -30,6 +30,10 @@ record bts >> >> * New options >> >> +set debug dwarf2-line >> +show debug dwarf2-line >> + Control display of debugging info regarding DWARF line processing. > > This is OK. > >> --- a/gdb/doc/gdb.texinfo >> +++ b/gdb/doc/gdb.texinfo >> @@ -23245,6 +23245,14 @@ The value is the number of nesting levels to print. >> A value of zero turns off the display. >> @item show debug dwarf2-die >> Show the current state of DWARF2 DIE debugging. >> +@item set debug dwarf2-line >> +@cindex DWARF2 Line Tables >> +Turns on or off display of debugging messages related to reading >> +DWARF line tables. The default is 0 (off). >> +A value of 1 provides basic information. >> +A value greater than 1 provides more verbose information. >> +@item show debug dwarf2-line >> +Show the current state of DWARF2 line table debugging. > > This is also OK, but how about using "DWARF2" for consistency at least > in this fragment? Actually, I'd rather use "DWARF". There's a lot of history/inertia here that we should really overcome and put behind us. We call things DWARF2 to disambiguate from DWARF1 (which no longer exists in any useful form). dwarf2read.c should *really* be dwarfread.c IMO (and so on for every other instance of dwarf2/DWARF2/dw2/etc. in file names, code, docs, etc.) > (Btw, I find this "DWARF2", "DWARF 4", "DWARF 5" thing utterly > confusing for the reader; the truth is "DWARF version 5" etc. I wish > we started using that throughout.) Agreed. Where the version doesn't matter I propose using "DWARF". (as in the above)