From: Doug Evans <dje@google.com>
To: Siva Chandra <sivachandra@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 0/4] PR c++/13403 and PR c++/15154: Fix function calling convention in gnuv3 ABI
Date: Mon, 29 Sep 2014 04:12:00 -0000 [thread overview]
Message-ID: <CADPb22SFxfrvDABtsAa-eXJ6OcVxM5_OT6WiXCRxUk=efyTWLA@mail.gmail.com> (raw)
In-Reply-To: <CAGyQ6gy=u+0V42En2rpvwy9n0Ejf_1VfR+xOArLxc1SmoTf2Ug@mail.gmail.com>
On Thu, Sep 11, 2014 at 11:35 AM, Siva Chandra <sivachandra@google.com> wrote:
> This patch series addresses the two listed PRs. The gnuv3 ABI function
> which decides whether a class value has to be passed by reference (or,
> returned in a hidden first parameter) is currently incomplete. This
> patch series completes it.
>
> The way I have organised my patches is that:
>
> - Patch 1/4 adds tests which illustrate what is missing. One test
> fails, another passes.
> - Patch 2/4 fixes the ABI to address the failing the test in 1/4.
> - Patch 3/4 adds another failing test.
> - Patch 4/4 fixes the ABI to address the failing test in 3/4.
>
> If the patches go in in the same order as above, then the tree will
> have one new failing test after 1/4 lands but before 2/4 lands. Is
> that OK? If not, then I can merge 1 and 2 into one patch, and 3 and 4
> into 1 patch. I have ordered it this way because I thought it might be
> easier for the reviewers to see what works and what doesn't currently.
That order is fine by me.
next prev parent reply other threads:[~2014-09-29 4:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 18:35 Siva Chandra
2014-09-23 14:44 ` Siva Chandra
2014-09-29 4:12 ` Doug Evans [this message]
2014-10-15 12:03 ` Siva Chandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADPb22SFxfrvDABtsAa-eXJ6OcVxM5_OT6WiXCRxUk=efyTWLA@mail.gmail.com' \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=sivachandra@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).