From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3823 invoked by alias); 29 Sep 2014 04:12:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3811 invoked by uid 89); 29 Sep 2014 04:12:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f174.google.com Received: from mail-vc0-f174.google.com (HELO mail-vc0-f174.google.com) (209.85.220.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 29 Sep 2014 04:12:50 +0000 Received: by mail-vc0-f174.google.com with SMTP id hy4so1002265vcb.5 for ; Sun, 28 Sep 2014 21:12:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=BoqeLXX7RnvxPQiTAVlEAynF31rNfgTWfS354q5xKdI=; b=LGZC5+uvau4vIT18eY9K3WeCKBvFfhwjOJjbDrVgaDUfQaYQPVyTlO8YbPa6hb8kka zdzbP70pmyF8FdgDZpGtq05Rt8FL2xiwbmh1TxIoY7os4zIewv+ydwHtNc3bGGp6u3hF 1qDrN4Xc7H/kMAwOXCwU3wLrYpbmQk2XBR4cMMYUryVjGceHyONrq+iiS97M2JspfXdq MT9irmbmmc1BW9mGC0cqUbbWrmRNt4Hmicg6SzqWnqrKfOsSJeLTt+qvWjYbggvmLbt9 1ny3mGD2mvaQ8L4dpEPyYBlWeWKwdAb5n9jvuQ8P1lYSJKvlePz1PwbQnUe3bIg+pdUB b4sA== X-Gm-Message-State: ALoCoQm2uUgmY3wH0u5o3WxDFkAnMk6jfv3+AumaBDn8UgH0zGab8h9zRKxSG4v7RcqZ6qDmP+g5 MIME-Version: 1.0 X-Received: by 10.52.87.144 with SMTP id ay16mr3096684vdb.43.1411963968106; Sun, 28 Sep 2014 21:12:48 -0700 (PDT) Received: by 10.52.181.65 with HTTP; Sun, 28 Sep 2014 21:12:48 -0700 (PDT) In-Reply-To: References: Date: Mon, 29 Sep 2014 04:12:00 -0000 Message-ID: Subject: Re: [PATCH 0/4] PR c++/13403 and PR c++/15154: Fix function calling convention in gnuv3 ABI From: Doug Evans To: Siva Chandra Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00818.txt.bz2 On Thu, Sep 11, 2014 at 11:35 AM, Siva Chandra wrote: > This patch series addresses the two listed PRs. The gnuv3 ABI function > which decides whether a class value has to be passed by reference (or, > returned in a hidden first parameter) is currently incomplete. This > patch series completes it. > > The way I have organised my patches is that: > > - Patch 1/4 adds tests which illustrate what is missing. One test > fails, another passes. > - Patch 2/4 fixes the ABI to address the failing the test in 1/4. > - Patch 3/4 adds another failing test. > - Patch 4/4 fixes the ABI to address the failing test in 3/4. > > If the patches go in in the same order as above, then the tree will > have one new failing test after 1/4 lands but before 2/4 lands. Is > that OK? If not, then I can merge 1 and 2 into one patch, and 3 and 4 > into 1 patch. I have ordered it this way because I thought it might be > easier for the reviewers to see what works and what doesn't currently. That order is fine by me.