From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25547 invoked by alias); 6 Jan 2015 00:28:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25528 invoked by uid 89); 6 Jan 2015 00:28:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-oi0-f54.google.com Received: from mail-oi0-f54.google.com (HELO mail-oi0-f54.google.com) (209.85.218.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 06 Jan 2015 00:28:22 +0000 Received: by mail-oi0-f54.google.com with SMTP id u20so50030838oif.13 for ; Mon, 05 Jan 2015 16:28:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=KDQlIJAUNCKxRA0ulFWLNBwO5YguFVhiCJkulw6pDrc=; b=OhDzMPK+mlsvQOhjaYlid+yIU7EIgIA1CRbclgqLErWOWsTixC4tiyVPE8QP28T6f8 265Ptu9WuPA9NeeEy9CKuCiIaRq2Ysgz+3slXlQGuLNHmDh9AG1r1Ht/8XOgfkfPTVWE 4BmhE78FlXGrC/yjSJra75gEMKVk/trm6ofs09vrNeg+56U5pA66+6wFDci233+w2f58 MqOh6Yg50yghMVhR3/A/6/k3L8TE/wq4jA7mdpeitKBmK1am+tCqRKG7aPp0x5RExhgi qSqC5KpQC/2248ZlV46ISJDBlCZbw4DH2PAQrPbOgTwDt94KDEKUBqp8j5gOWD28h0xD p+BQ== X-Gm-Message-State: ALoCoQmCE1UGY/jOng0aB+oAgXhqWUfXqwGH165foX4HDxyN8dwJvhQRWEUWi6eGrIbyiVYl8Zwy MIME-Version: 1.0 X-Received: by 10.60.52.72 with SMTP id r8mr35989295oeo.75.1420504100720; Mon, 05 Jan 2015 16:28:20 -0800 (PST) Received: by 10.182.222.98 with HTTP; Mon, 5 Jan 2015 16:28:20 -0800 (PST) In-Reply-To: <838uhh7y0t.fsf@gnu.org> References: <838uhh7y0t.fsf@gnu.org> Date: Tue, 06 Jan 2015 00:28:00 -0000 Message-ID: Subject: Re: [PATCH] "info source" now includes producer string From: Doug Evans To: Eli Zaretskii Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg00061.txt.bz2 On Mon, Jan 5, 2015 at 12:50 PM, Eli Zaretskii wrote: >> From: Doug Evans >> Date: Mon, 05 Jan 2015 12:41:52 -0800 >> >> bash$ g++ -g -Og hello.cc -o hello >> bash$ gdb hello >> (gdb) start >> (gdb) info source >> Current source file is hello.cc >> Compilation directory is /home/dje >> Located in /home/dje/hello.cc >> Contains 8 lines. >> Source language is c++. >> Producer is GNU C++ 4.8.2 -mtune=generic -march=x86-64 -g -Og -fstack-protector. >> Compiled with DWARF 2 debugging format. >> Does not include preprocessor macro info. > > Thanks. > >> * NEWS: "info source" command now display producer string if present. > ^^^^^^^ > "displays" > >> --- a/gdb/NEWS >> +++ b/gdb/NEWS >> @@ -113,6 +113,9 @@ VAX running Ultrix vax-*-ultrix* >> and "assf"), have been removed. Use the "sharedlibrary" command, or >> its alias "share", instead. >> >> +* The "info source" command now displays the producer string if it was >> + present in the debug info. > > I wonder whether we should replace "producer" with something less > abstract. Would "compilation command line" be accurate enough? The producer string can be anything, it's whatever the compiler decides, so I'm really hesitant to be specific here (and "command line" is too specific for me), because often it will be wrong. I don't mind introducing users to the term "producer". It's the term we use, and it's not gdb or even gnu-specific. > >> --- a/gdb/doc/gdb.texinfo >> +++ b/gdb/doc/gdb.texinfo >> @@ -16279,6 +16279,8 @@ its length, in lines, >> @item >> which programming language it is written in, >> @item >> +if the debug information provides it, the program that compiled the file, > > Not just the program, but also its command line, right? Again, I don't want to provide too much detail here. What the compiler decides to put in its producer string is up to the compiler. > > Okay with those fixed.