From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-87059-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 16319 invoked by alias); 13 Jan 2012 00:21:42 -0000
Received: (qmail 16311 invoked by uid 22791); 13 Jan 2012 00:21:41 -0000
X-SWARE-Spam-Status: No, hits=-3.1 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mail-qy0-f169.google.com (HELO mail-qy0-f169.google.com) (209.85.216.169)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 13 Jan 2012 00:21:21 +0000
Received: by qcsd17 with SMTP id d17so1580128qcs.0        for <gdb-patches@sourceware.org>; Thu, 12 Jan 2012 16:21:20 -0800 (PST)
Received: by 10.229.111.141 with SMTP id s13mr66878qcp.14.1326414080523;        Thu, 12 Jan 2012 16:21:20 -0800 (PST)
MIME-Version: 1.0
Received: by 10.229.111.141 with SMTP id s13mr66870qcp.14.1326414080391; Thu, 12 Jan 2012 16:21:20 -0800 (PST)
Received: by 10.224.195.72 with HTTP; Thu, 12 Jan 2012 16:21:20 -0800 (PST)
In-Reply-To: <20120112235451.GA14124@host2.jankratochvil.net>
References: <20120112030648.14DBE190AFD@elbrus2.mtv.corp.google.com>	<CADPb22TZqh1KJv0KXxRNuhV8PZH-Z31CcggzJMBDJYo3OuZKdA@mail.gmail.com>	<CALoOobMVWJB=u6Y8OMyNeva1KcgU7FP8FpR2aFQ4b2e+=QUgOQ@mail.gmail.com>	<20120112212959.GA24491@host2.jankratochvil.net>	<CALoOobOBfT4n5zXp-=4qyS_7+c0hkhWwxop9B=5aAHuti+bAWg@mail.gmail.com>	<CADPb22Q9qi3TsYw3ZFkAyuO6a0VEJ_wtM_4pe_tXzDW5myi29Q@mail.gmail.com>	<20120112232521.GA25432@host2.jankratochvil.net>	<CADPb22TJhVz=jwsQzEMC=9Jf+df4qXJJkzwN=PkX=fOK2=Lsfg@mail.gmail.com>	<20120112235451.GA14124@host2.jankratochvil.net>
Date: Fri, 13 Jan 2012 00:27:00 -0000
Message-ID: <CADPb22S_tPELtOF7AeeZJ+xBY5n1dZbiO5c4ro-XFwLFrkfnsw@mail.gmail.com>
Subject: Re: [doc patch] gdbint: braces for two lines in code [Re: [patch] Fix for PR gdb/9538 (loading of separate debuginfo and symlinks).]
From: Doug Evans <dje@google.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Paul Pluzhnikov <ppluzhnikov@google.com>, gdb-patches@sourceware.org
X-System-Of-Record: true
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-01/txt/msg00456.txt.bz2

On Thu, Jan 12, 2012 at 3:54 PM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> On Fri, 13 Jan 2012 00:28:35 +0100, Doug Evans wrote:
>> I think we should make the braces required.
>
> OK to check in?

Ok by me!
[give it awhile to see if anyone objects :-)]


>
>
> Thanks,
> Jan
>
>
> gdb/doc/
> 2012-01-12 =A0Jan Kratochvil =A0<jan.kratochvil@redhat.com>
>
> =A0 =A0 =A0 =A0* gdbint.texinfo (Coding Standards): Require braces for tw=
o lines of
> =A0 =A0 =A0 =A0code.
>
> --- a/gdb/doc/gdbint.texinfo
> +++ b/gdb/doc/gdbint.texinfo
> @@ -5849,6 +5849,26 @@ the following guidelines:
> =A0@tab (pointer dereference)
> =A0@end multitable
>
> +Any two lines in code should be wrapped in braces as they look as separa=
te
> +statements:
> +
> +@smallexample
> +if (i)
> + =A0@{
> + =A0 =A0/* Return success. =A0*/
> + =A0 =A0return 0;
> + =A0@}
> +@end smallexample
> +
> +@noindent
> +and not:
> +
> +@smallexample
> +if (i)
> + =A0/* Return success. =A0*/
> + =A0return 0;
> +@end smallexample
> +
> =A0@subsection Comments
>
> =A0@cindex comment formatting