From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12866 invoked by alias); 15 Aug 2012 00:41:35 -0000 Received: (qmail 12855 invoked by uid 22791); 15 Aug 2012 00:41:34 -0000 X-SWARE-Spam-Status: No, hits=-5.5 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vb0-f41.google.com (HELO mail-vb0-f41.google.com) (209.85.212.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 15 Aug 2012 00:41:21 +0000 Received: by vbkv13 with SMTP id v13so1160534vbk.0 for ; Tue, 14 Aug 2012 17:41:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-system-of-record:x-gm-message-state; bh=cL8KkkpwJcX+Q6XTIfjEYcq3mMv+xhnM2AuM+4A2kVc=; b=U6hATQmxPEo2VNhW0/RXzkGW+phvHoff3Z5Ricnlc2Dy5iazrLQOFbujmVUNyCHlDx XcPAbdhBhoYTyMkN0L3OR85xj1lonms3o/doLnoE+RAilY+NI61u1jXEFCv9kdiszMEJ pifI3cQpcuFrwNAsrsPozLR3P4/Zv1dU9NVcURScQBiXDNzDlReG5AYPTVhLzG0L2l9j 1qQaCq3P5bKeIPMTcxDrUoFoDOZMZe27quVQNQGE6zwAMSjKFDiJHSrik+Y9i1bFvobq 9qholx6woFxL80r9seazI25r8h7XHQtIlkV6N3hYnyh4o1NrcUBy0jHl2/Ve6BTZ/3BI QwWw== Received: by 10.220.116.6 with SMTP id k6mr8726179vcq.59.1344991280732; Tue, 14 Aug 2012 17:41:20 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.116.6 with SMTP id k6mr8726165vcq.59.1344991280630; Tue, 14 Aug 2012 17:41:20 -0700 (PDT) Received: by 10.52.117.3 with HTTP; Tue, 14 Aug 2012 17:41:20 -0700 (PDT) In-Reply-To: <1344949171-9545-2-git-send-email-markus.t.metzger@intel.com> References: <1344949171-9545-1-git-send-email-markus.t.metzger@intel.com> <1344949171-9545-2-git-send-email-markus.t.metzger@intel.com> Date: Wed, 15 Aug 2012 00:41:00 -0000 Message-ID: Subject: Re: [patch v3 01/16] gdbserver, build: add -DGDBSERVER From: Doug Evans To: markus.t.metzger@intel.com Cc: gdb-patches@sourceware.org, markus.t.metzger@gmail.com, jan.kratochvil@redhat.com, palves@redhat.com, tromey@redhat.com, kettenis@gnu.org Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true X-Gm-Message-State: ALoCoQncRMIAB/Yan/QBpyvWAWG/Tpdi0LUj/hzPfqXTzH0UB0gVbzjcQ0VTH+Ubp/eIRzq+OhXiATS+VQPgf6vlwL5ji3N3EDJk1m+ITPCGJ6VsVCL8k4nThhLNfMoEo1l9k49fWjAQ4sB486A7ESrZXXtclDgXVZTmeqBH+dBZJ+7YLMjzCo05/6nIhFvhzmtcO07r5udFdTbFTP8ZsQ87BWKtgHLhOw== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00424.txt.bz2 On Tue, Aug 14, 2012 at 5:59 AM, wrote: > From: Markus Metzger > > A use of common/vec.h in gdbserver may result in compile errors if GDBSERVER is > not defined. > > Add -DGDBSERVER to all gdbserver cflags. > > 2012-08-14 Markus Metzger > > gdbserver/ > * Makefile.in: (INTERNAL_CFLAGS): Add -DGDBSERVER > (various make rules): Remove -DGDBSERVER > > > --- > gdb/gdbserver/Makefile.in | 27 +++++++++++++++------------ > 1 files changed, 15 insertions(+), 12 deletions(-) > > diff --git a/gdb/gdbserver/Makefile.in b/gdb/gdbserver/Makefile.in > index f62799e..ae5a60e 100644 > --- a/gdb/gdbserver/Makefile.in > +++ b/gdb/gdbserver/Makefile.in > @@ -113,6 +113,9 @@ INTERNAL_CFLAGS_BASE = ${CFLAGS} ${GLOBAL_CFLAGS} \ > INTERNAL_WARN_CFLAGS = ${INTERNAL_CFLAGS_BASE} $(WARN_CFLAGS) > INTERNAL_CFLAGS = ${INTERNAL_WARN_CFLAGS} $(WERROR_CFLAGS) > > +# Let all files know we're compiling for gdbserver. > +INTERNAL_CFLAGS += -DGDBSERVER > + > # LDFLAGS is specifically reserved for setting from the command line > # when running make. > LDFLAGS = @LDFLAGS@ > @@ -447,7 +450,7 @@ UST_CFLAGS = $(ustinc) -DCONFIG_UST_GDB_INTEGRATION > # Note, we only build the IPA if -fvisibility=hidden is supported in > # the first place. > IPAGENT_CFLAGS = $(CPPFLAGS) $(INTERNAL_CFLAGS) $(UST_CFLAGS) \ > - -fPIC -DGDBSERVER -DIN_PROCESS_AGENT \ > + -fPIC -DIN_PROCESS_AGENT \ > -fvisibility=hidden "+=" is a GNU make-ism, I think we can't use it here. Plus you missed one: gdb_vecs.o: ../common/gdb_vecs.c $(vec_h) $(gdb_vecs_h) $(host_defs_h) $(CC) -c $(CPPFLAGS) $(INTERNAL_CFLAGS) $< -DGDBSERVER