From: Doug Evans <dje@google.com>
To: Siva Chandra <sivachandra@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/4] PR c++/13403 and PR c++/15154: Non trivial return value tests
Date: Mon, 29 Sep 2014 06:16:00 -0000 [thread overview]
Message-ID: <CADPb22Snz8GoBtPLBjVBK0shSfMUb3LpWez+mTU3Re98ZC4Omw@mail.gmail.com> (raw)
In-Reply-To: <CADPb22Sk7LyeSmECw_hmm_eoa+9P-=6huSwFd=Cc0cFawhMNxg@mail.gmail.com>
On Sun, Sep 28, 2014 at 10:59 PM, Doug Evans <dje@google.com> wrote:
> On Thu, Sep 11, 2014 at 11:36 AM, Siva Chandra <sivachandra@google.com> wrote:
>> Adds two tests, one fails and another passes. These tests illustrate
>> the way in which the ABI function gnuv3_pass_by_reference is
>> incomplete.
>>
>> gdb/testsuite/ChangeLog:
>>
>> 2014-09-11 Siva Chandra Reddy <sivachandra@google.com>
>>
>> PR c++/13403
>> PR c++/15154
>> * gdb.cp/non-trivial-retval.cc: New file.
>> * gdb.cp/non-trivial-retval.exp: New file.
>
> LGTM
Forgot.
One thing I wanted to ask is if the regexp could be more specific.
E.g., instead of .*a = 11.*, have the full output?
prev parent reply other threads:[~2014-09-29 6:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 18:36 Siva Chandra
2014-09-29 5:59 ` Doug Evans
2014-09-29 6:16 ` Doug Evans [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADPb22Snz8GoBtPLBjVBK0shSfMUb3LpWez+mTU3Re98ZC4Omw@mail.gmail.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=sivachandra@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).