From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-122049-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 74450 invoked by alias); 17 Apr 2015 02:47:01 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 74435 invoked by uid 89); 17 Apr 2015 02:47:00 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: mail-ob0-f172.google.com
Received: from mail-ob0-f172.google.com (HELO mail-ob0-f172.google.com) (209.85.214.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 17 Apr 2015 02:46:59 +0000
Received: by obbfy7 with SMTP id fy7so56306669obb.2        for <gdb-patches@sourceware.org>; Thu, 16 Apr 2015 19:46:57 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20130820;        h=x-gm-message-state:mime-version:in-reply-to:references:date         :message-id:subject:from:to:cc:content-type;        bh=t2THgJLpZwJM0fieRF3D4D/TzLzcXHHlc3CzooFamec=;        b=WCq6AMEFXOyUjq9/KhCWl67Hmbm+SsVuk69BKa8kzmf4l8fNsm4RqlqABs3NrskZab         oUaM1UJ4q9/rBar9eOUrc2qd33Fs7xV5nk0eovhfFHSq/ArWETgl0LB0ahIM5du4+4gb         t9H29yc2G6LGquip0tq6KWN4AG6Ejkm9VGlmWlFaHcmawgGqdh+dm3L4fE+MRzxqnDs0         u+D05eEg5z7u/6Y0hlbak4SNExyVY0p49pGuQtsSJWTtrEiy9qZaUbTJxPdS7YC5U7P0         as5qmTTUK8sSgMoHmEX/M1MlwqOuX+zdWDHqu83PXO1PaITh6BRSsOMMiPQTSNnBTHYi         L1qA==
X-Gm-Message-State: ALoCoQn6IhVd5ykdG0soYvscOCAv+mOy4Uc/4KvW86NO5gOs2ZXkzdYYxEM3GNe5MrLg7OvAmOQH
MIME-Version: 1.0
X-Received: by 10.60.123.40 with SMTP id lx8mr732313oeb.15.1429238817403; Thu, 16 Apr 2015 19:46:57 -0700 (PDT)
Received: by 10.182.103.101 with HTTP; Thu, 16 Apr 2015 19:46:57 -0700 (PDT)
In-Reply-To: <1429186791-6867-2-git-send-email-gbenson@redhat.com>
References: <1429186791-6867-1-git-send-email-gbenson@redhat.com>	<1429186791-6867-2-git-send-email-gbenson@redhat.com>
Date: Fri, 17 Apr 2015 02:47:00 -0000
Message-ID: <CADPb22SpvAFa4fg6hc2Y7jhG2zSJ=vi_z747QWW6cZ0iFKnxqg@mail.gmail.com>
Subject: Re: [PATCH 1/7] Move make_cleanup_close to common code
From: Doug Evans <dje@google.com>
To: Gary Benson <gbenson@redhat.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2015-04/txt/msg00637.txt.bz2

On Thu, Apr 16, 2015 at 5:19 AM, Gary Benson <gbenson@redhat.com> wrote:
> This commit moves the function make_cleanup_close from gdb/utils.[ch]
> to gdb/common/cleanup-utils.[ch] to make it usable from common code.
> A new file was created over putting the function in common-utils.[ch]
> to avoid having to build cleanups.c into the in-process agent.
>
> gdb/ChangeLog:
>
>         * common/cleanup-utils.h: New file.
>         * common/cleanup-utils.c: Likewise.
>         * Makefile.in (SFILES): Add common/cleanup-utils.c.
>         (HFILES_NO_SRCDIR): Add common/cleanup-utils.h.
>         (COMMON_OBS): Add cleanup-utils.o.
>         (cleanup-utils.o): New rule.
>         * common/common-utils.h (cleanup-utils.h): New include.
>         * utils.h (make_cleanup_close): Moved to cleanup-utils.h.
>         * utils.c (do_close_cleanup): Moved to cleanup-utils.c.
>         (make_cleanup_close): Likewise.
>
> gdb/gdbserver/ChangeLog:
>
>         * Makefile.in (SFILES): Add common/cleanup-utils.c.
>         (OBS): Add cleanup-utils.o.
>         (cleanup-utils.o): New rule.

Hi.

I haven't reviewed the entire patch set (often I want to read the
whole thing first before sending reviews, but in the interests of
saving time ...).

LGTM.