From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27280 invoked by alias); 22 Jan 2015 19:10:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26135 invoked by uid 89); 22 Jan 2015 19:05:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-ob0-f177.google.com Received: from mail-ob0-f177.google.com (HELO mail-ob0-f177.google.com) (209.85.214.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 22 Jan 2015 18:59:58 +0000 Received: by mail-ob0-f177.google.com with SMTP id uy5so3062999obc.8 for ; Thu, 22 Jan 2015 10:59:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=o8eGg0oHEYecNPXkeFDaMp++gAL3qA3xeL3TuTgiNLY=; b=AAbyrTwUyaK8IhUOEQ4cFvSGXkeQuAxlQNKwuo4Rtbz9l2gU6yiurlBXaQglljrO5T mfXEyZArlD/g3bYtQmkgLZabgc5SQTWjLCZGRkBiVkbBqDYIvcR3kkZ1PCyMmRhP8ed0 rT8Y8tGR5Mv/mTGrLGEEjX6ke04gMZuGri0b8sy7VOArdWPOJH8ckU49zORRgorfCeLL kEC+PvsmNUSQgFuEyt1fgGq7zmzfgGWqxd8g3u0OT+RmE11Z1dltbrnmIwsNu5vPFFa/ B83xFrhSRzfe82bKuO17oDfTtpTprn+gBS3kzVv+O1PriEIREFacl4aaAJOPbBba7kW5 0sMw== X-Gm-Message-State: ALoCoQlijAo5OpLPPkO0JrGGftjenOja+8ojCXFn0GzhqMxMekeMWF0+Q3loXhiNkCUPmSOyjGPN MIME-Version: 1.0 X-Received: by 10.182.148.98 with SMTP id tr2mr1965504obb.28.1421953195536; Thu, 22 Jan 2015 10:59:55 -0800 (PST) Received: by 10.182.222.98 with HTTP; Thu, 22 Jan 2015 10:59:55 -0800 (PST) In-Reply-To: <20150122184655.GA15064@host2.jankratochvil.net> References: <20150115183316.GA16405@host2.jankratochvil.net> <20150116233802.GA8732@host2.jankratochvil.net> <21696.17350.451535.337528@ruffy2.mtv.corp.google.com> <20150122184655.GA15064@host2.jankratochvil.net> Date: Thu, 22 Jan 2015 19:10:00 -0000 Message-ID: Subject: Re: [patchv3] Sort threads for thread apply all (bt) From: Doug Evans To: Jan Kratochvil Cc: Eli Zaretskii , gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg00617.txt.bz2 On Thu, Jan 22, 2015 at 10:46 AM, Jan Kratochvil wrote: > ... >> This triggers my "passing parameters as global variables" alarm, >> and while one could instead have two different functions, > > I believe qsort_r() is more appropriate, using two different functions I would > feel rather as a workaround of missing qsort_r(). But I guess (I cannot easily > test due to missing slaves and no patch testing feature in Sergio's Buildbot > yet) some of the supported platforms do not provide qsort_r() so it would need > a new gdb/gnulib/ module. But at least one of my gdb/gnulib/ patches is still > under review so it would create dependency between unrelated patchsets. I think you're splitting hairs here. > + if (cmd != NULL && (check_for_argument (&cmd, "-ascending", strlen ("-asc")))) strlen ("-ascending") Also, remove the extra parens around check_for_argument? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29070 invoked by alias); 22 Jan 2015 19:23:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27951 invoked by uid 89); 22 Jan 2015 19:15:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,TIME_LIMIT_EXCEEDED autolearn=unavailable version=3.3.2 X-HELO: mail-oi0-f45.google.com Received: from Unknown (HELO mail-oi0-f45.google.com) (209.85.218.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 22 Jan 2015 19:07:18 +0000 Received: by mail-oi0-f45.google.com with SMTP id g201so2922594oib.4 for ; Thu, 22 Jan 2015 11:06:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=o8eGg0oHEYecNPXkeFDaMp++gAL3qA3xeL3TuTgiNLY=; b=ApgElammCL1IhZNfqs2hez1TwBCIhqseFtv9nomzStHbRWNl4ppV+m/TZJw/krWKmU Ch3chroMDkVzlo5LaUGe9BBqR3eosXMhA+N2y+N4OWQcA8exsETye6+k6CLesJ5kg22P r7UNZvi97WtzQ6yTj7LzdakUI9zNqVjvtTgMp6X4gk76svXX+8z02BLit1B2YhQ1QNJX UhXVIG0dFjzm81vcoH1vURqEEPXinuntOz/y3jVyCiFCK9QF6obydxNqpW7mVMRWLsOB JUl6yqaFx7iei72U82u80Bc/NGtyx6nJQFPCC8Jqte/A7CqLxGBGjaTcU3vVd/GgqWwq +FVA== X-Gm-Message-State: ALoCoQmpn9gh29srWaGKuvMu4PZ/+v9msYEsFN3A6DM0sCmwuqNeINJ5YgD3/0O0C6w+NNKWoapk MIME-Version: 1.0 X-Received: by 10.182.148.98 with SMTP id tr2mr1965504obb.28.1421953195536; Thu, 22 Jan 2015 10:59:55 -0800 (PST) Received: by 10.182.222.98 with HTTP; Thu, 22 Jan 2015 10:59:55 -0800 (PST) In-Reply-To: <20150122184655.GA15064@host2.jankratochvil.net> References: <20150115183316.GA16405@host2.jankratochvil.net> <20150116233802.GA8732@host2.jankratochvil.net> <21696.17350.451535.337528@ruffy2.mtv.corp.google.com> <20150122184655.GA15064@host2.jankratochvil.net> Date: Thu, 22 Jan 2015 19:23:00 -0000 Message-ID: Subject: Re: [patchv3] Sort threads for thread apply all (bt) From: Doug Evans To: Jan Kratochvil Cc: Eli Zaretskii , gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg00618.txt.bz2 Message-ID: <20150122192300.ZWIBfqrYYzqzoHlVVzGXdfzOcVNwAUpED9oMPj-MnVg@z> On Thu, Jan 22, 2015 at 10:46 AM, Jan Kratochvil wrote: > ... >> This triggers my "passing parameters as global variables" alarm, >> and while one could instead have two different functions, > > I believe qsort_r() is more appropriate, using two different functions I would > feel rather as a workaround of missing qsort_r(). But I guess (I cannot easily > test due to missing slaves and no patch testing feature in Sergio's Buildbot > yet) some of the supported platforms do not provide qsort_r() so it would need > a new gdb/gnulib/ module. But at least one of my gdb/gnulib/ patches is still > under review so it would create dependency between unrelated patchsets. I think you're splitting hairs here. > + if (cmd != NULL && (check_for_argument (&cmd, "-ascending", strlen ("-asc")))) strlen ("-ascending") Also, remove the extra parens around check_for_argument? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5813 invoked by alias); 22 Jan 2015 19:26:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4323 invoked by uid 89); 22 Jan 2015 19:25:21 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.2 X-HELO: mail-ob0-f182.google.com Received: from mail-ob0-f182.google.com (HELO mail-ob0-f182.google.com) (209.85.214.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 22 Jan 2015 19:25:18 +0000 Received: by mail-ob0-f182.google.com with SMTP id gq1so3263915obb.13 for ; Thu, 22 Jan 2015 11:25:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=o8eGg0oHEYecNPXkeFDaMp++gAL3qA3xeL3TuTgiNLY=; b=fLbPijdRjdUMbaE8APShyvir8na19FHXsk1qJRzSGydhDECujWByAXvurMfEGOHFuI +YCqlxk8RmgSOZJ4gWKhO5UqXWfBQ9VMYlYX9HtT+iiHvD+pJF4VcBlD5VLYPL3VD7S6 mCrAzNmm7ST7Q2rv/oGheERLT81zbM/5nFcq4dBg8454IXnatP7Jjg4czLd7GFRAJNPY nhhUTctt3F00wrbG0FogepSolVKlFAPtmamjjOvn7Xd4HqHzRidN7KGccaFjNN37o4gS LnoMf4mUMmOUSf/RpJe2p4/tjiVz5vDnrr0P0ATudFVJiCxFUMBPprUA3lcr+oiQt592 UDwA== X-Gm-Message-State: ALoCoQkGhY1Z1yUi1os1Cd1VtIoSD70MlLLGeGX9iFay/0y04TTl+IGGfo3hxR4DoowhB4oXRRMV MIME-Version: 1.0 X-Received: by 10.182.148.98 with SMTP id tr2mr1965504obb.28.1421953195536; Thu, 22 Jan 2015 10:59:55 -0800 (PST) Received: by 10.182.222.98 with HTTP; Thu, 22 Jan 2015 10:59:55 -0800 (PST) In-Reply-To: <20150122184655.GA15064@host2.jankratochvil.net> References: <20150115183316.GA16405@host2.jankratochvil.net> <20150116233802.GA8732@host2.jankratochvil.net> <21696.17350.451535.337528@ruffy2.mtv.corp.google.com> <20150122184655.GA15064@host2.jankratochvil.net> Date: Thu, 22 Jan 2015 20:37:00 -0000 Message-ID: Subject: Re: [patchv3] Sort threads for thread apply all (bt) From: Doug Evans To: Jan Kratochvil Cc: Eli Zaretskii , gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg00623.txt.bz2 Message-ID: <20150122203700.TQPrOPjeDsVg0OpXuEe_K4mcYtXFToMllgtCOvksH0g@z> On Thu, Jan 22, 2015 at 10:46 AM, Jan Kratochvil wrote: > ... >> This triggers my "passing parameters as global variables" alarm, >> and while one could instead have two different functions, > > I believe qsort_r() is more appropriate, using two different functions I would > feel rather as a workaround of missing qsort_r(). But I guess (I cannot easily > test due to missing slaves and no patch testing feature in Sergio's Buildbot > yet) some of the supported platforms do not provide qsort_r() so it would need > a new gdb/gnulib/ module. But at least one of my gdb/gnulib/ patches is still > under review so it would create dependency between unrelated patchsets. I think you're splitting hairs here. > + if (cmd != NULL && (check_for_argument (&cmd, "-ascending", strlen ("-asc")))) strlen ("-ascending") Also, remove the extra parens around check_for_argument?