From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-123247-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 105271 invoked by alias); 29 May 2015 16:26:10 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 105261 invoked by uid 89); 29 May 2015 16:26:09 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: mail-oi0-f47.google.com
Received: from mail-oi0-f47.google.com (HELO mail-oi0-f47.google.com) (209.85.218.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 29 May 2015 16:26:08 +0000
Received: by oiww2 with SMTP id w2so60395803oiw.0        for <gdb-patches@sourceware.org>; Fri, 29 May 2015 09:26:06 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20130820;        h=x-gm-message-state:mime-version:in-reply-to:references:date         :message-id:subject:from:to:cc:content-type;        bh=715wlKynK7BEI2LzJWL2mWFdePYiNyx35Q2FJ+fR1TU=;        b=dvSpDoeaw96o1vExUK1RG7f5bWYXrX0Ia2zDbVjED1A+UAu18HHo7jEU07oEv+ZcKS         +9ePscwXfkZzXiTC0juvj/cszhR5XMI6ySJ6d4dw+I5Yzx05UY+ovFum/AEsiz3G94iP         1B4eSRBl66EN5oqXx/ls9e0CCFlnZ0Pw8KKBKTeiGrZRY416PPm6hgPLsZPLff7nlF8w         gmsB//UXu6q6VRlLp5/VuYGjjW7lE6JeLUehCk2tpq2hewAi0HJejRy0J97qhEToMg+w         /ZxAAx4col2mZJIMXKioJBC3/63kfwoqxdn8ZibEablqSBkCxtiwqTImoudOEEeezgw6         N1XA==
X-Gm-Message-State: ALoCoQnk+Mz0gH1tVKcmJqRCPrfSLQImYgOj9hIVQYlV5T0rVJhvze4Ev0J5i/8kvLr00khuGeis
MIME-Version: 1.0
X-Received: by 10.182.22.11 with SMTP id z11mr6146862obe.77.1432916766343; Fri, 29 May 2015 09:26:06 -0700 (PDT)
Received: by 10.182.89.99 with HTTP; Fri, 29 May 2015 09:26:06 -0700 (PDT)
In-Reply-To: <55683A6F.2030600@redhat.com>
References: <CAB=4xhoR0=ZaDot6rEaVhhEAxYeoBjP89AHhxgD52ANKKrDYJg@mail.gmail.com>	<55683A6F.2030600@redhat.com>
Date: Fri, 29 May 2015 16:26:00 -0000
Message-ID: <CADPb22T2TU-zaAbuu0qa5yrOdsBVjXVHfezOVYbuKL+8zP7twg@mail.gmail.com>
Subject: Re: [PATCH users/roland/osabi-assert] Do not crash on unrecognized GNU .note.ABI-tag values
From: Doug Evans <dje@google.com>
To: Pedro Alves <palves@redhat.com>
Cc: Roland McGrath <mcgrathr@google.com>, GDB <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2015-05/txt/msg00719.txt.bz2

On Fri, May 29, 2015 at 3:07 AM, Pedro Alves <palves@redhat.com> wrote:
> On 05/29/2015 01:21 AM, Roland McGrath wrote:
>> Diagnosis of unexpected input (in this case, in an executable file)
>> should not crash as if it were a bug in GDB.
>>...
>> +              warning ("GNU ABI tag value %u unrecognized.\n", abi_tag);
>
> Wrap string in _().

No trailing \n too, right?