Re: [PATCH] Fission support for multiple CUs per DWO file

["Doug Evans via gdb-patches" <gdb-patches@sourceware.org>]

Once more with feeling (err, not text/html ...).

On Tue, Jun 27, 2017 at 11:52 AM, David Blaikie <dblaikie@gmail.com> wrote:
>
> Ping (no rush, but trying not to forget it myself (: )
>
> On Thu, Jun 1, 2017 at 4:33 PM, David Blaikie <dblaikie@gmail.com> wrote:
> > gdb/ChangeLog:
> >
> > 2017-05-12  David Blaikie  <dblaikie@gmail.com>
> >
> > * dwarf2read.c (struct dwo_file): Use a htab of dwo_unit* (rather than
> > a singular dwo_unit*) to support multiple CUs in the same way that
> > multiple TUs are supported.
> > (static void create_cus_hash_table): Replace create_dwo_cu with a
> > function for parsing multiple CUs from a DWO file.
> > (open_and_init_dwo_file): Use create_cus_hash_table rather than create_dwo_cu.
> > (lookup_dwo_cutu): Lookup CU in the hash table in the dwo_file with
> > htab_find, rather than comparing the signature to a singleton CU in
> > the dwo_file.
> >
> > gdb/testsuite/ChangeLog:
> >
> > 2017-05-12  David Blaikie  <dblaikie@gmail.com>
> >
> > * gdb.dwarf2/fission-multi-cu.S: Test containing multiple CUs in a
> > DWO, built from fission-multi-cu{1,2}.c.
> > * gdb.dwarf2/fission-multi-cu.exp: Test similar to fission-base.exp,
> > except putting 'main' and 'func' in separate CUs while in the same DWO
> > file.
> > * gdb.dwarf2/fission-multi-cu1.c: First CU for the multi-CU-single-DWO test.
> > * gdb.dwarf2/fission-multi-cu2.c: Second CU for the multi-CU-single-DWO test.
> >
> > On Mon, May 22, 2017 at 11:01 AM, Doug Evans <dje@google.com> wrote:
> >> David Blaikie writes:
> >>  > ...
> >>
> >> Hi. Review comments inline.
> >
> > Hi - thanks for the review!
> >
> > (responses inline, patch addressing the issues is attached)
> >
> > Do let me know if there's other things that'd be good to address or if
> > this looks good as-is.

LGTM