From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126725 invoked by alias); 25 Jun 2015 13:34:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 126709 invoked by uid 89); 25 Jun 2015 13:34:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ob0-f179.google.com Received: from mail-ob0-f179.google.com (HELO mail-ob0-f179.google.com) (209.85.214.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 25 Jun 2015 13:34:56 +0000 Received: by obbkm3 with SMTP id km3so47105483obb.1 for ; Thu, 25 Jun 2015 06:34:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=4MehG1Ia/gPXu32hOrIssMOcBk9ZQlL0zCtbMMJz7to=; b=eBxnDSPkpN5s1uNg21st9Ze7LodO1whtZiNR6DHwy3dbGFg818ru+N/nGVpFLdsoQU S7vAkNOr1ZM38iFT2zbSJhCdfguStdNfQieKGZLVlI9FaC2WUDF+JzwVDqfHuStmFtMH mOOC4xkcxWB0MfYzb4Bo3YOk6ktTOZk++xXY4rhvStfTiDjzkzOH3eLxFXd4TZvvIasq 0gcz5oiqjCeLYAC9S5zrZ1h5Rnva4aGlhnOdKfsEVtasRx6F3pDjUyxe4hBlfY2QWxjU BBNGwZ+xm9JyMLXHlnUPPHUXYcYv8XQlA7n6ha9M5CFOzCsNvpslYO0MUQsgmO43Vj/+ jQ1g== X-Gm-Message-State: ALoCoQn4bWYn51vHmZwHxhYMEFB5qNfaxW0TLB4DREKUN5j49sGhEJYVkHsFQLO4ZPqv/XnVfMSw X-Received: by 10.60.147.194 with SMTP id tm2mr39340930oeb.75.1435239294308; Thu, 25 Jun 2015 06:34:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.89.99 with HTTP; Thu, 25 Jun 2015 06:34:14 -0700 (PDT) In-Reply-To: <87lhf8yz90.fsf@br87z6lw.de.ibm.com> References: <86r3p1queo.fsf@gmail.com> <87lhf8yz90.fsf@br87z6lw.de.ibm.com> From: Doug Evans Date: Thu, 25 Jun 2015 13:34:00 -0000 Message-ID: Subject: Re: Several regressions and we branch soon. To: Andreas Arnez Cc: Yao Qi , Joel Brobecker , gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00547.txt.bz2 On Thu, Jun 25, 2015 at 3:21 AM, Andreas Arnez wrote: > On Wed, Jun 24 2015, Yao Qi wrote: > >> Doug Evans writes: >> >>> FAIL: gdb.base/gnu_vector.exp: call add_singlevecs >> >> I see this fail too, >> print add_singlevecs((char1) {6}, (int1) {12}, (double1) {24})^M >> ^M >> Program received signal SIGSEGV, Segmentation fault.^M >> 0x00000000004008ec in add_singlevecs (a=..., b=..., c=...) at ../../../../../binutils-gdb/gdb/testsuite/gdb.base/gnu_vector.c:132^M >> 132 return (double1) {a[0] + b[0] + c[0]};^M >> The program being debugged was signaled while in a function called from GDB.^M >> GDB remains in the frame where the signal was received.^M >> To change this behavior use "set unwindonsignal on".^M >> Evaluation of the expression containing the function^M >> (add_singlevecs) will be abandoned.^M >> When the function is done executing, GDB will silently stop.^M >> (gdb) FAIL: gdb.base/gnu_vector.exp: call add_singlevecs > > This is not a regression in GDB, but a new test uncovering GDB's missing > vector ABI support on x86_64. So for the branch I suggest to suppress > these new FAILs with gnu_vector.exp -- either in the test case or in the > test harness. Any reason to not mark them as K/XFAILs in the master branch? We should avoid adding new tests the we know are going to FAIL (*1). And indeed I see discussion in the submission about that. https://sourceware.org/ml/gdb-patches/2015-05/msg00319.html So we're good there. The question remains though: why are these failing? --- (*1): It should be a rule in the contribution checklist. https://sourceware.org/gdb/wiki/ContributionChecklist It's not, but if I dig a bit deeper, it is: "Known failing new testcases must produce KFAIL (GDB problem) or XFAIL (environment problem)." https://sourceware.org/gdb/wiki/GDBTestcaseCookbook I added a bit more text to the checklist so one doesn't have to dig to see it.