From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31334 invoked by alias); 27 Jul 2013 17:13:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31304 invoked by uid 89); 27 Jul 2013 17:13:38 -0000 X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RDNS_NONE,SPF_PASS autolearn=ham version=3.3.1 Received: from Unknown (HELO mail-ob0-f173.google.com) (209.85.214.173) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sat, 27 Jul 2013 17:13:37 +0000 Received: by mail-ob0-f173.google.com with SMTP id er7so6635764obc.32 for ; Sat, 27 Jul 2013 10:13:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-gm-message-state; bh=Zl7Nv4eQ3GQE4ItivEgHJnlMLHI1bGfwLrE/9jb9hBM=; b=gMROmUVmFw2IUMkky/BDOL3FuFujXONLr8ivH8oWlAJCUDWsdiLLVRlSGpYn/cwRSk BLDxVHZW/Rju7cAEyu2OPnbEhDYxwZkbVXZ/OENmZUardaLGuU/P2ID2vducWkF2p2hF EBJ69Tx8Sqpu4eZnaxJ2/J087oXJVxZgbDeAyYVGxssvZbyXuFmLy0ryg/kjTXolWwxu HZdWNwYLt7Z6pbLDgiUrKcNLeltTl/SARNmaUkm/bc9G+y0k1E4c8yxgx0aviBBs4Tor 4RDBKdQlLLiHM3CpIMpOZJIA96KVqDg6VGnJSgGFROgILpAenkuFpW8RFBjylS7x/4Nd CWhg== MIME-Version: 1.0 X-Received: by 10.42.122.19 with SMTP id l19mr20840853icr.12.1374945209898; Sat, 27 Jul 2013 10:13:29 -0700 (PDT) Received: by 10.64.239.148 with HTTP; Sat, 27 Jul 2013 10:13:29 -0700 (PDT) In-Reply-To: <1374869594-16965-6-git-send-email-sergiodj@redhat.com> References: <1374869594-16965-1-git-send-email-sergiodj@redhat.com> <1374869594-16965-6-git-send-email-sergiodj@redhat.com> Date: Sat, 27 Jul 2013 17:13:00 -0000 Message-ID: Subject: Re: [PATCH 5/7] SPARC support From: Doug Evans To: Sergio Durigan Junior Cc: GDB Patches , Tom Tromey Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQmdpcg2E/W+bo52miWCpRwBICVp2QN9LN9y+hVQ+aO1IqxIJiMaiY/C1HpTUgAHvG4W/wgiqZBUgSptFEx+VkQOiSoPx6u1pCjsms3QzEgxtApEQBgxK/W8b3ibLxz4cZLR52WIc6XFL0DhOf7pohTELSlCdErVsAU3TAkczP9XSlbSuswC0G8TZQJS0H4A6RVrYuhoySy+/KUZfPkC8xSwRkk2FA== X-SW-Source: 2013-07/txt/msg00662.txt.bz2 Hi. Just a nit. On Fri, Jul 26, 2013 at 1:13 PM, Sergio Durigan Junior wrote: > Support for SPARC. It does not share some signal numbers, therefore > there is the target-specific implementation for them. > > 2013-07-26 Sergio Durigan Junior > > * sparc-linux-tdep.c: Define enum with differences between SPARC > and x86 signal numbers. > (sparc32_linux_gdb_signal_from_target): New function. > (sparc32_linux_gdb_signal_to_target): Likewise. > (sparc32_linux_init_abi): Set gdbarch_gdb_signal_{to,from}_target > to the functions defined above. > [...] > @@ -267,6 +292,113 @@ sparc32_linux_get_syscall_number (struct gdbarch *gdbarch, > > return ret; > } Nit: Missing blank line here. > +/* Implementation of `gdbarch_gdb_signal_from_target', as defined in > + gdbarch.h. */ > + > +static enum gdb_signal > +sparc32_linux_gdb_signal_from_target (struct gdbarch *gdbarch, > + int signal) > +{ > [...]