From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10408 invoked by alias); 12 Jan 2012 23:28:57 -0000 Received: (qmail 10397 invoked by uid 22791); 12 Jan 2012 23:28:56 -0000 X-SWARE-Spam-Status: No, hits=-3.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-qw0-f41.google.com (HELO mail-qw0-f41.google.com) (209.85.216.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 12 Jan 2012 23:28:37 +0000 Received: by qats34 with SMTP id s34so479092qat.0 for ; Thu, 12 Jan 2012 15:28:36 -0800 (PST) Received: by 10.224.106.196 with SMTP id y4mr50994qao.90.1326410916677; Thu, 12 Jan 2012 15:28:36 -0800 (PST) MIME-Version: 1.0 Received: by 10.224.106.196 with SMTP id y4mr50953qao.90.1326410915852; Thu, 12 Jan 2012 15:28:35 -0800 (PST) Received: by 10.224.195.72 with HTTP; Thu, 12 Jan 2012 15:28:35 -0800 (PST) In-Reply-To: <20120112232521.GA25432@host2.jankratochvil.net> References: <20120112030648.14DBE190AFD@elbrus2.mtv.corp.google.com> <20120112212959.GA24491@host2.jankratochvil.net> <20120112232521.GA25432@host2.jankratochvil.net> Date: Thu, 12 Jan 2012 23:40:00 -0000 Message-ID: Subject: Re: [patch] Fix for PR gdb/9538 (loading of separate debuginfo and symlinks). From: Doug Evans To: Jan Kratochvil Cc: Paul Pluzhnikov , gdb-patches@sourceware.org X-System-Of-Record: true Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00451.txt.bz2 On Thu, Jan 12, 2012 at 3:25 PM, Jan Kratochvil wrote: > On Fri, 13 Jan 2012 00:17:55 +0100, Doug Evans wrote: >> OOC, Jan, what discussion led rise to having braces here: > > There was only Mark's agreement with me as I read now: > =A0 =A0 =A0 =A0Re: Code formatting [Re: [patch] s390*: watchpoints regres= sion [repost]] > =A0 =A0 =A0 =A0http://sourceware.org/ml/gdb-patches/2011-12/msg00600.html > > So still not sure what is the general consensus. Thanks. I think we should make the braces required. >> and does that reasoning apply here: >> >> + =A0if (debuglink =3D=3D NULL) >> + =A0 =A0/* There's no separate debug info, hence there's no way we could >> + =A0 =A0 =A0 load it =3D> no warning. =A0*/ >> + =A0 =A0return NULL; > > There exist already many cases in GDB not compliant with this rule. Yeah. Asking for it is a start. > > > Regards, > Jan