From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16745 invoked by alias); 11 Jan 2012 19:11:39 -0000 Received: (qmail 16737 invoked by uid 22791); 11 Jan 2012 19:11:38 -0000 X-SWARE-Spam-Status: No, hits=-3.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vx0-f169.google.com (HELO mail-vx0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 11 Jan 2012 19:11:24 +0000 Received: by vcge1 with SMTP id e1so905280vcg.0 for ; Wed, 11 Jan 2012 11:11:23 -0800 (PST) Received: by 10.220.224.194 with SMTP id ip2mr352356vcb.41.1326309083335; Wed, 11 Jan 2012 11:11:23 -0800 (PST) MIME-Version: 1.0 Received: by 10.220.224.194 with SMTP id ip2mr352343vcb.41.1326309083248; Wed, 11 Jan 2012 11:11:23 -0800 (PST) Received: by 10.220.229.1 with HTTP; Wed, 11 Jan 2012 11:11:23 -0800 (PST) In-Reply-To: <20120111090446.GH31383@adacore.com> References: <20120110014616.957501E25C7@ruffy2.mtv.corp.google.com> <20120110035113.GA31383@adacore.com> <20120111090446.GH31383@adacore.com> Date: Wed, 11 Jan 2012 19:24:00 -0000 Message-ID: Subject: Re: [patch] dwarf2read.c: Don't read pc/line-number mapping for type units From: Doug Evans To: Joel Brobecker Cc: gdb-patches@sourceware.org X-System-Of-Record: true Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00363.txt.bz2 On Wed, Jan 11, 2012 at 1:04 AM, Joel Brobecker wro= te: >> Appended is what I committed to trunk. >> I think it's fine. > [...] >> The memory space reduction is substantial so I'd like to get this in 7.4. >> [the reduction only kicks in for .debug_types, btw] >> >> 2012-01-10 =A0Doug Evans =A0 >> >> =A0 =A0 =A0 =A0 * dwarf2read.c (dwarf_decode_lines): Remove arg "abfd". = =A0New arg >> =A0 =A0 =A0 =A0 "want_line_info". =A0All callers updated. >> =A0 =A0 =A0 =A0 (dwarf_decode_lines_1): New function. >> =A0 =A0 =A0 =A0 (handle_DW_AT_stmt_list): Add function comment. >> =A0 =A0 =A0 =A0 New arg "want_line_info". =A0All callers updated. >> =A0 =A0 =A0 =A0 (read_file_scope,read_type_unit_scope): Move comment from >> =A0 =A0 =A0 =A0 handle_DW_AT_stmt_list to here. > > If the gain is substantial, and you think it's fine, then no objection > on my end. Thanks. Committed to the 7.4 branch.