From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17937 invoked by alias); 24 Jul 2014 16:41:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17772 invoked by uid 89); 24 Jul 2014 16:41:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f170.google.com Received: from mail-vc0-f170.google.com (HELO mail-vc0-f170.google.com) (209.85.220.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 24 Jul 2014 16:41:27 +0000 Received: by mail-vc0-f170.google.com with SMTP id lf12so5283462vcb.15 for ; Thu, 24 Jul 2014 09:41:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=SthX1T9s1dFU3ducPeuegE0DqvElKkoU1/E1JfLBv70=; b=dtp0OpKOzVmeWzG2FUUh/diCi6kpXyImbspeFATRUYcksqQiIKM15M89ChfLoZ4Oa+ iOr9QmMxsHxK9E57sh19ZM0tMFlDaKdeFGbFsdAgn5c7YEpOiqzUwJE0EJuFykjozNST hToT3qSuSHHwJhnROnXLKLQ9sfILZP7BVbyiWwxXiRq8re10l3ppWD2/sL5NsnVa7kSs Xm2eK3mbvptbm4YhDEVYZKXFgJFHYnS2CiaD/qeAPsyUAAnm1gG6oQ2CLFzIU55iLdRJ WaALGWneDVsaVxG2fZJ1QjpDmVMYq3ITMQbbwJ8lYRxNDT3DiuyCPc2PNFUeEU/qRkR4 8Xzg== X-Gm-Message-State: ALoCoQkQUEjCfZIEFR2PXHD8hvkPL7uC+Cc7C4nZhzKze+E39HeCddWiQ7KJIzpLtKkTidIgLzb5 MIME-Version: 1.0 X-Received: by 10.52.157.41 with SMTP id wj9mr11712704vdb.1.1406220084686; Thu, 24 Jul 2014 09:41:24 -0700 (PDT) Received: by 10.52.28.233 with HTTP; Thu, 24 Jul 2014 09:41:24 -0700 (PDT) In-Reply-To: References: <83oay128ca.fsf@gnu.org> <87ioo7uuqm.fsf@fleche.redhat.com> Date: Thu, 24 Jul 2014 17:45:00 -0000 Message-ID: Subject: Re: [PATCH] Add Frame.read_register to Python API From: Doug Evans To: Alexander Smundak Cc: Tom Tromey , gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00647.txt.bz2 On Mon, Jul 14, 2014 at 9:13 AM, Alexander Smundak wrote: > Ping. > It has been a month since I have responded to the reviewer's comments. > Perhaps someone can take a look at this patch? > > On Mon, Jul 7, 2014 at 1:59 PM, Alexander Smundak wrote: >> Ping. >> >> On Mon, Jun 30, 2014 at 9:22 AM, Alexander Smundak wrote: >>> Ping >>> >>> On Mon, Jun 23, 2014 at 3:46 PM, Alexander Smundak wrote: >>>> Ping >>>> >>>> On Wed, Jun 18, 2014 at 10:18 AM, Alexander Smundak wrote: >>>>> Ping. >>>>> >>>>> On Wed, Jun 11, 2014 at 4:52 PM, Alexander Smundak wrote: >>>>>>> Alexander> def __init__(self, fobj): >>>>>>> Alexander> super(InlinedFrameDecorator, self).__init__(fobj) >>>>>>> Alexander> + self.fobj = fobj >>>>>>> >>>>>>> Alexander> def function(self): >>>>>>> Alexander> - frame = fobj.inferior_frame() >>>>>>> Alexander> + frame = self.fobj.inferior_frame() >>>>>>> Alexander> name = str(frame.name()) >>>>>>> >>>>>>> I think this is a nice fix but it seems unrelated to the patch at hand. >>>>>>> >>>>>>> Alexander> @defun Frame.find_sal () >>>>>>> Alexander> -Return the frame's symtab and line object. >>>>>>> Alexander> +Return the frame's @code{gdb.Symtab_and_line} object. >>>>>>> >>>>>>> Likewise. >>>>>> >>>>>> Should I mail these two as a single patch or as two separate patches? >>>>>> >>>>>>> Alexander> + FRAPY_REQUIRE_VALID (self, frame); >>>>>>> Alexander> + if (!PyArg_ParseTuple (args, "i", ®num)) >>>>>>> Alexander> + { >>>>>>> Alexander> + const char *regnum_str; >>>>>>> Alexander> + PyErr_Clear(); /* Clear PyArg_ParseTuple failure above. */ >>>>>>> Alexander> + if (PyArg_ParseTuple (args, "s", ®num_str)) >>>>>>> Alexander> + { >>>>>>> Alexander> + regnum = user_reg_map_name_to_regnum (get_frame_arch (frame), >>>>>>> Alexander> + regnum_str, >>>>>>> Alexander> + strlen (regnum_str)); >>>>>>> Alexander> + } >>>>>>> Alexander> + } >>>>>>> >>>>>>> I tend to think this would be clearer if the arguments were only parsed >>>>>>> once and then explicit type checks were applied to the resulting object. >>>>>> >>>>>> Did that, and then started doubting whether it is really necessary to read >>>>>> a register by its (very arch-specific) number. The new version supports >>>>>> reading the register by the name. Another change is that it now throws >>>>>> an exception if the name is wrong. >>>>>> >>>>>>> Alexander> +# On x86-64, PC is register 16. >>>>>>> Alexander> +gdb_test "python print ('result = %s' % ((f0.architecture().name() != 'i386:x86-64') or f0.read_register('pc') == f0.read_register(16)))" \ >>>>>>> Alexander> + "True" \ >>>>>>> Alexander> + "test Frame.read_register(regnum)" >>>>>>> >>>>>>> A test that is arch-specific needs to be conditionalized somehow. >>>>>> IMHO it's borderline arch-specific -- it is runnable on any platform, >>>>>> although it will not be testing much on any but x86-64. There hasn't >>>>>> been any arch-specific tests for Python so far, so I am not sure what to do. >>>>>> >>>>>> Here's the new version (style violations have been addressed, too): >>>>>> >>>>>> The ability to read registers is needed to use Frame Filter API to >>>>>> display the frames created by JIT compilers. >>>>>> >>>>>> gdb/Changelog >>>>>> 2014-06-11 Sasha Smundak >>>>>> >>>>>> * python/py-frame.c (frapy_read_register): New function. >>>>>> >>>>>> 2014-06-11 Sasha Smundak >>>>>> >>>>>> * python.texi (Frames in Python): Add read_register description. >>>>>> >>>>>> 2014-06-11 Sasha Smundak >>>>>> >>>>>> * gdb.python/py-frame.exp: Test Frame.read_register. Hi. For myself, I don't like to step in once another reviewer has engaged the patch. [Not that I won't. Only that I don't want to usurp someone else's review - it's hard to make sure one has sufficiently covered everything the other reviewer raised as issues.] Eli, I realize the doc parts are ok. Thanks! Tom: Anything else that needs to be done?