From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14390 invoked by alias); 10 Jan 2015 00:45:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14378 invoked by uid 89); 10 Jan 2015 00:45:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-ob0-f172.google.com Received: from mail-ob0-f172.google.com (HELO mail-ob0-f172.google.com) (209.85.214.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 10 Jan 2015 00:45:29 +0000 Received: by mail-ob0-f172.google.com with SMTP id va8so15778298obc.3 for ; Fri, 09 Jan 2015 16:45:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=hwl9FQoVC8dzHn3ZnMCJYNCp9dnILxX9VvM5hOeNF1E=; b=cMsSx0ADvt/et/ed+nW2tlbRdzfSZITQa3SrBNBQ0lG2hfsWN+qwMTNKY+ySKGA6g/ gSK9lWHj0Z+vzhygN6UCLc+5yihePK+7ZVvLPlbiZCzGr/8ABNNKUaoadeJvWoxiUgCq yAeHzZRB8u2TK7S1a43JPglq9zxAoMSdcYsV6YV5zBKJBLQDOYYQf1XnQAecb3JVwnVX R48FubmINTVo+aAl8wFJSPKD6oWVa6bZBRDqzxHPYxkiEcVlisNKTizOUXAAfR/xRV9G xMSiKSRssL23lernV95Z/MQijekx7SRfNF7foVqC6QIGjR8CWqmZEBAyYOqyqTTlXSHz EPsA== X-Gm-Message-State: ALoCoQlk5c5tjEmukHLlNetQAmvdswOpP/zZZQpBRCelBt57G1anYx6w7NHQys8CklL2ibLIpfgR MIME-Version: 1.0 X-Received: by 10.60.144.194 with SMTP id so2mr10968555oeb.65.1420850727292; Fri, 09 Jan 2015 16:45:27 -0800 (PST) Received: by 10.182.222.98 with HTTP; Fri, 9 Jan 2015 16:45:27 -0800 (PST) In-Reply-To: <54afff61.6790420a.0fa7.4f63SMTPIN_ADDED_BROKEN@mx.google.com> References: <54ae4586.01e3440a.7b06.fffff844SMTPIN_ADDED_BROKEN@mx.google.com> <54AE605A.8050308@redhat.com> <54ae7f9f.c323460a.36ed.ffffff30SMTPIN_ADDED_BROKEN@mx.google.com> <54AE8914.4010507@redhat.com> <54ae911b.85e3440a.1d96.5ffdSMTPIN_ADDED_BROKEN@mx.google.com> <54AFB2E5.5080307@redhat.com> <54afff61.6790420a.0fa7.4f63SMTPIN_ADDED_BROKEN@mx.google.com> Date: Sat, 10 Jan 2015 00:45:00 -0000 Message-ID: Subject: Re: [RFA PATCH 2/3] Add debug-stabs debug-dwarf and class option for pascal compiler From: Doug Evans To: Pierre Muller Cc: Pedro Alves , gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg00243.txt.bz2 On Fri, Jan 9, 2015 at 8:18 AM, Pierre Muller wrote: > This part adds support for > pascal specific compilation option: > - "debug-stabs" to force use of stabs debugging format. > - "debug-dwarf" to force use of dwarf debugging format. > - "class" to enable pascal "class" types. > > gdb/testsuite/Changelog entry : > > 2015-01-09 Pierre Muller > > * lib/pascal.exp (gpc_compile): Handle new options: > "debug-stabs", "debug-dwarf" and "class". > (fpc_compile): Likewise. > --- > gdb/testsuite/lib/pascal.exp | 42 > ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 42 insertions(+) > > diff --git a/gdb/testsuite/lib/pascal.exp b/gdb/testsuite/lib/pascal.exp > index 994e3da..587352c 100644 > --- a/gdb/testsuite/lib/pascal.exp > +++ b/gdb/testsuite/lib/pascal.exp > @@ -91,6 +91,27 @@ proc gpc_compile {source dest type options} { > append add_flags " -g" > } > } > + if { $i == "debug-stabs" } { > + if [board_info $dest exists debug_stabs_flags] { > + append add_flags " [board_info $dest debug_stabs_flags]" > + } else { > + append add_flags " -gstabs" > + } > + } > + if { $i == "debug-dwarf" } { > + if [board_info $dest exists debug_dwarf_flags] { > + append add_flags " [board_info $dest debug_dwarf_flags]" > + } else { > + append add_flags " -gdwarf-2" > + } > + } > + if { $i == "class" } { > + if [board_info $dest exists pascal_class_flags] { > + append add_flags " [board_info $dest pscal_class_flags]" > + } else { > + append add_flags " --extended-syntax" > + } > + } > } > > set result [remote_exec host $gpc_compiler "-o $dest --automake > $add_flags $source"] > @@ -120,6 +141,27 @@ proc fpc_compile {source dest type options} { > append add_flags " -g" > } > } > + if { $i == "debug-stabs" } { > + if [board_info $dest exists debug_stabs_flags] { > + append add_flags " [board_info $dest debug_stabs_flags]" > + } else { > + append add_flags " -gs" > + } > + } > + if { $i == "debug-dwarf" } { > + if [board_info $dest exists debug_dwarf_flags] { > + append add_flags " [board_info $dest debug_dwarf_flags]" > + } else { > + append add_flags " -gw" > + } > + } > + if { $i == "class" } { > + if [board_info $dest exists pascal_class_flags] { > + append add_flags " [board_info $dest pscal_class_flags]" > + } else { > + append add_flags " -Mobjfpc" > + } > + } > } > > set result [remote_exec host $fpc_compiler "-o$dest $add_flags > $source"] > -- > 2.1.1 Hi. This patch makes me uncomfortable. It's to a pascal specific file, so at least the discomfort is contained :-), but I wouldn't want this spreading. How to select debug information should be orthogonal to compilation language, and there are a myriad of ways to select what kind of dwarf debug info to get (with/without type units, with/without .gdb_index, with/without dwz, and so on). I have board files to help me drive the various combinations I'm interested in. This won't work if gdb.pascal/* starts hardcoding debug info into the test. Maybe there's a good reason to do it this way for pascal, but I need more data.