From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vtjnash@gmail.com>
Received: from mail-ua1-x941.google.com (mail-ua1-x941.google.com
 [IPv6:2607:f8b0:4864:20::941])
 by sourceware.org (Postfix) with ESMTPS id 62E103858010
 for <gdb-patches@sourceware.org>; Fri, 27 Nov 2020 20:50:10 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 62E103858010
Received: by mail-ua1-x941.google.com with SMTP id g3so1860425uae.7
 for <gdb-patches@sourceware.org>; Fri, 27 Nov 2020 12:50:10 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=m7S3L+TP/VXqZtmHkAPievlz9KJaZ/pzwPWLDaWP3U0=;
 b=ZZBSs7zNsoBNtHPwWPKY8BUHdWD806jHwJIECzQ9l0eDAt12dkEtbFeI2KHgfcsQjq
 06Q5t5uL4atyG2dQbh2G26+K6bCSOy3VNNVZby38Lp6gBTged5mXKsFanWdE73orkJx5
 qquR5BLAU+I+CWNbH8d0pHllbqtSpsvioMduKLB0erqONmD/Xke1g+HP5U+REE6mHjmp
 k4ZWkVqOBMUqAAM4vLA21jMMkFA/Yrm0WR85u52kBdJWUV5cMLJDdbTukAdZBd3b7gvb
 4uIJ2XjROnxdgTuP/ykoXO3JRsN7Dj3+RZT1edjbcgPvMWW1/aq52doSdJfGCVNFdddr
 G7OQ==
X-Gm-Message-State: AOAM532HDelULLHHLeLXdI7oYlGODrxbV4Ps+t8h7gza+2xvZ0I1wWl0
 bfwzkgLkvj1C/evRAJ+eNkzFe9x1ooUz060EVxUdRQ4nGfE=
X-Google-Smtp-Source: ABdhPJwIbSJFJ4a5m/t2yDfvLckbC6srF4DoLqGgioYCv7cb2trWHddzss85ddZkU2nzsei3AMw4n2D0MUFdfH8nRDA=
X-Received: by 2002:ab0:60d3:: with SMTP id g19mr6588985uam.133.1606510209935; 
 Fri, 27 Nov 2020 12:50:09 -0800 (PST)
MIME-Version: 1.0
References: <20201126181121.31219-1-vtjnash@gmail.com>
 <2bb948a7-e909-8949-7486-2aec0c4a9ecf@simark.ca>
In-Reply-To: <2bb948a7-e909-8949-7486-2aec0c4a9ecf@simark.ca>
From: Jameson Nash <vtjnash@gmail.com>
Date: Fri, 27 Nov 2020 15:49:54 -0500
Message-ID: <CADnnjUXKxJQRDSr_S_b=LxHAOwaj7iyUVcGGWSz-f4B8=bK67g@mail.gmail.com>
Subject: Re: [PATCH] gdb: define COFF file offsets with file_ptr
To: Simon Marchi <simark@simark.ca>
Cc: gdb-patches@sourceware.org
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, HTML_MESSAGE,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Nov 2020 20:50:11 -0000

> linetab_size was unsigned, so maybe use ufile_ptr to keep it that way?

It's (currently) computed as the difference of two file_ptr values. The
result should be positive, certainly, as it's later used as either a file
offset (with a printed warning) and as a size_t. But I'm more inclined to
keep it common with the other values here, and use `file_ptr`, which is a
signed integer type like `off_t` and `ssize_t`.