From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com [IPv6:2607:f8b0:4864:20::f35]) by sourceware.org (Postfix) with ESMTPS id 0641F3858D28 for ; Sun, 14 Apr 2024 02:50:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0641F3858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=obs.cr Authentication-Results: sourceware.org; spf=none smtp.mailfrom=obs.cr ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0641F3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::f35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713063041; cv=none; b=vdydw2gcQY2cOV1DQMd8fxwvenlSxUyrNw6sWk3h7zuITN+MyI7xqUUwvcORvaAXTo/q9uzVkzG3x40l9i3pF0kq65V+10mZGhkSkDLJ6Iks1xBDAlmVlGhIlEzme/XiidywriuvY64CClJlqc5NJO3tuCpakNGzi520QRHVnkI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713063041; c=relaxed/simple; bh=y1Br3e7qOq5V5uvp0su01TQvchxEfxOwwrLiyKvYL4A=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=FaTOb2xYEXA0+t+qHrSesz/u2J2s3jNAGv6lwVLCfrYEwNAc5yL0kyfGaJ70/mwPE6nbWtP8eAwOj8LkCWnFFu/vC9PUniK8fqGYUVdCHjLD8sAWhPcnh3kQz7z7Ojuynl4D1aRKPsRKC1s3R07GF2MW1oiN5BixPaYQAwU2sM4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-qv1-xf35.google.com with SMTP id 6a1803df08f44-69b514d3cf4so18361636d6.0 for ; Sat, 13 Apr 2024 19:50:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=obs-cr.20230601.gappssmtp.com; s=20230601; t=1713063037; x=1713667837; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DAedJhbrVFcww/my3AiqCiIGFYp5CKkAXfBBUckPe94=; b=iPNBjqMF74Co7/Bm/Z+zzu2UTFCkfHJxqzcFSwu1FWGumwslk81J64TULd/Adv99fW JoEUTy0uuIk7cLkKgmHPLoC+yWWZtOcMO6Q1zrVMtl+CuXsEb7fh2YSAoI7UmmnKJUdC 7q6O5ebhgzOUvniCtmT35sbx4TffMePoph8AR3hCinuqa4lpoFbWUZ361FgdCW3sUFAX jGAP9S84y0qMbGcKHsT6d7hvVsVhQ/OiQUPJLErdttBNZQDXiq+RYnN390vKBjfO0r+m HGj7X55/VpbKMwjMUaUPb53ur1mhjjlJcgu0kb8pAT6lrvA+4M+5ttLAGxhtcsFcgKoV W7RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713063037; x=1713667837; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DAedJhbrVFcww/my3AiqCiIGFYp5CKkAXfBBUckPe94=; b=f9KFej0WhGIiXUYUnOHlvDJfmzg82VRuIfSwXyh61oIKNamLqUrbkutLi7nAoOFwN6 77bS3YBWlJU0xL0s4W7fSKM0iGo3dVoOTET4jG01wK2bDmWxj3VAUzmFy3UTFo1F8xSm /+kKLMfMfsIv8EERO0x/rl8NbOtgnGyFMdTY3OujEMTWyiE5beaSQRg0Q5FubrHT6gvU T8JxAZeUdwH9pEDWlA4f6LPIWSvJlpxJjELUx7RXai+NJuvz+vfD/v7Px3DQN6FxqOPa 1CgJIHP8ODVzA1tfvXBP0htEn4u2rSmeSIgjyMMYqRq1kete0OV/jDxEOhkNHkyPa6GM DDzg== X-Gm-Message-State: AOJu0Yy0RT2YOstjCEBYFaU9MFhP46xyAZM6/EBx+ybir3AwDyQvGiOK bWqyUrtlZONaAhQ6E+D8H6eYdnJ3uyJ2ZrDmjTXkl2VGqmvr2h+fYxXUerRHt/FcQd7/4r0cq1c NygHHI6Q43xAvPxbMNUeDYuzCA8cl0VhX6wCQY0evM+4VC+sQxbY= X-Google-Smtp-Source: AGHT+IGs3V98g4Lu5iXUbFnIPSR8doK5E8+i5n97R2jr/a9QFPT/FoKVo91Gl3xqjHhgQKzhk5QOMDBKMDPgIF//43w= X-Received: by 2002:a05:6214:1411:b0:69b:542e:6adb with SMTP id pr17-20020a056214141100b0069b542e6adbmr6649600qvb.0.1713063036913; Sat, 13 Apr 2024 19:50:36 -0700 (PDT) MIME-Version: 1.0 References: <20240412185525.171292-1-hawkinsw@obs.cr> In-Reply-To: From: Will Hawkins Date: Sat, 13 Apr 2024 22:50:25 -0400 Message-ID: Subject: Re: [PATCH v5] gdb: Support embedded source in DWARF To: Tom de Vries Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Apr 12, 2024 at 4:12=E2=80=AFPM Tom de Vries wro= te: > > On 4/12/24 20:55, Will Hawkins wrote: > > + DW_LNE_set_address main_end > > + line [gdb_get_line_number "main end"] > > + DW_LNS_copy > > + > > + DW_LNE_end_sequence > > + } > I've just submitted a patch series designed to catch this ( > https://sourceware.org/pipermail/gdb-patches/2024-April/207922.html ). > > The copy produces a line table entry with empty address range (because > the end_sequence is at the same address),. > > This is probably not what you intended. What I get for doing copy/paste! A v6 is on its way! Thank you for the eagle eyes! On a semi-related note, it appears that "many" of the dwarf2 tests do not properly specify add_dummy_cus 0 in their invocation of Dwarf::assemble resulting in two CUs being generated in the .S file. This does not appear to cause problems for the tests, but if you run the generated binaries through a "dwarf validator", e.g., llvm-dwarfdump, they will report errors. I have requested an account on the gdb bugzilla to report a bug and will file a related patch as a fix, if that is okay with you? Will > > Thanks, > - Tom >