From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) by sourceware.org (Postfix) with ESMTPS id 39C64388E806 for ; Wed, 9 Jun 2021 09:41:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 39C64388E806 Received: by mail-qk1-x72c.google.com with SMTP id u30so22999665qke.7 for ; Wed, 09 Jun 2021 02:41:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/OpBcKoCgORpXnmTKFWUxXpwTLcb+dsmvO/6qTUB9EE=; b=gNDutg7BrQuzlXTB4C5H+DUuB/f9s4/kml56P0IuytgEgW4ZuL4oNruvUylYHbO3fi mXFTsLm/bePjzzsx+5N4s8EVxEZx9XdbupAtQsPOuLY46rD5SYclpz/bpnyGokj/+UGy bkYfwdzcP/ie/OWeeUn7jqZeqr4eI5M4M1yI/qvezeBUP6gq2d6jpzS0ygl9DBL0XWxP onEf6z5W4Lmv/ulWp/hQYzlP7Wwtnk7rzOimspoJjo6YAP4DN1Xm/Mff0iLbHSf8vC6O ghzC7xHrwhyDGm/E8XH5H0hfDPpY+R+d+C4bfRYiP3A83XEeirB8ngI9ss/ULfxNzEe5 9zKQ== X-Gm-Message-State: AOAM531kWYmdqE8vdMsJTf5o/kYfGRmOqqQs4S0TDluseGRC67LISnjh ctozDB8ctiotYePuA7ktLZ/m0o4ZCH04+4MYXClj6g== X-Google-Smtp-Source: ABdhPJwVsPFe1yaHZZCUjJ9uRgRox2wS98SGRIHffxl2U5FZWu8y6U2uq3urGPtiIvWeM7CHcladRmDtrOtuk35YzwY= X-Received: by 2002:a05:620a:753:: with SMTP id i19mr26264301qki.320.1623231714647; Wed, 09 Jun 2021 02:41:54 -0700 (PDT) MIME-Version: 1.0 References: <20210412140128.296921-1-sroettger@google.com> In-Reply-To: From: =?UTF-8?Q?Stephen_R=C3=B6ttger?= Date: Wed, 9 Jun 2021 11:41:42 +0200 Message-ID: Subject: Re: [PATCH] Update btrace data in maintenance btrace commands To: "Metzger, Markus T" Cc: "gdb-patches@sourceware.org" , Simon Marchi Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000c35a4205c4521567" X-Spam-Status: No, score=-26.9 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2021 09:41:56 -0000 --000000000000c35a4205c4521567 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Ah that makes sense. Thanks Markus and Simon. You're right, in the end I didn't rely on these commands. Though when I sta= rted playing with btrace, it did make me think btrace was broken on my machine a= nd it took me a bit to figure out what's going on. So I think this change can still be valuable to save others the headache :). Let me know what you think, if you think it's valuable I'll send a v2 with = the proposed change. Cheers, Stephen On Tue, Jun 8, 2021 at 4:05 PM Metzger, Markus T wrote: > > Hello Stephen, > > >On 2021-04-12 10:01 a.m., Stephen R=C3=B6ttger via Gdb-patches wrote: > >> diff --git a/gdb/record-btrace.c b/gdb/record-btrace.c > >> index b7b3c91f85d..79a6e47a4a6 100644 > >> --- a/gdb/record-btrace.c > >> +++ b/gdb/record-btrace.c > >> @@ -269,7 +269,7 @@ require_btrace_thread (void) > >> Throws an error if there is no thread or no trace. This function = never > >> returns NULL. */ > >> > >> -static struct btrace_thread_info * > >> +struct btrace_thread_info * > >> require_btrace (void) > > > >Since the doc is now in the header, write: > > > >/* See record-btrace.h. */ > > > >here. > > > >I'd LGTM this patch, but I'd like Markus (the btrace specialist) to > >give it a look (I think he's away, it will be in a few weeks). > > Those maintenance commands are not intended for users. You'd really only > need them to debug issues with PT decode or recording. My main use-case = is > to clear the history, then turn on debugging and logging, and re-decode t= he > trace. Re-fetching shouldn't hurt but isn't necessary. > > Your patch LGTM (with the comment fixed) but I wonder whether there's > anything to fix, at all. If you end up needing to use those maint comman= ds, > something else may be wrong. > > Regards, > Markus. > > Intel Deutschland GmbH > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928 --000000000000c35a4205c4521567 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIPngYJKoZIhvcNAQcCoIIPjzCCD4sCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg ggz4MIIEtjCCA56gAwIBAgIQeAMYYHb81ngUVR0WyMTzqzANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA3MjgwMDAwMDBaFw0yOTAzMTgwMDAwMDBaMFQxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMSowKAYDVQQDEyFHbG9iYWxTaWduIEF0bGFz IFIzIFNNSU1FIENBIDIwMjAwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQCvLe9xPU9W dpiHLAvX7kFnaFZPuJLey7LYaMO8P/xSngB9IN73mVc7YiLov12Fekdtn5kL8PjmDBEvTYmWsuQS 6VBo3vdlqqXZ0M9eMkjcKqijrmDRleudEoPDzTumwQ18VB/3I+vbN039HIaRQ5x+NHGiPHVfk6Rx c6KAbYceyeqqfuJEcq23vhTdium/Bf5hHqYUhuJwnBQ+dAUcFndUKMJrth6lHeoifkbw2bv81zxJ I9cvIy516+oUekqiSFGfzAqByv41OrgLV4fLGCDH3yRh1tj7EtV3l2TngqtrDLUs5R+sWIItPa/4 AJXB1Q3nGNl2tNjVpcSn0uJ7aFPbAgMBAAGjggGKMIIBhjAOBgNVHQ8BAf8EBAMCAYYwHQYDVR0l BBYwFAYIKwYBBQUHAwIGCCsGAQUFBwMEMBIGA1UdEwEB/wQIMAYBAf8CAQAwHQYDVR0OBBYEFHzM CmjXouseLHIb0c1dlW+N+/JjMB8GA1UdIwQYMBaAFI/wS3+oLkUkrk1Q+mOai97i3Ru8MHsGCCsG AQUFBwEBBG8wbTAuBggrBgEFBQcwAYYiaHR0cDovL29jc3AyLmdsb2JhbHNpZ24uY29tL3Jvb3Ry MzA7BggrBgEFBQcwAoYvaHR0cDovL3NlY3VyZS5nbG9iYWxzaWduLmNvbS9jYWNlcnQvcm9vdC1y My5jcnQwNgYDVR0fBC8wLTAroCmgJ4YlaHR0cDovL2NybC5nbG9iYWxzaWduLmNvbS9yb290LXIz LmNybDBMBgNVHSAERTBDMEEGCSsGAQQBoDIBKDA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5n bG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzANBgkqhkiG9w0BAQsFAAOCAQEANyYcO+9JZYyqQt41 TMwvFWAw3vLoLOQIfIn48/yea/ekOcParTb0mbhsvVSZ6sGn+txYAZb33wIb1f4wK4xQ7+RUYBfI TuTPL7olF9hDpojC2F6Eu8nuEf1XD9qNI8zFd4kfjg4rb+AME0L81WaCL/WhP2kDCnRU4jm6TryB CHhZqtxkIvXGPGHjwJJazJBnX5NayIce4fGuUEJ7HkuCthVZ3Rws0UyHSAXesT/0tXATND4mNr1X El6adiSQy619ybVERnRi5aDe1PTwE+qNiotEEaeujz1a/+yYaaTY+k+qJcVxi7tbyQ0hi0UB3myM A/z2HmGEwO8hx7hDjKmKbDCCA18wggJHoAMCAQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUA MEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9vdCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWdu MRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEg MB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENBIC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzAR BgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4 Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0EXyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuu l9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+JJ5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJ pij2aTv2y8gokeWdimFXN6x0FNx04Druci8unPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh 6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTvriBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti +w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGjQjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8E BTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5NUPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEA S0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigHM8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9u bG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmUY/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaM ld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88 q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcya5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/f hO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/XzCCBNcwggO/oAMCAQICEAE1rJpD8V26JWoZ9eTv 0fIwDQYJKoZIhvcNAQELBQAwVDELMAkGA1UEBhMCQkUxGTAXBgNVBAoTEEdsb2JhbFNpZ24gbnYt c2ExKjAoBgNVBAMTIUdsb2JhbFNpZ24gQXRsYXMgUjMgU01JTUUgQ0EgMjAyMDAeFw0yMTAyMDYw MDAwNThaFw0yMTA4MDUwMDAwNThaMCUxIzAhBgkqhkiG9w0BCQEWFHNyb2V0dGdlckBnb29nbGUu Y29tMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAjnWnI4kAP90dRsawD4Uogh6Kcsl8 y8q9PiZmNr7PJB225F84Ep89LR9BjFgF6FoyxFu32cmjOXxEVR/Kas/QjbJlAlVgGoEcx59PiOw+ JWwDMQXVti8hWedhEcLaIRCLsdN8OQObTPFk4gp/M0LVhXMvAKKV5vwGj7BDBWz5ctZnG7K0nyoe UHoXX2QFglucmNwJ/57nJIZH4LmcN8tupmZ9I/Mh0H8LqU1IVXpPMcEBtmmSaQsRgmMae6Mv2lFK LbU24zHhazV5JJKZh5CULmPGCtz7WpsLNt+95lz0XaZnMSblZ6m0fQZJT4c6tCzMQMt8otnPljNu shQ3G5AM6QIDAQABo4IB0jCCAc4wHwYDVR0RBBgwFoEUc3JvZXR0Z2VyQGdvb2dsZS5jb20wDgYD VR0PAQH/BAQDAgWgMB0GA1UdJQQWMBQGCCsGAQUFBwMEBggrBgEFBQcDAjAdBgNVHQ4EFgQUL8hQ nbi51nPjAE5JAKdQp7AOJO8wTAYDVR0gBEUwQzBBBgkrBgEEAaAyASgwNDAyBggrBgEFBQcCARYm aHR0cHM6Ly93d3cuZ2xvYmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADCBmgYIKwYB BQUHAQEEgY0wgYowPgYIKwYBBQUHMAGGMmh0dHA6Ly9vY3NwLmdsb2JhbHNpZ24uY29tL2NhL2dz YXRsYXNyM3NtaW1lY2EyMDIwMEgGCCsGAQUFBzAChjxodHRwOi8vc2VjdXJlLmdsb2JhbHNpZ24u Y29tL2NhY2VydC9nc2F0bGFzcjNzbWltZWNhMjAyMC5jcnQwHwYDVR0jBBgwFoAUfMwKaNei6x4s chvRzV2Vb4378mMwRgYDVR0fBD8wPTA7oDmgN4Y1aHR0cDovL2NybC5nbG9iYWxzaWduLmNvbS9j YS9nc2F0bGFzcjNzbWltZWNhMjAyMC5jcmwwDQYJKoZIhvcNAQELBQADggEBABel2z+x+2srOVRD Q0viCZ2+LJuwavtDvQ4+l3Rd3XCtw5i0XQBG9VlzfbHI1zKgefvQB+JS9N+u6ROIji6eGGLOvKg0 HDjOIi2s/rnPQfY1wKxC1m5MakKFjSrUwDBKZ3wWdMdcorV3UGAYzazn8cNQaCSKtBj7oaRLLskc /g+0TO2jliiOJ11vtVzsoqIAMZKx8MZi+Dzab4X63iZmPN+HVgkpCCQLRXcsIoIPQpHDw7sUW/d6 Cr4Wi1qgaAZjiE/MFZ3b3DsinOD7ujKVTOmYTtxqC1JsGSKBQG12z01ISxJfl8fEVcwu/PvQJIOS 9uS51RBg3ao/8BwDABS6eNQxggJqMIICZgIBATBoMFQxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBH bG9iYWxTaWduIG52LXNhMSowKAYDVQQDEyFHbG9iYWxTaWduIEF0bGFzIFIzIFNNSU1FIENBIDIw MjACEAE1rJpD8V26JWoZ9eTv0fIwDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEIEy3 pspvX8q288VaC/gvf+dWdXmsp3fc8F5el/P5wPmXMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEw HAYJKoZIhvcNAQkFMQ8XDTIxMDYwOTA5NDE1NVowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQME ASowCwYJYIZIAWUDBAEWMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJ KoZIhvcNAQEHMAsGCWCGSAFlAwQCATANBgkqhkiG9w0BAQEFAASCAQAgvIuurhxD4MRiXL+FzWpA onQeWUtAZZz2wmcOlS9xWH6WUe+pPS8f5I252e2JKp+NDFowi9ThwyOAo3HxPAu2NEzHWQq6Yn1k kuter9CkKuNiOyup04Qo2UfU8FkiD8AQ/AA+GwvG0tcVKkA9UZrjN6GBRRbCYuc1RCovoZloiVGp qBCS1miES0ZdtJkRDj4mkaZ8y3vUqm1ZailZeOIwILM4LLjaDUDf+9PUvpMQ2wnogO7330Hd9LLE DkbTfdr+5Lonr9JJOdwksOMO8wePcI8jSdo/1gL0/hRbDGcoNxKfZ+xY8SobfmCufWdPRa1d5n4F q6K4vHsAhPoMFT1Q --000000000000c35a4205c4521567--